New issue
Advanced search Search tips

Issue 711713 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR



Sign in to add a comment

Support VR uiMode changes in CCT and webApks

Project Member Reported by mthiesse@chromium.org, Apr 14 2017

Issue description

Now that CCT and webapks support webVR presentation, they need to support the VR uiMode changes.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 18 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3a7aacd3d5a42bf2f8271e66f4eecff5deae7535

commit 3a7aacd3d5a42bf2f8271e66f4eecff5deae7535
Author: mthiesse <mthiesse@chromium.org>
Date: Tue Apr 18 21:50:17 2017

Ensure android:configChanges="uiMode" is handled for all ChromeActivitys

BUG= 711713 

Review-Url: https://codereview.chromium.org/2825133002
Cr-Commit-Position: refs/heads/master@{#465388}

[modify] https://crrev.com/3a7aacd3d5a42bf2f8271e66f4eecff5deae7535/chrome/android/java/AndroidManifest.xml

Labels: Merge-Request-59
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 19 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 19 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/757a9a6c6018bf9186d21f8f95c7bd13239dcd4b

commit 757a9a6c6018bf9186d21f8f95c7bd13239dcd4b
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Wed Apr 19 17:10:50 2017

Ensure android:configChanges="uiMode" is handled for all ChromeActivitys

BUG= 711713 

Review-Url: https://codereview.chromium.org/2825133002
Cr-Commit-Position: refs/heads/master@{#465388}
(cherry picked from commit 3a7aacd3d5a42bf2f8271e66f4eecff5deae7535)

Review-Url: https://codereview.chromium.org/2830743002 .
Cr-Commit-Position: refs/branch-heads/3071@{#55}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/757a9a6c6018bf9186d21f8f95c7bd13239dcd4b/chrome/android/java/AndroidManifest.xml

Status: Fixed (was: Assigned)
Components: Blink>WebXR

Sign in to add a comment