711704 - Import css21/floats W3C CSS Test Suite - chromium

Status:

Fixed

Owner:

█ glebl@chromium.org

Last visit > 30 days ago

Closed:

Apr 2017

Cc:

ikilpatrick@chromium.org

kojii@chromium.org

e...@chromium.org

Components:

Blink>Layout

EstimatedDays:

----

NextAction:

----

OS:

----

Pri:

Type:

Feature

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 23 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/126515aa5522f600413dea854dfc06f4c90f105d

commit 126515aa5522f600413dea854dfc06f4c90f105d
Author: Morten Stenshorne <mstensho@chromium.org>
Date: Tue Jan 23 20:12:17 2018

Fix and enable as many external/wpt/css/CSS2/ tests as possible.

A few were skipped for no reason. Some of them turned out to pass, while
others fail. Then there were quite a few manual tests, and those we
still need to skip.

Made some (mostly minor) changes to some of the tests to make
them pass. They were making invalid assumptions about
fonts (glyphs with unexpected negative bearing, kerning, etc.)
and line heights. One test was also assuming that painting the
same glyph multiple times would produce the exact same result as
painting it just once, but that's not necessarily true for
anti-aliasing.

It was pretty hard to figure out what
floats-clear/floats-028-ref.xht was about (old IE bug fixed?),
but I made the ref more similar to the test, so that we don't
make assumptions about line height.

Also updated expectations for LayoutNG, because it turned out that more
more of these tests pass there.

Bug:  711704 ,  711709 ,  711805 ,  711807 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I6e34e037852ef31cfe8d85688865823d6f9d2d0a
Reviewed-on: https://chromium-review.googlesource.com/873310
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531322}
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/floats-clear/clear-applies-to-008-ref.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/floats-clear/clear-applies-to-008.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/floats-clear/clear-applies-to-012.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/floats-clear/float-applies-to-008-ref.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/floats-clear/float-applies-to-008.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/floats-clear/float-applies-to-012.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/floats-clear/floats-028-ref.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/floats-clear/floats-028.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/floats-clear/floats-036-ref.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/floats-clear/floats-036.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/normal-flow/inline-table-002-ref.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/normal-flow/inline-table-valign-001-ref.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/normal-flow/width-inherit-001.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/positioning/abspos-011-ref.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/positioning/abspos-011.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/positioning/abspos-012.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/positioning/abspos-027.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/positioning/position-relative-031-ref.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/positioning/position-relative-031.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/positioning/positioning-float-001-ref.xht
[modify] https://crrev.com/126515aa5522f600413dea854dfc06f4c90f105d/third_party/WebKit/LayoutTests/external/wpt/css/CSS2/positioning/positioning-float-001.xht

Issue 711704 link

Issue metadata

Import css21/floats W3C CSS Test Suite

Issue description

Comment 1 by bugdroid1@chromium.org, Apr 14 2017

Comment 1 Deleted

Comment 2 by glebl@chromium.org, Apr 15 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Jan 23 2018

Comment 3 Deleted

Sign in to add a comment