paint/invalidation/text-match-document-change.html is failing on Mac webkit bots |
||
Issue descriptionThis test has been failing on various Mac webkit bots, starting here: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.10/builds/32585 https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11/builds/18676 (a few other Mac bots are affected as well) This affects two variants of the test: paint/invalidation/text-match-document-change.html virtual/disable-spinvalidation/paint/invalidation/text-match-document-change.html From the blamelist, suspecting https://chromium.googlesource.com/chromium/src/+/d2680c72ae7adfa4a857432179666cb6b03e0781 The tests are failing with an image diff, sample diffs here: https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac10_10/32585/layout-test-results/results.html hs1217.lee@samsung.com: can you please take a look?
,
Apr 14 2017
I'll go ahead and disable this for now.
,
Apr 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4f57bb92e57ec92f0d7d1db53920f56725b6a74e commit 4f57bb92e57ec92f0d7d1db53920f56725b6a74e Author: alexmos <alexmos@chromium.org> Date: Fri Apr 14 17:04:02 2017 Disable paint/invalidation/text-match-document-change.html on Mac BUG= 711689 NOTRY=true TBR=hs1217.lee@samsung.com Review-Url: https://codereview.chromium.org/2819843002 Cr-Commit-Position: refs/heads/master@{#464738} [modify] https://crrev.com/4f57bb92e57ec92f0d7d1db53920f56725b6a74e/third_party/WebKit/LayoutTests/TestExpectations
,
Apr 14 2017
Also, it looks like there one Mac bot config (WebKit Mac10.9) on which the regular flavor of the test passes, but the virtual/disable-spinvalidation/ flavor fails with a MISSING result. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_tests&tests=paint%2Finvalidation%2Ftext-match-document-change.html The test fails with an image diff on all other Mac bots.
,
Apr 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ad9945bf68c2f738487db424bbdcf61d68221242 commit ad9945bf68c2f738487db424bbdcf61d68221242 Author: hs1217.lee <hs1217.lee@samsung.com> Date: Mon Apr 17 07:50:39 2017 enable paint/invalidation/text-match-document-change.html on Mac text-match-document-change test was disabled temporary. because this test was failed on Mac after patch which associated about range merged. (https://codereview.chromium.org/2776103002) so enable this test again. BUG= 711689 Review-Url: https://codereview.chromium.org/2824653002 Cr-Commit-Position: refs/heads/master@{#464903} [modify] https://crrev.com/ad9945bf68c2f738487db424bbdcf61d68221242/third_party/WebKit/LayoutTests/TestExpectations [modify] https://crrev.com/ad9945bf68c2f738487db424bbdcf61d68221242/third_party/WebKit/LayoutTests/platform/mac/paint/invalidation/text-match-document-change-expected.png [modify] https://crrev.com/ad9945bf68c2f738487db424bbdcf61d68221242/third_party/WebKit/LayoutTests/platform/mac/virtual/disable-spinvalidation/paint/invalidation/text-match-document-change-expected.png
,
Apr 17 2017
hs1217.lee: thanks. r464903 fixed it for all Mac bots except for WebKit Mac10.9, which is still failing. I suspect this is due to having LayoutTests/platform/mac-mac10.9/virtual/disable-spinvalidation/paint/invalidation/text-match-document-change-expected.png, which appears to be broken (it shows up as an HTML doc with a 500 server error in codesearch).
,
Apr 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0fe1451d08ef167436488e7dbacbd8d840a5c858 commit 0fe1451d08ef167436488e7dbacbd8d840a5c858 Author: alexmos <alexmos@chromium.org> Date: Mon Apr 17 17:00:43 2017 Remove Mac10.9 expectation for text-match-document-change-expected.png The png for virtual/disable-spinvalidation/ appears to be broken anyway, and suspected to be causing failures on https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/. A Mac image expectation was added in https://codereview.chromium.org/2824653002 and should cover Mac10.9 once this is removed. Also remove the non-virtual mac-mac10.9 png, as it appears to be the same as the more generic Mac png from https://codereview.chromium.org/2824653002. BUG= 711689 TBR=hs1217.lee@samsung.com NOTRY=true Review-Url: https://codereview.chromium.org/2827453002 Cr-Commit-Position: refs/heads/master@{#464932} [delete] https://crrev.com/d1fc96d10bdc87cd447c5f95926eaefee6761d12/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/text-match-document-change-expected.png [delete] https://crrev.com/d1fc96d10bdc87cd447c5f95926eaefee6761d12/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/disable-spinvalidation/paint/invalidation/text-match-document-change-expected.png
,
Apr 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ef07b23fe53c8640375d2d6421c22fc50b94cf9e commit ef07b23fe53c8640375d2d6421c22fc50b94cf9e Author: alexmos <alexmos@chromium.org> Date: Mon Apr 17 20:33:58 2017 Revert of Remove Mac10.9 expectation for text-match-document-change-expected.png (patchset #2 id:20001 of https://codereview.chromium.org/2827453002/ ) Reason for revert: Didn't fix the Mac10.9 failures. The custom 10.9 expectation appears necessary, and should probably just be copied to the virtual/disable-spinvalidation one. Original issue's description: > Remove Mac10.9 expectation for text-match-document-change-expected.png > > The png for virtual/disable-spinvalidation/ appears to be broken anyway, and suspected to be causing > failures on > https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/. > > A Mac image expectation was added in > https://codereview.chromium.org/2824653002 and should cover Mac10.9 > once this is removed. > > Also remove the non-virtual mac-mac10.9 png, as it appears to be the same as the more generic Mac png from https://codereview.chromium.org/2824653002. > > BUG= 711689 > TBR=hs1217.lee@samsung.com > NOTRY=true > > Review-Url: https://codereview.chromium.org/2827453002 > Cr-Commit-Position: refs/heads/master@{#464932} > Committed: https://chromium.googlesource.com/chromium/src/+/0fe1451d08ef167436488e7dbacbd8d840a5c858 TBR=hs1217.lee@samsung.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= 711689 Review-Url: https://codereview.chromium.org/2824003002 Cr-Commit-Position: refs/heads/master@{#465004} [add] https://crrev.com/ef07b23fe53c8640375d2d6421c22fc50b94cf9e/third_party/WebKit/LayoutTests/platform/mac-mac10.9/paint/invalidation/text-match-document-change-expected.png [add] https://crrev.com/ef07b23fe53c8640375d2d6421c22fc50b94cf9e/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/disable-spinvalidation/paint/invalidation/text-match-document-change-expected.png
,
Apr 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7e84c3f335fc4f047d196a9ad3bab753dc9200c commit a7e84c3f335fc4f047d196a9ad3bab753dc9200c Author: alexmos <alexmos@chromium.org> Date: Mon Apr 17 21:04:16 2017 Fix broken image expectation for text-match-document-change.html BUG= 711689 TBR=hs1217.lee@samsung.com NOTRY=true Review-Url: https://codereview.chromium.org/2824703004 Cr-Commit-Position: refs/heads/master@{#465014} [modify] https://crrev.com/a7e84c3f335fc4f047d196a9ad3bab753dc9200c/third_party/WebKit/LayoutTests/platform/mac-mac10.9/virtual/disable-spinvalidation/paint/invalidation/text-match-document-change-expected.png
,
Apr 17 2017
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.9/ is green after r465014, so closing this as fixed. hs1217.lee: please verify that r465014 did the right thing. |
||
►
Sign in to add a comment |
||
Comment 1 by alex...@chromium.org
, Apr 14 2017