New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711683 link

Starred by 12 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

GPU rasterization looks broken on mac 10.12 with intel iris 6100

Project Member Reported by ah...@yandex-team.ru, Apr 14 2017

Issue description

Found this in 59.0.3071.0 on an early-2015 MBP 13" with retina, Intel Iris Graphics 6100. Many sites are rendered incorrectly when GPU rasterization is on, examples are chrome://settings, youtube.com, download-chromium.appspot.com. chrome://gpu attached.

This did not repro on Air with Intel HD 6000, no retina.
 
chrome__settings.png
79.3 KB View Download
youtube.png
159 KB View Download
download-chromium.png
129 KB View Download
chrome_gpu_M59.htm
281 KB View Download

Comment 1 by ericrk@chromium.org, Apr 14 2017

It looks like you're getting some program linking options. We've seen problems in the past with the way the shader generator interacts with system locale. Two questions:

- What locale is your system running (is it using one where the decimal separator is ","? - for example, 756,34)
- Are you launching Chrome from the command line?

Comment 2 by ericrk@chromium.org, Apr 14 2017

Labels: -Pri-3 Pri-2
Owner: bsalomon@chromium.org
Status: Assigned (was: Unconfirmed)
OK, I can repro. It appears to have to do with system locale. The minimum repro steps seem to be:

1. Open a command prompt.
2. run "export LC_NUMERIC=de_DE.UTF-8" (or another locale with non-"," decimal separator)
3. Run Chrome from the command prompt

This seems to be a case of  issue 666228  popping up again - so maybe the previous fix missed something? Can you take a look?

Comment 3 by ericrk@chromium.org, Apr 14 2017

Cc: krajshree@chromium.org jvanverth@chromium.org bsalomon@chromium.org ericrk@chromium.org
 Issue 698609  has been merged into this issue.

Comment 4 by ericrk@chromium.org, Apr 14 2017

Labels: -Pri-2 Pri-1
Bumping to P1 as we've gotten a few reports of this.

Comment 5 by a...@twardoch.com, Apr 14 2017

I'll take a look. I may have an odd locale indeed.
Re: #1: Indeed, I was running chrome from command line, and the system locale was ru_RU.UTF-8.

Comment 7 by ericrk@chromium.org, Apr 17 2017

Owner: ericrk@chromium.org
Status: Started (was: Assigned)
I have a fix in progress, thanks for all the reports / info.
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia/+/0d2c9a252e0f113a70842280d0ef7190a062fa89

commit 0d2c9a252e0f113a70842280d0ef7190a062fa89
Author: Eric Karl <ericrk@chromium.org>
Date: Mon Apr 17 20:04:47 2017

Pass LC_ALL_MASK to newlocale

This change fixes an issue with GrAutoLocaleSetter, which was
using the C library LC_ALL mask with newlocale. Instead the
xlocale LC_ALL_MASK should be used (these do not match on all
platforms).

See: http://man7.org/linux/man-pages/man3/newlocale.3.html

Bug:  711683 
Change-Id: I6dba140e72b095f75667f0dcc98480d8d4562191
Reviewed-on: https://skia-review.googlesource.com/13601
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>

[modify] https://crrev.com/0d2c9a252e0f113a70842280d0ef7190a062fa89/src/gpu/GrAutoLocaleSetter.h

Comment 9 by ericrk@chromium.org, Apr 17 2017

Labels: Merge-Request-58
Project Member

Comment 10 by sheriffbot@chromium.org, Apr 17 2017

Labels: -Merge-Request-58 Merge-Review-58 Hotlist-Merge-Review
This bug requires manual review: We are only 7 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 11 by a...@twardoch.com, Apr 17 2017

I've just also noticed the following: the problem manifests itself only when I have an external monitor connected (running in 1920x1080@2 Retina, 50 Hz). My MacBook Pro has two graphics cards, and possibly in dual monitor mode the Mac uses the oj-board Intel card. When the monitor is disconnected and only the built in display is used with the NVIDIA card, the problem does not seem to appear.
Labels: -Hotlist-Merge-Review -Merge-Review-58
Status: Fixed (was: Started)
Sounds like it's too late for M58. We'll let this roll out through M59.
Update - I missed the M59 branch without realizing it - this will roll out through M60.
Cc: ccameron@chromium.org ajha@chromium.org
 Issue 713290  has been merged into this issue.
Cc: rbasuvula@chromium.org
 Issue 710274  has been merged into this issue.

Sign in to add a comment