New issue
Advanced search Search tips

Issue 711680 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

No way to have the Tab key select only HTML controls?

Project Member Reported by isherman@chromium.org, Apr 14 2017

Issue description

Chrome Version: 59.0.3069.0 (Official Build) canary (64-bit)
OS Version: OS X 10.12.4

What steps will reproduce the problem?
1. Navigate to chrome://settings/
2. Attempt to convince Chrome that the 'Tab' key should skip over links, and only select HTML control elements.
3. Search for 'Tab' to see if I'm missing something.

What is the expected result?
  I should be able to configure this, as I was in the past.

What happens instead of that?
  I no longer see an option to configure this.  Am I just missing it?
 

Comment 1 by shrike@chromium.org, Apr 28 2017

Labels: Needs-Feedback
How was this configurable in the past?
This was previously configurable via Settings ~> Web content ~> Pressing Tab on a webpage highlights links, as well as form fields.
Screen Shot 2017-04-28 at 1.48.18 PM.png
20.0 KB View Download
Labels: -Needs-Feedback
The screenshot is from the Stable channel, Chrome version 58.0.3029.81 (Official Build) (64-bit)
Labels: Proj-MaterialDesign-WebUI OS-Linux OS-Windows
Cc: tbuck...@chromium.org dbeam@chromium.org dpa...@chromium.org
Labels: -OS-Linux -OS-Windows -Pri-3 M-59 Pri-1
Owner: bettes@chromium.org
Status: Assigned (was: Untriaged)
This is apparently a Mac-only setting. Not sure why it is limited to Mac, but we should probably add it to maintain parity with old settings.

@bettes thoughts on where this should go? I'd like to avoid increasing the Appearance section's height even more, but the simplest solution would be tacking a checkbox on the end.

@dbeam should we merge this to maintain parity?

Comment 6 by dbeam@chromium.org, May 18 2017

Cc: -dbeam@chromium.org bettes@chromium.org
Owner: dbeam@chromium.org
Status: Started (was: Assigned)
maybe we should just append a toggle row at the bottom of appearance for mac

I have no idea how this was missed.  it's sitting there plain as day with an <if mac>

https://cs.chromium.org/chromium/src/chrome/browser/resources/options/browser_options.html?type=cs&q=web-content-section&sq=package:chromium&l=648

Comment 7 by dbeam@chromium.org, May 18 2017

Labels: Hotlist-MD-Settings-Appearance

Comment 9 by dbeam@chromium.org, May 19 2017

Labels: Merge-Request-59
Status: Fixed (was: Started)
i'm happy to try this on canary soon, but adding Merge-Request-59 now so the TPMs know we might want to merge this.
Project Member

Comment 10 by sheriffbot@chromium.org, May 20 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 11 by bugdroid1@chromium.org, May 22 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/603cb31c20f0c1ca9a55800286025e035612d646

commit 603cb31c20f0c1ca9a55800286025e035612d646
Author: Dan Beam <dbeam@chromium.org>
Date: Mon May 22 18:17:10 2017

MD Settings: add missing Mac-only "tab to links" pref

R=dpapad@chromium.org
BUG= 711680 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2888303006
Cr-Original-Commit-Position: refs/heads/master@{#473039}
Review-Url: https://codereview.chromium.org/2895943003 .
Cr-Commit-Position: refs/branch-heads/3071@{#655}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/603cb31c20f0c1ca9a55800286025e035612d646/chrome/browser/extensions/api/settings_private/prefs_util.cc
[modify] https://crrev.com/603cb31c20f0c1ca9a55800286025e035612d646/chrome/browser/resources/settings/appearance_page/appearance_page.html
[modify] https://crrev.com/603cb31c20f0c1ca9a55800286025e035612d646/chrome/browser/ui/webui/settings/md_settings_localized_strings_provider.cc

Labels: TE-Verified-59.0.3071.71 TE-Verified-M59
Verified this issue on Mac OS 10.12.4 using chrome latest beta M59-59.0.3071.71. By navigating to chrome://settings observed the option 'Pressing Tab on a webpage highlights link, as well as form fields" is available as expected. Hence adding TE-Verified label.
Screen Shot 2017-05-24 at 12.25.59 PM.png
74.7 KB View Download

Sign in to add a comment