New issue
Advanced search Search tips

Issue 711674 link

Starred by 1 user
Status: Fixed
Owner:
rouslan@chromium.org
Closed: Apr 2017
Cc:
se...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Metrics for duplicate PaymentRequest.show() calls.

Project Member Reported by rouslan@chromium.org, Apr 14 2017 
It's valid for two different instances of PaymentRequest to call .show(), although browser will honor only the one request at a time. When the second request is is being rejected, the logged metric should be "NO_SHOW_CONCURRENT_REQUESTS" instead of "ABORT_REASON_INVALID_DATA_FROM_RENDERER".
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144

commit 8dbd95ed5e1531af5df3d342edaf0e8b31ef8144
Author: rouslan <rouslan@chromium.org>
Date: Tue Apr 18 02:37:07 2017

Web payments metric for multiple show() calls.

It's valid for multiple renderers to call PaymentRequest.show() at the
same time, because they are not coordinating. Chrome allows only one
renderer at a time to call PaymentRequest.show(). When the show() calls
of the other renderers are being rejected, the recorded metric should be
NO_SHOW_CONCURRENT_REQUESTS instead of
ABORT_REASON_INVALID_DATA_FROM_RENDERER.

BUG= 711674 

Review-Url: https://codereview.chromium.org/2816513004
Cr-Commit-Position: refs/heads/master@{#465110}

[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java
[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShowTwiceTest.java
[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/chrome/test/data/payments/show_twice.js
[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/tools/metrics/histograms/histograms.xml
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144

commit 8dbd95ed5e1531af5df3d342edaf0e8b31ef8144
Author: rouslan <rouslan@chromium.org>
Date: Tue Apr 18 02:37:07 2017

Web payments metric for multiple show() calls.

It's valid for multiple renderers to call PaymentRequest.show() at the
same time, because they are not coordinating. Chrome allows only one
renderer at a time to call PaymentRequest.show(). When the show() calls
of the other renderers are being rejected, the recorded metric should be
NO_SHOW_CONCURRENT_REQUESTS instead of
ABORT_REASON_INVALID_DATA_FROM_RENDERER.

BUG= 711674 

Review-Url: https://codereview.chromium.org/2816513004
Cr-Commit-Position: refs/heads/master@{#465110}

[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java
[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShowTwiceTest.java
[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/chrome/test/data/payments/show_twice.js
[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/tools/metrics/histograms/histograms.xml
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 18 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144

commit 8dbd95ed5e1531af5df3d342edaf0e8b31ef8144
Author: rouslan <rouslan@chromium.org>
Date: Tue Apr 18 02:37:07 2017

Web payments metric for multiple show() calls.

It's valid for multiple renderers to call PaymentRequest.show() at the
same time, because they are not coordinating. Chrome allows only one
renderer at a time to call PaymentRequest.show(). When the show() calls
of the other renderers are being rejected, the recorded metric should be
NO_SHOW_CONCURRENT_REQUESTS instead of
ABORT_REASON_INVALID_DATA_FROM_RENDERER.

BUG= 711674 

Review-Url: https://codereview.chromium.org/2816513004
Cr-Commit-Position: refs/heads/master@{#465110}

[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestMetrics.java
[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java
[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestShowTwiceTest.java
[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestTestBase.java
[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/chrome/test/data/payments/show_twice.js
[modify] https://crrev.com/8dbd95ed5e1531af5df3d342edaf0e8b31ef8144/tools/metrics/histograms/histograms.xml

Comment 4 by rouslan@chromium.org, Apr 18 2017

Status: Fixed (was: Started)

Comment 5 by lafo...@chromium.org, Jun 27 2017

Components: -UI>Browser>Autofill>Payments UI>Browser>Payments
►

Sign in to add a comment