Probably an issue with the 10.12 SDK?

Building on my desktop with the 10.12 SDK failed in this manner, but building on my laptop with the 10.11 SDK succeeds, so that seems like a good guess.

Ah, we probably want that include to pick up third_party/boringssl/src/include/openssl/opensslconf.h but we don't set up include dirs correcty, so on 10.11 we get "lucky" and it falls through to the system version instead, which probably doesn't exist in 10.12?

Should we include boringssl headers with <> at all (instead of "")?

mattm@'s CLs fix it so I imagine there is already a fix in flight, just not landed yet.

thakis: The header pulling in <openssl/opensslconf.h> is within BoringSSL itself which can't assume it lives at "third_party/boringssl/...". It's all a mess. Our monorepo-relative #include preference doesn't really mesh well with external projects. :-/

This CL, once I do another DEPS roll, will avoid failures here from being platform-specific, which should avoid masking problems due to us getting "lucky".
https://boringssl.googlesource.com/boringssl/+/d403be92a436a45bd9be2e016cb250e7157dfeb3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2dbc3ed538ce6f3470af81dab163ca6e3c018bbc

commit 2dbc3ed538ce6f3470af81dab163ca6e3c018bbc
Author: mattm <mattm@chromium.org>
Date: Fri Apr 14 21:43:12 2017

Fix some build deps for //extensions/browser/api/guest_view, //extensions/common, //extensions/renderer.

//extensions/browser/api/guest_view: guest_view_internal_api.h includes extensions/browser/extension_function.h. The same problem exists for other subdirs of e/b/api/guest_view/. Cannot add //extensions/browser as a dep to //extensions/browser/api/guest_view because that would create a circular dependency.
Merge all those subdir files into //extensions/browser/api and specify all the public_deps of extension_function.h there. (This doesn't fix the underlying circular includes issue, but does clean things up a little bit.)

Example failure:
In file included from gen/extensions/browser/api/generated_api_registration.cc:9:
In file included from ../../extensions/browser/api/guest_view/web_view/web_view_internal_api.h:15:
In file included from ../../extensions/browser/guest_view/web_view/web_view_guest.h:14:
In file included from ../../components/guest_view/browser/guest_view.h:9:
In file included from ../../components/guest_view/browser/guest_view_base.h:15:
In file included from ../../components/zoom/zoom_observer.h:8:
In file included from ../../components/zoom/zoom_controller.h:16:
In file included from ../../content/public/browser/web_contents_observer.h:15:
In file included from ../../content/public/browser/navigation_controller.h:24:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error: 'openssl/opensslconf.h' file not found

//extensions/common: move //content/public/common to public_deps, as extensions/common/extension_messages.h includes files from there.
//extensions/renderer: add dep on //extensions/common, as many files in extensions/renderer include extensions/common/extension_messages.h.

Example failure for both of those:
In file included from ../../extensions/renderer/service_worker_request_sender.cc:9:
In file included from ../../extensions/common/extension_messages.h:16:
In file included from ../../content/public/common/common_param_traits.h:24:
In file included from ../../content/public/common/common_param_traits_macros.h:13:
In file included from ../../content/public/common/referrer.h:10:
In file included from ../../net/url_request/url_request.h:26:
In file included from ../../net/base/net_error_details.h:9:
In file included from ../../net/http/http_response_info.h:14:
In file included from ../../net/ssl/ssl_info.h:20:
In file included from ../../net/ssl/ssl_config.h:12:
In file included from ../../net/cert/x509_certificate.h:25:
../../third_party/boringssl/src/include/openssl/base.h:68:10: fatal error: 'openssl/opensslconf.h' file not found

BUG= 711670 

Review-Url: https://codereview.chromium.org/2812013003
Cr-Commit-Position: refs/heads/master@{#464802}

[modify] https://crrev.com/2dbc3ed538ce6f3470af81dab163ca6e3c018bbc/extensions/browser/api/BUILD.gn
[delete] https://crrev.com/18281c41a2b809619b3f533c76033e1a14729944/extensions/browser/api/guest_view/BUILD.gn
[delete] https://crrev.com/18281c41a2b809619b3f533c76033e1a14729944/extensions/browser/api/guest_view/app_view/BUILD.gn
[delete] https://crrev.com/18281c41a2b809619b3f533c76033e1a14729944/extensions/browser/api/guest_view/extension_view/BUILD.gn
[delete] https://crrev.com/18281c41a2b809619b3f533c76033e1a14729944/extensions/browser/api/guest_view/web_view/BUILD.gn
[modify] https://crrev.com/2dbc3ed538ce6f3470af81dab163ca6e3c018bbc/extensions/common/BUILD.gn
[modify] https://crrev.com/2dbc3ed538ce6f3470af81dab163ca6e3c018bbc/extensions/renderer/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/487d548c3639002dbee792c672e0460da257bb17

commit 487d548c3639002dbee792c672e0460da257bb17
Author: mattm <mattm@chromium.org>
Date: Mon Apr 17 22:56:34 2017

Add //content/public/browser deps to //chrome/browser/ui/views

chrome/browser/ui/views/tabs/tab_renderer_data.h includes chrome/browser/ui/tabs/tab_utils.h which includes content/public/browser/web_contents_user_data.h.

chrome/browser/ui/views cannot have a dep on chrome/browser/ui because that would result in a circular dependency.

Including the content/public/browser dep here fixes the issue, though it's a bit ugly of a solution.

BUG= 711670 

Review-Url: https://codereview.chromium.org/2806293004
Cr-Commit-Position: refs/heads/master@{#465051}

[modify] https://crrev.com/487d548c3639002dbee792c672e0460da257bb17/chrome/browser/ui/views/BUILD.gn

https://boringssl.googlesource.com/boringssl/+/d403be92a436a45bd9be2e016cb250e7157dfeb3 should now have rolled into Chromium so, unless we have SDK-specific #includes of BoringSSL headers anywhere, hopefully any future variants of this problem should happen uniformly across old and new SDKs and get caught at the CQ.

(I was going to say uniformly across platforms, but we definitely have platform-specific #includes, so I can't claim that one.)

 Issue 731816  has been merged into this issue.