New issue
Advanced search Search tips

Issue 711641 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Task



Sign in to add a comment

Separate item type from the rest of the CollectionViewItem API

Project Member Reported by lpromero@chromium.org, Apr 14 2017

Issue description

Chrome Version (from "Settings > About Google Chrome"): 2297539ed

Item type is a CollectionViewModel/CollectionViewController concept, used for keeping track of CollectionViewItem.

The CollectionViewItem API mixes currently two concepts: item type and data holder properties.

The goal of the following proposal is to separate both, so that item type stays within the realm of CollectionViewModel/CollectionViewController, while the rest of the API can be used cleanly within the mediator layer.
https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/collection_view/collection_view_model.h
 
Status: Started (was: Assigned)
Status: Fixed (was: Started)
Fix landed in: https://codereview.chromium.org/2814273004/

Sign in to add a comment