deploy_chrome doesn't transfer *.so files even if is_debug = true and current_os != "ios" |
||||
Issue descriptionIf is_debug is true and the current OS isn't iOS, is_component_build is true, seeing BUILDCONFIG.gn(https://cs.chromium.org/chromium/src/build/config/BUILDCONFIG.gn?type=cs&q=%22is_component_build+%3D%22&l=164) If is_component_build is true, chrome runs with shared object files. Ninja actually generates such chrome. Additionally, deploy_chrome needs to transfer *.so files. However, in the present implementation of deploy_chrome, it always works as if is_component_build is false. Consequently, no *.so file is transferred by deploy_chrome.
,
May 31 2017
,
Jan 25 2018
,
Jun 14 2018
In theory this should work: https://cs.chromium.org/chromium/src/third_party/chromite/lib/chrome_util.py?type=cs&q=chrome_util.p&sq=package:chromium&g=0&l=361 I don't really have the bandwidth to test thus, and I don't think that supporting is_component_build in simple chrome is something we want to do anyway. Instead I am going to completely remove the deprecated --component arg. If a developer using this feature wants to add support to deploy_chrome, that's fine, but it's not clear to me what it gains us.
,
Jun 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/86e1b8b5a23b457b868716bb03005a5b740682cf commit 86e1b8b5a23b457b868716bb03005a5b740682cf Author: Steven Bennetts <stevenjb@chromium.org> Date: Mon Jun 18 21:16:53 2018 cros_chrome_sdk: Remove deprecated --component and --fastbuild args BUG= chromium:711618 TEST=none Change-Id: I873f07b336433c7eb020c944f35edc24caafa15b Reviewed-on: https://chromium-review.googlesource.com/1101649 Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> Tested-by: Steven Bennetts <stevenjb@chromium.org> [modify] https://crrev.com/86e1b8b5a23b457b868716bb03005a5b740682cf/cli/cros/cros_chrome_sdk.py
,
Jun 18 2018
,
Jun 19 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6cbeff6540d233d5382cc6aaed860a9cae1f8299 commit 6cbeff6540d233d5382cc6aaed860a9cae1f8299 Author: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Jun 19 00:20:08 2018 Roll src/third_party/chromite 15590d1a9bee..86e1b8b5a23b (1 commits) https://chromium.googlesource.com/chromiumos/chromite.git/+log/15590d1a9bee..86e1b8b5a23b git log 15590d1a9bee..86e1b8b5a23b --date=short --no-merges --format='%ad %ae %s' 2018-06-18 stevenjb@chromium.org cros_chrome_sdk: Remove deprecated --component and --fastbuild args Created with: gclient setdep -r src/third_party/chromite@86e1b8b5a23b The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:711618 TBR=chrome-os-gardeners@chromium.org Change-Id: Ia853f1da35b2b5403029bbf212632b5f497fb88d Reviewed-on: https://chromium-review.googlesource.com/1105217 Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#568251} [modify] https://crrev.com/6cbeff6540d233d5382cc6aaed860a9cae1f8299/DEPS |
||||
►
Sign in to add a comment |
||||
Comment 1 by dgarr...@chromium.org
, May 31 2017