Canary and beta are not compiling |
|||||||||
Issue descriptionIt seems that remoting/client/ios/host_preferences_persistence.h is breaking the compilation of official builds: https://uberchromegw.corp.google.com/i/official.ios/builders/ios-canary/builds/591/steps/compile/logs/stdio https://uberchromegw.corp.google.com/i/official.ios/builders/ios/builds/1341/steps/compile/logs/stdio As the methods defined in the .h are only implemented for chromium, the implementation is not found for official build.
,
Apr 14 2017
Issue 711681 has been merged into this issue.
,
Apr 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b1c2e7db1894fcb07f104d17343fa6912be2188 commit 3b1c2e7db1894fcb07f104d17343fa6912be2188 Author: nicholss <nicholss@chromium.org> Date: Fri Apr 14 18:52:49 2017 Fix release builds for iOS. Add stub chromium impl for preferences. BUG= 711612 Review-Url: https://codereview.chromium.org/2818153002 Cr-Commit-Position: refs/heads/master@{#464763} [modify] https://crrev.com/3b1c2e7db1894fcb07f104d17343fa6912be2188/remoting/client/ios/BUILD.gn
,
Apr 14 2017
,
Apr 14 2017
nicholss@ can we kick off a new build with that fix in place?
,
Apr 14 2017
cmasso@ yes. I think this issue should be fixed.
,
Apr 14 2017
Looks like I missed the branch cut by a few commits.
,
Apr 14 2017
,
Apr 14 2017
This bug requires manual review: We don't branch M59 until 2017-04-13. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 17 2017
Ping cmasso@ looks like you are the contact for iOS on M59. I think the branch needs this patch to be build-able.
,
Apr 17 2017
All good!
,
Apr 19 2017
Does "All good!" mean the patch has been drovered to the release branch already? I don't have rights to run that command so I would need to get someone else to do this for me. Let me know! thanks.
,
Apr 19 2017
All good meant merge approved! I will merge it into M59 for you.
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b4caf913c942614f917455d6d272e8e848ce128 commit 0b4caf913c942614f917455d6d272e8e848ce128 Author: Claude <cmasso@google.com> Date: Wed Apr 19 23:42:34 2017 Fix release builds for iOS. Add stub chromium impl for preferences. BUG= 711612 Review-Url: https://codereview.chromium.org/2818153002 Cr-Commit-Position: refs/heads/master@{#464763} (cherry picked from commit 3b1c2e7db1894fcb07f104d17343fa6912be2188) Review-Url: https://codereview.chromium.org/2827173002 . Cr-Commit-Position: refs/branch-heads/3071@{#72} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/0b4caf913c942614f917455d6d272e8e848ce128/remoting/client/ios/BUILD.gn
,
Apr 21 2017
|
|||||||||
►
Sign in to add a comment |
|||||||||
Comment 1 by nicho...@chromium.org
, Apr 14 2017