New issue
Advanced search Search tips

Issue 711608 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Search.DefaultSearchChangeOrigin histogram incorrectly emitted on browser start

Project Member Reported by a-...@yandex-team.ru, Apr 14 2017 
UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/57.0.2987.137 YaBrowser/17.4.1.353 (beta) Yowser/2.5 Safari/537.36

Steps to reproduce the problem:
Looking at TemplateURLService code I discovered that ApplyDefaultSearchChangeNoMetrics function has minor bug in comparison of search engines.

Check below must be negated :
bool changed = TemplateURL::MatchesData(initial_default_search_provider_.get(), data, search_terms_data());

Problem can lead to Search.DefaultSearchChangeOrigin histogram being not correctly emitted until TemplateURLService is loaded completely.  I will create CL with fix soon.

What is the expected behavior?

What went wrong?
Not applicable

Did this work before? N/A 

Chrome version: 57.0.2987.137  Channel: n/a
OS Version: OS X 10.11.6
Flash Version: Shockwave Flash 25.0 r0
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ef5c7c7902dc7cabb27c1c0149bf725821ce6dce

commit ef5c7c7902dc7cabb27c1c0149bf725821ce6dce
Author: a-v-y <a-v-y@yandex-team.ru>
Date: Fri Apr 14 09:06:40 2017

Fixed minor bug with Search.DefaultSearchChangeOrigin histogram

Looking at TemplateURLService code I discovered that
ApplyDefaultSearchChangeNoMetrics function has minor bug in comparison
of search engines.

BUG= 711608 
R=pkasting@chromium.org,vasilii@chromium.org

Review-Url: https://codereview.chromium.org/2810233005
Cr-Commit-Position: refs/heads/master@{#464706}

[modify] https://crrev.com/ef5c7c7902dc7cabb27c1c0149bf725821ce6dce/chrome/browser/search_engines/template_url_service_unittest.cc
[modify] https://crrev.com/ef5c7c7902dc7cabb27c1c0149bf725821ce6dce/components/search_engines/template_url_service.cc

Comment 2 by ranjitkan@chromium.org, Apr 17 2017

Labels: Needs-Triage-M57

Comment 3 by a-...@yandex-team.ru, Apr 17 2017 

I have commited fix, and think this issue can be closed.

Comment 4 by rsesek@chromium.org, Apr 17 2017

Status: Fixed (was: Unconfirmed)
►

Sign in to add a comment