New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711577 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-05-02
OS: Android , Windows , Chrome , Mac
Pri: 3
Type: Feature

Blocking:
issue 674593



Sign in to add a comment

Remove DeviceLightEvent implementation

Project Member Reported by foolip@chromium.org, Apr 14 2017

Issue description

Per https://bugs.chromium.org/p/chromium/issues/detail?id=336424#c31 DeviceLightEvent is no longer on track for standardization, which means it will not ship in Blink.

The implementation should be deleted.
 

Comment 1 by foolip@chromium.org, Apr 14 2017

Summary: Remove DeviceLightEvent implementation (was: Remove DeviceLightEvent implementations )

Comment 4 by foolip@chromium.org, Apr 17 2017

Cc: cco3@chromium.org

Comment 5 by scheib@chromium.org, Apr 18 2017

Cc: reillyg@chromium.org juncai@chromium.org
Labels: -Type-Bug Type-Feature
NextAction: 2017-05-02
Status: Available (was: Untriaged)
Let's wait a few weeks to give Edge and Firefox time to respond.
Components: -Blink>AmbientLight Blink>Sensor

Comment 7 by foolip@chromium.org, Apr 26 2017

We have an OK from Gecko: https://bugzilla.mozilla.org/show_bug.cgi?id=1356490#c4

Comment 8 by foolip@chromium.org, Apr 26 2017

Microsoft doesn't usually comment on issues filed, but they have seen it, and know where to object if they want to keep it.
Cc: rijubrat...@intel.com
Owner: juncai@chromium.org
Status: Started (was: Available)
Jun will be doing the removal.
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5a16c1d4606ab4efa34570f1ba3622c451d51c1e

commit 5a16c1d4606ab4efa34570f1ba3622c451d51c1e
Author: juncai <juncai@chromium.org>
Date: Fri Apr 28 05:26:47 2017

Remove DeviceLightEvent implementation

Per  https://crbug.com/336424#c31  DeviceLightEvent is no longer on track
for standardization. This CL removes its implementation.

BUG= 711577 

Review-Url: https://codereview.chromium.org/2845763002
Cr-Commit-Position: refs/heads/master@{#467899}

[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/content/browser/device_sensors/device_sensor_browsertest.cc
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/content/renderer/BUILD.gn
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/content/renderer/device_sensors/device_light_event_pump.cc
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/content/renderer/device_sensors/device_light_event_pump.h
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/content/renderer/device_sensors/device_light_event_pump_unittest.cc
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/content/renderer/renderer_blink_platform_impl.cc
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/content/renderer/renderer_blink_platform_impl.h
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/content/shell/renderer/layout_test/blink_test_runner.cc
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/content/shell/renderer/layout_test/blink_test_runner.h
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/content/shell/test_runner/test_runner.cc
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/content/shell/test_runner/test_runner.h
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/content/shell/test_runner/web_test_delegate.h
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/content/test/BUILD.gn
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/content/test/data/device_sensors/device_light_infinity_test.html
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/content/test/data/device_sensors/device_light_test.html
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/content/test/layouttest_support.cc
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/generic_sensor/platform_sensor_ambient_light_mac.cc
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/BUILD.gn
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/device/sensors/ambient_light_mac.cc
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/device/sensors/ambient_light_mac.h
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/android/java/src/org/chromium/device/sensors/DeviceSensors.java
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/android/javatests/src/org/chromium/device/sensors/DeviceSensorsTest.java
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/data_fetcher_shared_memory.h
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/data_fetcher_shared_memory_android.cc
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/data_fetcher_shared_memory_base.cc
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/data_fetcher_shared_memory_base_unittest.cc
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/data_fetcher_shared_memory_chromeos.cc
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/data_fetcher_shared_memory_default.cc
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/data_fetcher_shared_memory_mac.cc
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/data_fetcher_shared_memory_win.cc
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/device_sensor_host.cc
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/device_sensor_host.h
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/device_sensor_service.cc
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/device_sensor_service.h
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/device_sensors_consts.h
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/public/cpp/BUILD.gn
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/device/sensors/public/cpp/device_light_data.h
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/device/sensors/public/cpp/device_light_hardware_buffer.h
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/device/sensors/public/cpp/device_sensors_consts.h
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/device/sensors/public/cpp/device_util_mac.cc
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/device/sensors/public/cpp/device_util_mac.h
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/public/interfaces/BUILD.gn
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/device/sensors/public/interfaces/light.mojom
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/sensor_manager_android.cc
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/sensor_manager_android.h
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/device/sensors/sensor_manager_android_unittest.cc
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/services/device/device_service.cc
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/services/device/device_service.h
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/LayoutTests/ambient-light/add-listener-expected.txt
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/LayoutTests/ambient-light/add-listener.html
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/LayoutTests/ambient-light/create-event-expected.txt
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/LayoutTests/ambient-light/create-event.html
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/LayoutTests/ambient-light/multiple-event-listeners-expected.txt
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/LayoutTests/ambient-light/multiple-event-listeners.html
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/LayoutTests/ambient-light/page-visibility-expected.txt
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/LayoutTests/ambient-light/page-visibility.html
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/LayoutTests/ambient-light/rounded-lux-value-expected.txt
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/LayoutTests/ambient-light/rounded-lux-value.html
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/LayoutTests/ambient-light/window-property-expected.txt
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/LayoutTests/ambient-light/window-property.html
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createEvent-expected.txt
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/third_party/WebKit/LayoutTests/external/wpt/dom/nodes/Document-createEvent.html
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-and-gced-expected.txt
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/third_party/WebKit/LayoutTests/fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/third_party/WebKit/LayoutTests/platform/linux/fast/dom/Window/property-access-on-cached-window-after-frame-navigated-expected.txt
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/third_party/WebKit/LayoutTests/virtual/service-worker-navigation-preload-disabled/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/third_party/WebKit/Source/bindings/modules/BUILD.gn
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/third_party/WebKit/Source/core/events/EventTypeNames.json5
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/third_party/WebKit/Source/modules/BUILD.gn
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/Source/modules/device_light/BUILD.gn
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/Source/modules/device_light/DEPS
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/Source/modules/device_light/DOMWindowDeviceLight.h
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/Source/modules/device_light/DeviceLightController.cpp
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/Source/modules/device_light/DeviceLightController.h
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/Source/modules/device_light/DeviceLightDispatcher.cpp
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/Source/modules/device_light/DeviceLightDispatcher.h
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/Source/modules/device_light/DeviceLightEvent.cpp
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/Source/modules/device_light/DeviceLightEvent.h
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/Source/modules/device_light/DeviceLightEvent.idl
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/Source/modules/device_light/DeviceLightEventInit.idl
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/Source/modules/device_light/WindowDeviceLight.idl
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/third_party/WebKit/Source/modules/modules_idl_files.gni
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/third_party/WebKit/public/BUILD.gn
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/third_party/WebKit/public/platform/Platform.h
[delete] https://crrev.com/3643dc94bde2e194b0ce548ad4235ccad5bf06b1/third_party/WebKit/public/platform/WebDeviceLightListener.h
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/third_party/WebKit/public/platform/WebPlatformEventType.h
[modify] https://crrev.com/5a16c1d4606ab4efa34570f1ba3622c451d51c1e/tools/blink_rename_merge_helper/data/idl_blocklist.txt

Labels: OS-Android OS-Chrome OS-Mac OS-Windows
Status: Fixed (was: Started)

Sign in to add a comment