Omnibox - ClipboardRecentContent kAuthorizedSchemes Cleanup |
||
Issue descriptionThe file https://cs.chromium.org/chromium/src/components/open_from_clipboard/clipboard_recent_content.h defines the function IsAppropriateSuggestion(). The .cc file also has a local variable kAuthorizedSchemes[]. These are both only used in ClipboardRecentContentGeneric. For code structure reasons, they cannot be easily reused in the iOS code. We should move them down to ClipboardRecentContentGeneric so later readers of the code aren't confused that they're common logic among all subclasses.
,
May 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2fa356c2cb48d3383024a166cad38db369b99312 commit 2fa356c2cb48d3383024a166cad38db369b99312 Author: mpearson <mpearson@chromium.org> Date: Tue May 02 14:11:43 2017 Clipboard Recent Content - Code Health - Move kAuthorizedScheme into Subclass The variable and its related function is only used in one subclass, so it shouldn't sit in the base class and possibly mislead folks. BUG= 711576 Review-Url: https://codereview.chromium.org/2842793003 Cr-Commit-Position: refs/heads/master@{#468626} [modify] https://crrev.com/2fa356c2cb48d3383024a166cad38db369b99312/components/open_from_clipboard/clipboard_recent_content.cc [modify] https://crrev.com/2fa356c2cb48d3383024a166cad38db369b99312/components/open_from_clipboard/clipboard_recent_content.h [modify] https://crrev.com/2fa356c2cb48d3383024a166cad38db369b99312/components/open_from_clipboard/clipboard_recent_content_generic.cc [modify] https://crrev.com/2fa356c2cb48d3383024a166cad38db369b99312/components/open_from_clipboard/clipboard_recent_content_generic.h
,
May 2 2017
|
||
►
Sign in to add a comment |
||
Comment 1 by mpear...@chromium.org
, Apr 25 2017