Omnibox - Make (Android) Clipboard Store / Read Modification Time to Local State |
||||||
Issue descriptionThis is useful for several reasons: (i) it allows suggestions to appear when the copied URL comes from another app. (Assumig that Chrome was opened recently on the device, we can estimate the maximum age of new clipboard content. If the content is new, we can suggest it.) (ii) it allows suggestions to appear when the copied URL comes from an earlier Chrome session. (iii) it allows the suppression of clipboard suggestions to be remembered across Chrome sessions. (Currently when history is cleared, we suppress clipboard suggestions. This suppression is forgot if Chrome is restarted.)
,
Apr 21 2017
,
Apr 27 2017
Submitted as revision ee17df91c787b9da94a89bf7d19704eeb6d130c6; not sure why bugdroid didn't pick it up.
,
Apr 27 2017
,
Apr 27 2017
I'll wait until tomorrow afternoon before merging to make sure everything looks fine on canary.
,
Apr 27 2017
I'm sad this cannot get auto-approved because it lacks the bugdroid commit message... :-(
,
Apr 28 2017
Maybe I have to mark this as fixed in order for someone or some bot to notice the merge request?
,
Apr 28 2017
I'm not sure when this will be reviewed for merging. In the meantime, I'll state the justification. I belive this fits under the category "Minor/ low risk patches that cure defects in the product that would harm the default user experience" http://www.chromium.org/developers/the-zen-of-merge-requests
,
Apr 28 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 28 2017
Hurrah!
,
Apr 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72742cd0dd7ae91e429e97288eb7b877604a206f commit 72742cd0dd7ae91e429e97288eb7b877604a206f Author: Mark Pearson <mpearson@chromium.org> Date: Fri Apr 28 22:39:49 2017 Clipboard Android - Store and Read Last Modified Time from Prefs Tested by enabling clipboard provider and the clipboard interactively on a device. Clipboard suggestions are persisted to and restored from prefs, which works even if I kill Chrome. I also added LOG(INFO) lines during this and saw the writes and reads happening at the correct time and with the right values. BUG= 711574 R=bauerb@chromium.org, dcheng@chromium.org Review-Url: https://codereview.chromium.org/2832263002 . Cr-Commit-Position: refs/heads/master@{#467796} (cherry picked from commit ee17df91c787b9da94a89bf7d19704eeb6d130c6) Review-Url: https://codereview.chromium.org/2846363002 . Cr-Commit-Position: refs/branch-heads/3071@{#306} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/72742cd0dd7ae91e429e97288eb7b877604a206f/chrome/browser/BUILD.gn [modify] https://crrev.com/72742cd0dd7ae91e429e97288eb7b877604a206f/chrome/browser/android/preferences/browser_prefs_android.cc [modify] https://crrev.com/72742cd0dd7ae91e429e97288eb7b877604a206f/chrome/browser/android/preferences/browser_prefs_android.h [add] https://crrev.com/72742cd0dd7ae91e429e97288eb7b877604a206f/chrome/browser/android/preferences/clipboard_android.cc [add] https://crrev.com/72742cd0dd7ae91e429e97288eb7b877604a206f/chrome/browser/android/preferences/clipboard_android.h [modify] https://crrev.com/72742cd0dd7ae91e429e97288eb7b877604a206f/chrome/browser/chrome_browser_main_android.cc [modify] https://crrev.com/72742cd0dd7ae91e429e97288eb7b877604a206f/chrome/browser/prefs/browser_prefs.cc [modify] https://crrev.com/72742cd0dd7ae91e429e97288eb7b877604a206f/chrome/common/pref_names.cc [modify] https://crrev.com/72742cd0dd7ae91e429e97288eb7b877604a206f/chrome/common/pref_names.h [modify] https://crrev.com/72742cd0dd7ae91e429e97288eb7b877604a206f/ui/base/clipboard/clipboard_android.cc [modify] https://crrev.com/72742cd0dd7ae91e429e97288eb7b877604a206f/ui/base/clipboard/clipboard_android.h
,
May 2 2017
Verified this in 60.0.3087.3, Thanks! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by mpear...@chromium.org
, Apr 14 2017