Issue metadata
Sign in to add a comment
|
Device chooser: Paired text color has low contrast with selection background on Cocoa |
||||||||||||||||||||||||
Issue descriptionChrome 59.0.3070.0 OSX 10.12.4 What steps will reproduce the problem? (1) Pair a web USB or Bluetooth device [1] (2) Attempt to pair again with the same site. What is the expected result? The "Paired" text has high contrast. What happens instead? When the already-paired element is selected with a blue background, but the text is green. (cocoa-paired.png) The contrast ratio is 2.5, which falls below the minimum of 3 and the recommendation of 4.5: http://leaverou.github.io/contrast-ratio/#%230569D4-on-%2369C49E Windows does not have this issue because the "Paired" string is shown inline (windows.png); haven't tried on other Aura/Views UIs. If we want a seaprate line, the text should probably turn white when selected. I don't think this is so bad for now, but we should make sure we don't ship with known UI issues once web bluetooth or web USB ship without flags. reilly@, could you triage? [1] Requires flags, sites, and hardware; I'll assume people looking at this bug will know how.
,
Apr 18 2017
Added to web bluetooth's hotlist.
,
Sep 27 2017
,
Sep 27 2017
,
Sep 28 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2b90a4a3412b716d513adfa2b6594ba8d85a707d commit 2b90a4a3412b716d513adfa2b6594ba8d85a707d Author: Jun Cai <juncai@chromium.org> Date: Thu Sep 28 17:02:09 2017 Change device chooser paired text to be white when selected (Mac) On Mac, currently when an entry is selected in the device chooser, the paired text is shown as light green. This CL changes its color to be white to increase the contrast. I uploaded a screenshot on the issue page. Bug: 711563 Change-Id: I4842bfe5e1ea04fcc0a868b8d6f16b8552bd2d20 Reviewed-on: https://chromium-review.googlesource.com/688753 Reviewed-by: Robert Sesek <rsesek@chromium.org> Commit-Queue: Jun Cai <juncai@chromium.org> Cr-Commit-Position: refs/heads/master@{#505066} [modify] https://crrev.com/2b90a4a3412b716d513adfa2b6594ba8d85a707d/chrome/browser/ui/cocoa/device_chooser_content_view_cocoa.mm [modify] https://crrev.com/2b90a4a3412b716d513adfa2b6594ba8d85a707d/chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller_unittest.mm
,
Sep 28 2017
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by reillyg@chromium.org
, Apr 14 2017Owner: ortuno@chromium.org