Missing substitute_tmpl.grd in translation_expectations.pyl |
||||||||
Issue description
Recent run of translate.py -b master end failed:
Traceback (most recent call last):
File "translate.py", line 409, in end_main
copy_translations(g4_helper, git_helper, repo_info, branch)
File "translate.py", line 311, in copy_translations
repo_info.translation_expectations)
File "/usr/local/google/home/dimu/projects/scripts/helper/tc_helper.py", line 101, in get_translatable_grds
(translation_expectations_path, '\n - '.join(errors)))
Exception: /usr/local/google/home/dimu/projects/git-workdir/tools/gritsettings/translation_expectations.pyl needs to be updated. Please fix these issues:
- tools/grit/grit/testdata/substitute_tmpl.grd appears to be translatable (because it contains <file> or <message> elements), but is not listed in the translation expectations.
slan@ would you please help to add substitute_tmpl.grd to tools/gritsettings/translation_expectations.pyl?
Thank you!
,
Apr 17 2017
slan@, could you please take a look as this is blocking weekly translation extraction/dump for trunk and M59 branch 3071?
,
Apr 19 2017
We're unable to run translation on M59 (after branch) and M60. Please take a look at this ASAP. Thank you.
,
Apr 19 2017
Taking a look now.
,
Apr 19 2017
Here's the change: https://codereview.chromium.org/2827023003 Please LMK if there is a way to test!
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d81362531b4bf2904a57385292f6e3dbc152963e commit d81362531b4bf2904a57385292f6e3dbc152963e Author: slan <slan@chromium.org> Date: Wed Apr 19 23:00:55 2017 Add substitute_tmpl.grd to translation_expectations.pyl. This is a test file, and should be whitelisted from translation. Introduced in this CL: https://codereview.chromium.org/2802853003 BUG= 711550 Review-Url: https://codereview.chromium.org/2827023003 Cr-Commit-Position: refs/heads/master@{#465798} [modify] https://crrev.com/d81362531b4bf2904a57385292f6e3dbc152963e/tools/gritsettings/translation_expectations.pyl
,
Apr 20 2017
This issue is marked as a release blocker with no OS labels associated. Please add an appropriate OS label. All release blocking issues should have OS labels associated to it, so that the issue can tracked and promptly verified, once it gets fixed. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 20 2017
We need to merge it to M59 (3071) to fix translation workflow in branches as well.
,
Apr 20 2017
Approving merge to M59 branch 3071 as this is needed to run weekly translation.
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/393287c7276aed2b47b4bd85e62aaf212d15baaf commit 393287c7276aed2b47b4bd85e62aaf212d15baaf Author: dimu <dimu@google.com> Date: Thu Apr 20 21:19:53 2017 Add substitute_tmpl.grd to translation_expectations.pyl. This is a test file, and should be whitelisted from translation. Introduced in this CL: https://codereview.chromium.org/2802853003 BUG= 711550 Review-Url: https://codereview.chromium.org/2827023003 Cr-Commit-Position: refs/heads/master@{#465798} (cherry picked from commit d81362531b4bf2904a57385292f6e3dbc152963e) Review-Url: https://codereview.chromium.org/2831203003 . Cr-Commit-Position: refs/branch-heads/3071@{#99} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/393287c7276aed2b47b4bd85e62aaf212d15baaf/tools/gritsettings/translation_expectations.pyl
,
Apr 21 2017
This is fixed by cl at #6. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dimu@chromium.org
, Apr 14 2017