I can confirm that logs seem to be present in chrome://system under syslog.  Note that we don't have a way of collecting these logs for successful migrations (the migration flow ends in a reboot, which will wipe the logs).  Assuming we don't reboot after reporting an error and requiring the user recreate their profile the logs should still be there but I can't verify this until we have end-to-end testing capability.

syslog survives a reboot.

Ok, good to know.  We should be fine in either case then.

So the remaining items are to see errno is stored correctly and the logs would be useful and actionable.

Yes, although I'm not sure how to test this since I don't have a way of causing the migration to fail anymore (outside of just putting in a random return false, but that doesn't help test the logging).

From other threads we should be able to craft a broken SQLite database, broken symlink we can't delete, and a long xattr that gets corrupted.

But also you can inject failures and see how logs look like.

Ok, created an invalid file and verified that it shows up in syslog with errno string.

There was a CL to add more diagnostic information submitted.

https://chromium-review.googlesource.com/c/477690/


done?

Please tag with applicable OSs.  Thanks.

Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot