New issue
Advanced search Search tips

Issue 711543 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Task



Sign in to add a comment

Remove dialog_overrides.js script

Project Member Reported by eugene...@chromium.org, Apr 14 2017

Issue description

WKWebView does not show geolocation dialogs if it is not part of the view hierarchy.
So dialog_overrides.js script is totally useless (at least starting from iOS9).
Removing dialog_overrides.js should not affect the functionality but will greatly simplify the code. 
 
How did you test/confirm that WKWebView suppresses geolocation dialogs?
Status: Started (was: Assigned)
Tested on iOS9 and iOS10 devices:
1.) Clear browsing data
2.) Load https://mycurrentlocation.net/ (I also tried with page that I could change)
3.) Reject geolocation prompt and close the tab
4.) Open NTP and start typing https://
5.) Wait until the page is preloaded (network indicator stops spinning)
6.) Tap Go on Keyboard

Cc: linds...@chromium.org
Status: Fixed (was: Started)

Sign in to add a comment