New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711541 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[Presentation API] Code cleanup: MediaRouter browser / telemetry tests should use some special URL for testing

Project Member Reported by zhaobin@chromium.org, Apr 14 2017

Issue description

MediaRouter browser tests and telemetry tests start presentation request with URL "http://www.google.com/#__testprovider__=true". After implementing 1-UA mode, this URL will be intepreted as 1-UA URL and run 1-UA code.

We have work around in component extension explicitly rejecting test URL as 1-UA URL. It might be better to clean that up. Since general browser tests and telemetry tests are not meant for 1-UA, we may use some special URL instead of 1-UA URL for those tests.
 
Description: Show this description

Comment 2 by sko...@chromium.org, Apr 19 2017

Labels: Hotlist-Fixit-PE2017
Status: Available (was: Untriaged)

Comment 3 by mfo...@chromium.org, May 10 2017

Labels: Hotlist-CodeHealth
Owner: imch...@chromium.org
Status: Started (was: Available)
I've started looking into this. Getting this working end to end will help us identify and fix remaining issues with providing URLs with custom schemes via PresentationRequest, though I suspect that it will just work for the most part.
Project Member

Comment 5 by bugdroid1@chromium.org, Jun 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e86537c744f1410319ce3ea4659f8c022f67ece3

commit e86537c744f1410319ce3ea4659f8c022f67ece3
Author: imcheng <imcheng@chromium.org>
Date: Wed Jun 07 19:49:01 2017

[Presentation API / Media Router] Relax PresentationRequest URL check.

The idea is that instead checking if the scheme of a Presentation URL is
supported in Blink, we will do that in MR. This patch defines a
whitelist of schemes supported by MR.

This patch also enforces the scheme check on the URL given during a
presentation availability call. PresentationServiceDelegateImpl will
report availability = false for URLs of unsupported schemes.

This also fixes a problem where you actually cannot use a cast:* URL
in a https side despite having been "whitelisted" in Blink, due to the
MixedContent check (which isn't needed, since the URL does not refer to
an actual network resource).

The integration tests for desktop are also updated with new URLs,
including test:*. See accompanying extension CL: cl/158049822

BUG= 711541 

Review-Url: https://codereview.chromium.org/2927503002
Cr-Commit-Position: refs/heads/master@{#477735}

[modify] https://crrev.com/e86537c744f1410319ce3ea4659f8c022f67ece3/chrome/browser/media/router/presentation_service_delegate_impl.cc
[modify] https://crrev.com/e86537c744f1410319ce3ea4659f8c022f67ece3/chrome/browser/media/router/presentation_service_delegate_impl_unittest.cc
[modify] https://crrev.com/e86537c744f1410319ce3ea4659f8c022f67ece3/chrome/common/media_router/media_source_helper.cc
[modify] https://crrev.com/e86537c744f1410319ce3ea4659f8c022f67ece3/chrome/common/media_router/media_source_helper_unittest.cc
[modify] https://crrev.com/e86537c744f1410319ce3ea4659f8c022f67ece3/chrome/test/media_router/resources/common.js
[modify] https://crrev.com/e86537c744f1410319ce3ea4659f8c022f67ece3/third_party/WebKit/Source/modules/presentation/PresentationRequest.cpp
[modify] https://crrev.com/e86537c744f1410319ce3ea4659f8c022f67ece3/third_party/WebKit/Source/modules/presentation/PresentationRequestTest.cpp

Status: Fixed (was: Started)

Sign in to add a comment