New issue
Advanced search Search tips

Issue 711530 link

Starred by 5 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug


Participants' hotlists:
Tiff-List


Sign in to add a comment

SOM bug information missing

Project Member Reported by martiniss@chromium.org, Apr 14 2017

Issue description

Monorail started returning no information to us some time this morning. Actual root cause in monorail is unknown.

I did some digging and found that we're actually requesting duplicate issues. De-duping the issues seems to fix the problem locally. CL going out.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/50961ee9c827c6630f3edab02cab7350c7f778a6

commit 50961ee9c827c6630f3edab02cab7350c7f778a6
Author: Stephen Martinis <martiniss@google.com>
Date: Fri Apr 14 00:57:45 2017

SOM: De-dup ids we request from monorail.

We are currently requesting about 200 issue ids from monorail. It looks
like this hits some limit in monorail, and it returns 0 results from us.
We're actually requesting duplicate issue IDs though, so this CL
de-duplicates issue IDs. Local testing shows this to make monorail
return real results.

Bug: 711530
Change-Id: I5fa929a87da3abf84bd16785e4d5d796b5ea111d
Reviewed-on: https://chromium-review.googlesource.com/477503
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/50961ee9c827c6630f3edab02cab7350c7f778a6/go/src/infra/appengine/sheriff-o-matic/som/main_test.go
[modify] https://crrev.com/50961ee9c827c6630f3edab02cab7350c7f778a6/go/src/infra/appengine/sheriff-o-matic/som/annotations.go

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/50961ee9c827c6630f3edab02cab7350c7f778a6

commit 50961ee9c827c6630f3edab02cab7350c7f778a6
Author: Stephen Martinis <martiniss@google.com>
Date: Fri Apr 14 00:57:45 2017

SOM: De-dup ids we request from monorail.

We are currently requesting about 200 issue ids from monorail. It looks
like this hits some limit in monorail, and it returns 0 results from us.
We're actually requesting duplicate issue IDs though, so this CL
de-duplicates issue IDs. Local testing shows this to make monorail
return real results.

Bug: 711530
Change-Id: I5fa929a87da3abf84bd16785e4d5d796b5ea111d
Reviewed-on: https://chromium-review.googlesource.com/477503
Reviewed-by: Tiffany Zhang <zhangtiff@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>
Commit-Queue: Stephen Martinis <martiniss@chromium.org>

[modify] https://crrev.com/50961ee9c827c6630f3edab02cab7350c7f778a6/go/src/infra/appengine/sheriff-o-matic/som/main_test.go
[modify] https://crrev.com/50961ee9c827c6630f3edab02cab7350c7f778a6/go/src/infra/appengine/sheriff-o-matic/som/annotations.go

Labels: Milestone-UX
is this fixed?
Cc: martiniss@chromium.org zhangtiff@chromium.org seanmccullough@chromium.org
 Issue 687634  has been merged into this issue.
Status: Fixed (was: Started)
It's been a long time since I've seen this problem. I think martiniss's fixes solved this. 
Owner: zhangtiff@chromium.org
Status: Assigned (was: Fixed)
Spoke too soon. This is still happening. 
Labels: -Pri-2 Pri-3
Labels: Milestone-Polish

Sign in to add a comment