New issue
Advanced search Search tips

Issue 711529 link

Starred by 2 users

Issue metadata

Status: Archived
Owner: ----
Closed: Jul 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Some HTTP test started timing out after wpt import

Project Member Reported by qyears...@chromium.org, Apr 14 2017

Issue description

Specifically:

http/tests/notifications/click-shared-worker.html
http/tests/notifications/close-shared-worker.html
http/tests/notifications/update-shared-worker.html
http/tests/origin_trials/sample-api-workers.html
http/tests/permissions/test-api-surface.html
http/tests/permissions/test-query.html
http/tests/streams/piping/multiple-propagation.https.html
http/tests/workers/shared-worker-performance-timeline.html
virtual/mojo-loading/http/tests/notifications/click-shared-worker.html
virtual/mojo-loading/http/tests/notifications/close-shared-worker.html
virtual/mojo-loading/http/tests/notifications/update-shared-worker.html
virtual/mojo-loading/http/tests/origin_trials/sample-api-workers.html
virtual/mojo-loading/http/tests/permissions/test-api-surface.html
virtual/mojo-loading/http/tests/permissions/test-query.html
virtual/mojo-loading/http/tests/streams/piping/multiple-propagation.https.html
virtual/mojo-loading/http/tests/workers/shared-worker-performance-timeline.html

Import CL:
https://chromium-review.googlesource.com/c/477190/
 
Cc: qyears...@chromium.org
Components: Blink>Network
Owner: ----
Status: Available (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6703f4df6ad92a629ea4ac736f6ff26402ef139e

commit 6703f4df6ad92a629ea4ac736f6ff26402ef139e
Author: ricea <ricea@chromium.org>
Date: Wed Apr 19 05:29:15 2017

Unified error handling for WritableStream

Port the standard changes in
https://github.com/whatwg/streams/pull/721.

There are a number of behavioural changes related to error handling, which are
listed at the above URL. This implementation has no known deviations from the
standard.

The brings this implementation up to parity with
https://github.com/whatwg/streams/commit/e7bf9293d3e0b26f9221dada3723e31707db8c32.

This CL also removes failing test expectations. Issue 626703 and  711529  cover lines
that were removed from TestExpectations.

BUG= 711254 ,626703, 711529 , 684543 

Review-Url: https://codereview.chromium.org/2823563002
Cr-Commit-Position: refs/heads/master@{#465498}

[modify] https://crrev.com/6703f4df6ad92a629ea4ac736f6ff26402ef139e/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting.dedicatedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting.serviceworker.https-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/aborting.sharedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close.dedicatedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close.serviceworker.https-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/close.sharedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/constructor-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/constructor.dedicatedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/constructor.serviceworker.https-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/constructor.sharedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/error-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/error.dedicatedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/error.serviceworker.https-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/error.sharedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/properties-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/properties.dedicatedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/properties.serviceworker.https-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/external/wpt/streams/writable-streams/properties.sharedworker-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/http/tests/streams/piping/multiple-propagation.https-expected.txt
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/http/tests/streams/piping/multiple-propagation.https.html
[delete] https://crrev.com/baea08206b03227c71eeafa328185c5741f4f2e5/third_party/WebKit/LayoutTests/http/tests/streams/piping/multiple-propagation.js
[modify] https://crrev.com/6703f4df6ad92a629ea4ac736f6ff26402ef139e/third_party/WebKit/Source/core/streams/WritableStream.js

Needs to be split into separate entries for each feature for better tracking.

Comment 5 by mek@chromium.org, Nov 14 2017

Is this still valid? At least some of these tests don't seem to be currently timing out. And as pointed out in comment 3 if they were, somebody should file actual bugs for the individual failing tests so that the correct people can investigate why their tests are disabled.

Comment 6 by guidou@chromium.org, Nov 17 2017

 Issue 786345  has been merged into this issue.
Project Member

Comment 7 by bugdroid1@chromium.org, Dec 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1196a4624fc8c2b1232915ad0c5cd9c042b04cca

commit 1196a4624fc8c2b1232915ad0c5cd9c042b04cca
Author: Peter Beverloo <peter@chromium.org>
Date: Mon Dec 04 14:21:30 2017

Pass expected exception type to fix a notification test

Passing `null` no longer is allowed by testharness.js, which caused this
test to start failing. Easy fix :)

Bug:  711529 
Change-Id: I6667c6fc86bafab0dae0607b44f80aed40e192bd
Reviewed-on: https://chromium-review.googlesource.com/802557
Commit-Queue: Peter Beverloo <peter@chromium.org>
Reviewed-by: Anita Woodruff <awdf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521332}
[modify] https://crrev.com/1196a4624fc8c2b1232915ad0c5cd9c042b04cca/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/1196a4624fc8c2b1232915ad0c5cd9c042b04cca/third_party/WebKit/LayoutTests/http/tests/notifications/resources/serviceworker-notification-event.js

Project Member

Comment 8 by bugdroid1@chromium.org, Dec 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bca1add5b4c77c9dd1b08fc3cbc29fc59fcc9760

commit bca1add5b4c77c9dd1b08fc3cbc29fc59fcc9760
Author: Peter Beverloo <peter@chromium.org>
Date: Thu Dec 07 16:04:54 2017

Fix one more failing test due to assert_throws() w/ a null exception

Bug:  711529 
Change-Id: Id64a48214d682f5feba6f6a5f301b394e4a6ce42
Reviewed-on: https://chromium-review.googlesource.com/806274
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522439}
[modify] https://crrev.com/bca1add5b4c77c9dd1b08fc3cbc29fc59fcc9760/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/bca1add5b4c77c9dd1b08fc3cbc29fc59fcc9760/third_party/WebKit/LayoutTests/http/tests/security/cross-origin-createImageBitmap-structured-clone.html

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f7510c9cf818358e3c4f7bae3dbbb205e2755c5

commit 3f7510c9cf818358e3c4f7bae3dbbb205e2755c5
Author: Matt Falkenhagen <falken@chromium.org>
Date: Wed Apr 04 14:53:34 2018

Gardening: shared-worker-performance-timeline.html is passing.

It passes locally and flakiness dashboard shows it's been passing for as
far as the results go.

Bug:  711529 
TBR: kinuko
Change-Id: Ia9c75b49639c752d9d92ccbf0ee10c4cf0b3c37a
Reviewed-on: https://chromium-review.googlesource.com/995752
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#548057}
[modify] https://crrev.com/3f7510c9cf818358e3c4f7bae3dbbb205e2755c5/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 10 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4d45f94eb99412a2f47b91e602d45966a72e963

commit a4d45f94eb99412a2f47b91e602d45966a72e963
Author: Peter Mayo <petermayo@chromium.org>
Date: Fri Jul 13 01:19:55 2018

Re-enable sample-api-workers.html

https://test-results.appspot.com/dashboards/
flakiness_dashboard.html#testType=webkit_layout_tests&
tests=http/tests/origin_trials/sample-api-workers.html
shows this has been passsing across all platforms for a long time.

Bug:  711529 
Change-Id: I7dc075e73c47c8f70347e8784aad563b01463118
Reviewed-on: https://chromium-review.googlesource.com/1135633
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574800}
[modify] https://crrev.com/a4d45f94eb99412a2f47b91e602d45966a72e963/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 11 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98ab9b29b48ce2db365a2729b66641f970028b55

commit 98ab9b29b48ce2db365a2729b66641f970028b55
Author: Peter Mayo <petermayo@chromium.org>
Date: Mon Jul 16 17:23:57 2018

Re-enable 2 layout tests

https://test-results.appspot.com/dashboards/flakiness_dashboard.html
  #testType=webkit_layout_tests&tests=
  http/tests/permissions/test-api-surface.html%20
  http/tests/origin_trials/sample-api-workers.html

indicates that these tests have been passing iconsistently for a while.

Bug:  711529 ,863896
Change-Id: I409b11d70fb10309e473463fa7a4d61d7839c934
Reviewed-on: https://chromium-review.googlesource.com/1135647
Commit-Queue: Peter Mayo <petermayo@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575325}
[modify] https://crrev.com/98ab9b29b48ce2db365a2729b66641f970028b55/third_party/WebKit/LayoutTests/TestExpectations

Status: Archived (was: Available)
There is only one failure left on this bug, and given that it is now specific it seems time to close this bug.

https://bugs.chromium.org/p/chromium/issues/detail?id=863896

Sign in to add a comment