unrecognized_params for findit tryjobs on swarmbucket. |
|||
Issue description
I am getting this:
{
"error": {
"message": "unrecognized params: [u'additional_build_parameters']",
"reason": "INVALID_INPUT"
}
}
It turns out that findit needs to send and additional parameter on the request outside of properties (I think it used to be a property but it sometimes was too long), so it now is added directly inside parameters_json and is later queried by the recipe directly from buildbucket.
This is added here: https://cs.chromium.org/chromium/infra/appengine/findit/common/waterfall/buildbucket_client.py?rcl=ff15624e1d894cfdfb045c8530a9ff970a3ef021&l=52
and read here:
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/findit/api.py?rcl=b3876ae6f666748e0d0046402759e6beb4db9d49&l=298
Could swarmbucket support this as well?
,
Apr 14 2017
I'll allow user_data param. Can you rename your param?
,
Apr 14 2017
after some thinking, there is no reason to restrict the parameter name to be "user_data", so you don't have to rename your param
,
Apr 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/3cf5f86fe4a1532795aaf703696e2c11e055bf60 commit 3cf5f86fe4a1532795aaf703696e2c11e055bf60 Author: Nodir Turakulov <nodir@chromium.org> Date: Fri Apr 14 17:42:16 2017 buidlbucket: allow arbitrary params in swarmbucket builds FindIt (ab)uses buildbucket params to store their data in a buildbucket build. They don't put the data to a build property because it is too large for buildbot. Swarmbucket builds with unrecognized params are rejected, thus LUCI builds created by FindIt are rejected. Swarming-specific parameters are defined in "swarming" param, which is a composite JSON object. If we add more params, we will probably add them to swarming param. Thus, it is unlikely that allowing arbitrary build params will cause a problem. Allow arbitrary build params in Swarmbucket builds. R=vadimsh@chromium.org BUG= 711525 Change-Id: I9919f83028dc6e0fde74b001d713d8b8ed9d97a6 Reviewed-on: https://chromium-review.googlesource.com/477615 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Nodir Turakulov <nodir@chromium.org> [modify] https://crrev.com/3cf5f86fe4a1532795aaf703696e2c11e055bf60/appengine/cr-buildbucket/swarming/swarming.py [modify] https://crrev.com/3cf5f86fe4a1532795aaf703696e2c11e055bf60/appengine/cr-buildbucket/swarming/test/swarming_test.py
,
Apr 14 2017
Deployed |
|||
►
Sign in to add a comment |
|||
Comment 1 by robert...@chromium.org
, Apr 14 2017The request that caused this response is something like: { "bucket": "luci.chromium.try", "parameters_json": "{\"additional_build_parameters\": {\"compile_targets\": [\"libbase.so\", \"libbase.so.TOC\"]}, \"builder_name\": \"LUCI linux_chromium_variable\", \"properties\": {\"bad_revision\": \"445c9544f743c5fb1dee4ba1594360bb10366f92\", \"good_revision\": \"cfd215a5b6b3d1ab60398fc8c4a522b0d8ce611e\", \"recipe\": \"findit/chromium/compile\", \"referenced_build_url\": \"https://luci-milo.appspot.com/buildbot/chromium.linux/Linux%20Builder%20%28dbg%29%2832%29/66018\", \"target_buildername\": \"Linux Builder (dbg)(32)\", \"target_mastername\": \"chromium.linux\"}}" }