New issue
Advanced search Search tips

Issue 711523 link

Starred by 1 user
Status: Fixed
Owner:
dtrainor@chromium.org
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug


Show other hotlists

Hotlists containing this issue:
In-Product-Help


Sign in to add a comment

[IPH] Menu Highlight defaults to 0 for no highlight, breaks CCT

Project Member Reported by dtrainor@chromium.org, Apr 14 2017 
All CCT custom menu items have an id of 0, so this ends up highlighting all of them all the time by accident.  The fix is to either use -1 or have an Integer which can be null for no valid menu item instead of 0 (see AppMenuHandler#highlightMenuItem()).

Comment 2 by dtrainor@chromium.org, Apr 17 2017

Labels: Merge-Request-59
Status: Fixed (was: Assigned)
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 17 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 18 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d67225af599e58ef3f2b29cbd23754751cc9ff6c

commit d67225af599e58ef3f2b29cbd23754751cc9ff6c
Author: David Trainor <dtrainor@chromium.org>
Date: Tue Apr 18 21:06:18 2017

Change highlight int to Integer

Move the highlight int to an Integer to allow null.  This allows 0 to be
a valid id, which it turns out is the case in CCTs.

BUG= 711523 

Review-Url: https://codereview.chromium.org/2814243004
Cr-Commit-Position: refs/heads/master@{#464996}
(cherry picked from commit 13b8f41be9f248fd67aa1188fc453a06e3825b6d)

Review-Url: https://codereview.chromium.org/2822293003 .
Cr-Commit-Position: refs/branch-heads/3071@{#39}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/d67225af599e58ef3f2b29cbd23754751cc9ff6c/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenu.java
[modify] https://crrev.com/d67225af599e58ef3f2b29cbd23754751cc9ff6c/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuAdapter.java
[modify] https://crrev.com/d67225af599e58ef3f2b29cbd23754751cc9ff6c/chrome/android/java/src/org/chromium/chrome/browser/appmenu/AppMenuHandler.java
►

Sign in to add a comment