Chrome is requesting WebAPK updates with color rgba(0,0,0,.5019607843137255) for tests.peter.sh/notification-generator/ |
|||||
Issue descriptionChrome is requesting WebAPK updates with color rgba(0,0,0,.5019607843137255)for tests.peter.sh/notification-generator/ The WebAPK server team noticed that they were getting a lot of OneOffWebApk requests with colors which differ from what they had cached. More details are available at http://b/37152775
,
Apr 18 2017
Bug fix is at https://codereview.chromium.org/2822623002/
,
Apr 19 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c751fcc699b1d5e905870e62f453b326195e55e9 commit c751fcc699b1d5e905870e62f453b326195e55e9 Author: pkotwicz <pkotwicz@chromium.org> Date: Wed Apr 19 21:04:48 2017 [WebAPKs] Fix WebAPK updates when Web Manifest does not specify color content::Manifest::kInvalidOrMissingColor has a value which takes up more than 32 bits. This CL fixes truncation to 32 bits which was occurring in webapk_update_manager.cc sizeof(long) = 4 sizeof(int64_t) = 8 BUG= 711519 Review-Url: https://codereview.chromium.org/2822623002 Cr-Commit-Position: refs/heads/master@{#465745} [modify] https://crrev.com/c751fcc699b1d5e905870e62f453b326195e55e9/chrome/browser/android/webapk/webapk_update_manager.cc
,
Apr 20 2017
We will be able to tell if this is fixed by looking at the server logs. Unfortunately not much that can be done in the way of manual testing
,
Apr 20 2017
We should pull this onto m59
,
Apr 20 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e5b9695a7dc917cb2ee3405d03503ec24be381d3 commit e5b9695a7dc917cb2ee3405d03503ec24be381d3 Author: Peter Kotwicz <pkotwicz@google.com> Date: Thu Apr 20 17:58:49 2017 Merge M59 [WebAPKs] Fix WebAPK updates when Web Manifest does not specify color content::Manifest::kInvalidOrMissingColor has a value which takes up more than 32 bits. This CL fixes truncation to 32 bits which was occurring in webapk_update_manager.cc sizeof(long) = 4 sizeof(int64_t) = 8 BUG= 711519 Review-Url: https://codereview.chromium.org/2822623002 Cr-Commit-Position: refs/heads/master@{#465745} (cherry picked from commit c751fcc699b1d5e905870e62f453b326195e55e9) Review-Url: https://codereview.chromium.org/2834683002 . Cr-Commit-Position: refs/branch-heads/3071@{#88} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/e5b9695a7dc917cb2ee3405d03503ec24be381d3/chrome/browser/android/webapk/webapk_update_manager.cc |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by yfried...@chromium.org
, Apr 18 2017