cbuildbot is not Re-Execing after cbuildbot_launch is put in place. |
|||||
Issue descriptionCbuildbot is no longer re-execing itself with the launcher in place. This is because there was explicit logic written to ensure that we don't, if we are running from the buildroot directory (which is the new norm). This means that cbuildbot is not reflecting changes during PreCQ or CQ runs. Our changes ARE reflected in all other ways.
,
Apr 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/3fa57169cc1f54ce0b571fbabeeb45286db46962 commit 3fa57169cc1f54ce0b571fbabeeb45286db46962 Author: Don Garrett <dgarrett@google.com> Date: Fri Apr 14 23:41:34 2017 cbuildbot: Rexec based on commandline, not directory. We were deciding if cbuildbot should rexec itself based on the directory it was running from. Instead use the commandline arguments to make this decision. Also, I rewrote some unitests because I couldn't read them. BUG= chromium:711512 TEST=run_tests Change-Id: I09395b0e4369e9cbea602f614fa614f6932e6756 Reviewed-on: https://chromium-review.googlesource.com/477633 Tested-by: Don Garrett <dgarrett@chromium.org> Trybot-Ready: Don Garrett <dgarrett@chromium.org> Reviewed-by: Ningning Xia <nxia@chromium.org> Commit-Queue: Don Garrett <dgarrett@chromium.org> [modify] https://crrev.com/3fa57169cc1f54ce0b571fbabeeb45286db46962/cbuildbot/cbuildbot_run.py [modify] https://crrev.com/3fa57169cc1f54ce0b571fbabeeb45286db46962/cbuildbot/cbuildbot_run_unittest.py
,
Apr 17 2017
,
May 30 2017
,
Aug 1 2017
,
Jan 22 2018
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by dgarr...@chromium.org
, Apr 14 2017