New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711485 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Use Gcm upstream by default for invalidations.

Project Member Reported by khushals...@chromium.org, Apr 13 2017

Issue description

The feature is hidden behind a finch flag that has now expired.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 14 2017

Labels: Merge-Request-58
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 14 2017

Labels: -Merge-Request-58 Hotlist-Merge-Approved Merge-Approved-58
Your change meets the bar and is auto-approved for M58. Please go ahead and merge the CL to branch 3029 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), bhthompson@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 14 2017

Labels: -merge-approved-58 merge-merged-3029
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8cd018cea1a13992c64343d41bb546a76828ff1d

commit 8cd018cea1a13992c64343d41bb546a76828ff1d
Author: Khushal <khushalsagar@google.com>
Date: Fri Apr 14 02:35:05 2017

chrome/android: Enable gcm upstream by default for invalidations.

The feature is hidden behind a field trial check. Enable it by default.

BUG= 711485 

Review-Url: https://codereview.chromium.org/2814403003
Cr-Commit-Position: refs/heads/master@{#464632}
(cherry picked from commit 18a9048f37ca12fa560fd989d837a0de0974f88e)

Review-Url: https://codereview.chromium.org/2818933002 .
Cr-Commit-Position: refs/branch-heads/3029@{#705}
Cr-Branched-From: 939b32ee5ba05c396eef3fd992822fcca9a2e262-refs/heads/master@{#454471}

[modify] https://crrev.com/8cd018cea1a13992c64343d41bb546a76828ff1d/chrome/android/java/src/org/chromium/chrome/browser/invalidation/InvalidationController.java
[modify] https://crrev.com/8cd018cea1a13992c64343d41bb546a76828ff1d/chrome/android/junit/src/org/chromium/chrome/browser/invalidation/InvalidationControllerTest.java

Status: Fixed (was: Assigned)
Components: Services>SignIn Services>Sync

Sign in to add a comment