New issue
Advanced search Search tips

Issue 711480 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression
Proj-XR



Sign in to add a comment

Auto-presentation on headset insertion broken

Project Member Reported by mthiesse@chromium.org, Apr 13 2017

Issue description

CCT patch regressed auto-presentation. Fix is trivial.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b83238b295c362e07efb4a6d8341843de63bd708

commit b83238b295c362e07efb4a6d8341843de63bd708
Author: mthiesse <mthiesse@chromium.org>
Date: Fri Apr 14 13:07:39 2017

Fix auto-presentation on headset insertion

BUG= 711480 

Review-Url: https://codereview.chromium.org/2821433003
Cr-Commit-Position: refs/heads/master@{#464719}

[modify] https://crrev.com/b83238b295c362e07efb4a6d8341843de63bd708/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Labels: Merge-Request-59
Project Member

Comment 3 by sheriffbot@chromium.org, Apr 18 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 18 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64340d71da3e52605ba776b87ce7663c7c62e933

commit 64340d71da3e52605ba776b87ce7663c7c62e933
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Tue Apr 18 15:52:11 2017

Fix auto-presentation on headset insertion

BUG= 711480 

Review-Url: https://codereview.chromium.org/2821433003
Cr-Commit-Position: refs/heads/master@{#464719}
(cherry picked from commit b83238b295c362e07efb4a6d8341843de63bd708)

Review-Url: https://codereview.chromium.org/2828473003 .
Cr-Commit-Position: refs/branch-heads/3071@{#33}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/64340d71da3e52605ba776b87ce7663c7c62e933/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Status: Fixed (was: Started)
Components: Blink>WebXR

Sign in to add a comment