New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711468 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Bug


Sign in to add a comment

[root layer scrolls] make layout tests pass

Project Member Reported by skobes@chromium.org, Apr 13 2017

Issue description

Master bug for RLS layout test failures.
 

Comment 1 by skobes@chromium.org, Apr 13 2017

Blockedon: 711474

Comment 2 by skobes@chromium.org, Jul 12 2017

Blockedon: 741858
Blockedon: 742555
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7df3312d0b61666fb311312c73a959bf41fe6f5e

commit 7df3312d0b61666fb311312c73a959bf41fe6f5e
Author: Steve Kobes <skobes@chromium.org>
Date: Wed Jul 19 21:21:48 2017

Update RLS flag expectations.

For the first time, the flag expectations file now includes expectations for all
platforms the CQ runs layout tests on (Linux, Mac, Win).  This process was used:

1. Triggered CQ dry run with empty flag expectations file and RLS forced on in
   test runner (see patch set 1).

2. Saved {linux,mac,win}_chromium_rel_ng layout_test_results from new viewer in
   TestExpectations format, to local files named "Linux", "Mac", and "Win".

3. Ran this hacky Python script, piping stdout to the flag expectations file:
   https://pastebin.com/ikHTt5zf

Bug:  711468 
Change-Id: Iebe35ae4a637aaaae85bc9adba1d278bde80d381
Reviewed-on: https://chromium-review.googlesource.com/576353
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#487989}
[modify] https://crrev.com/7df3312d0b61666fb311312c73a959bf41fe6f5e/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 3 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0a22294fd99a6014487cc32761f659f82ac90c31

commit 0a22294fd99a6014487cc32761f659f82ac90c31
Author: Stefan Zager <szager@chromium.org>
Date: Thu Aug 03 22:40:44 2017

Get rid of custom AXObject logic for scroll-into-view

Aside from reducing code duplication, this also fixes a few
layout tests when root layer scrolling is enabled:

accessibility/scroll-to-global-point-main-window.html
accessibility/scroll-to-global-point-nested.html
accessibility/scroll-to-make-visible-nested-2.html

R=dmazzoni@chromium.org,skobes@chromium.org
BUG= 711468 

Change-Id: I1368600b7ce82f1268a69c1a345226dda66dbd03
Reviewed-on: https://chromium-review.googlesource.com/598627
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#491863}
[modify] https://crrev.com/0a22294fd99a6014487cc32761f659f82ac90c31/third_party/WebKit/LayoutTests/accessibility/scroll-to-make-visible-with-subfocus.html
[modify] https://crrev.com/0a22294fd99a6014487cc32761f659f82ac90c31/third_party/WebKit/Source/modules/accessibility/AXObject.cpp

Comment 6 by skobes@chromium.org, Sep 11 2017

Blockedon: 544140

Comment 7 by skobes@chromium.org, Sep 19 2017

Blockedon: 766497
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2b536e826c73aef810abe5c29de7ce78b1607435

commit 2b536e826c73aef810abe5c29de7ce78b1607435
Author: Stefan Zager <szager@chromium.org>
Date: Thu Sep 21 22:58:39 2017

[RootLayerScrolls] Update test expectation

With RLS enabled, there will be additional scrolling and scrolling
contents layers on the LayoutView.

BUG= 711468 
R=skobes@chromium.org

Change-Id: I861376c505661528491e4a801d7f7f6e39577f63
Reviewed-on: https://chromium-review.googlesource.com/677083
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503597}
[modify] https://crrev.com/2b536e826c73aef810abe5c29de7ce78b1607435/third_party/WebKit/LayoutTests/compositing/composite-scrollable-fixed-position-when-descendants-composite.html

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8bb9152f13259bb943e405413071ac74f3d2b95a

commit 8bb9152f13259bb943e405413071ac74f3d2b95a
Author: Stefan Zager <szager@chromium.org>
Date: Thu Sep 21 22:59:06 2017

[RootLayerScrolls] Update test expectation for hidden-with-visible-text

This test has the expected layer tree diff, but the extra text in
the output caused it to be missed by the bulk updater.

BUG= 711468 
R=skobes@chromium.org

Change-Id: I37a5d27d7cbe03f6dd3baf287363f72f2efada2f
Reviewed-on: https://chromium-review.googlesource.com/677063
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503598}
[add] https://crrev.com/8bb9152f13259bb943e405413071ac74f3d2b95a/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/contents-opaque/hidden-with-visible-text-expected.txt

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/823c46f6b1b51d0187ed1539320d6a0f60a1ff8e

commit 823c46f6b1b51d0187ed1539320d6a0f60a1ff8e
Author: Stefan Zager <szager@chromium.org>
Date: Thu Sep 21 23:03:05 2017

[RootLayerScrolls] Update test expectations

With RLS enabled, the LayoutView has additional scrolling and
scrolling contents layers.

BUG= 711468 
R=skobes@chromium.org

Change-Id: I052b329d82152fa05eeeccdbfd5823794f80eda4
Reviewed-on: https://chromium-review.googlesource.com/677084
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#503599}
[modify] https://crrev.com/823c46f6b1b51d0187ed1539320d6a0f60a1ff8e/third_party/WebKit/LayoutTests/compositing/dont-composite-select-elements.html
[modify] https://crrev.com/823c46f6b1b51d0187ed1539320d6a0f60a1ff8e/third_party/WebKit/LayoutTests/compositing/dont-composite-text-input-elements.html

Project Member

Comment 11 by bugdroid1@chromium.org, Oct 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ea3968e0c87432c0d759026fa4be13c6d54c82e

commit 2ea3968e0c87432c0d759026fa4be13c6d54c82e
Author: Stefan Zager <szager@chromium.org>
Date: Wed Oct 04 21:25:05 2017

New flag-specific baselines

This is not a complete set of new baselines.  It is based on
pattern-matching text diffs from try bot results based on two
heuristics:

1. For tests that dump the layer tree (i.e., those that output
internal.layerTreeAsText(document)), there is an expected diff in
the layer tree output of this format:

   "layers": [
     {
       "name": "LayoutView #document",
+      "bounds": [800, 600],
+      "backgroundColor": "#FFFFFF"
+    },
+    {
+      "name": "Scrolling Layer",
+      "bounds": [785, 600],
+      "drawsContent": false
+    },
+    {
+      "name": "Scrolling Contents Layer",
       "bounds": [785, 2513],
       "contentsOpaque": true,
       "backgroundColor": "#FFFFFF",

2. For tests that scroll the top-level FrameView and then dump the
layout tree (the default behavior), we expect the frame-level scroll
to be reflected in the positions of all layers; for example:

 layer at (0,0) size 800x600 scrollX 1255.00 scrollY 1023.00 scrollWidth 2055 scrollHeight 2063
   LayoutView at (0,0) size 800x600
-layer at (0,0) size 800x2063 backgroundClip at (0,0) size 800x600 clip at (0,0) size 800x600
+layer at (-1255,-1023) size 800x2063 backgroundClip at (0,0) size 800x600 clip at (0,0) size 800x600
   LayoutBlockFlow {HTML} at (0,0) size 800x2063
     LayoutBlockFlow {BODY} at (8,8) size 784x2047
       LayoutBlockFlow {DIV} at (0,0) size 2047x2047
-layer at (8,8) size 784x0
+layer at (-1247,-1015) size 784x0
   LayoutBlockFlow {DIV} at (0,0) size 784x0
 scrolled to 1255,1023

Bug:  711468 
Change-Id: I727759fdb626426af693b2bf29003ea7fba92f8b
Reviewed-on: https://chromium-review.googlesource.com/699752
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#506522}
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/absolute-inside-out-of-view-fixed-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/background-color/view-blending-base-background-expected.html
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/background-color/view-blending-base-background-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/checkerboard-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/clip-child-by-non-stacking-ancestor-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/columns/composited-in-paginated-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/contents-opaque/background-clip-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/contents-opaque/background-color-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/contents-opaque/body-background-skipped-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/contents-opaque/filter-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/contents-opaque/hidden-with-visible-child-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/contents-opaque/layer-opacity-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/contents-opaque/overflow-hidden-child-layers-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/draws-content/canvas-background-layer-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/draws-content/webgl-background-layer-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/fixed-position-changed-to-absolute-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/force-compositing-mode/no-overflow-iframe-layer-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/force-compositing-mode/overflow-hidden-iframe-layer-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/geometry/ancestor-overflow-change-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/geometry/bounds-clipped-composited-child-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/geometry/bounds-ignores-hidden-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/geometry/clip-with-shadow-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/geometry/flipped-writing-mode-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/geometry/foreground-layer-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/geometry/horizontal-scroll-composited-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/geometry/vertical-scroll-composited-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/iframes/invisible-nested-iframe-hide-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/fixed-position-and-transform-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/fixed-position-in-fixed-overflow-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/fixed-position-no-content-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/fixed-position-nonscrollable-body-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/fixed-position-out-of-view-with-backdrop-filter-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/fixed-position-under-transform-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/overflow-scroll-overlap-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/overlap-child-layer-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/overlap-clipping-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/overlap-transformed-layer-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/overlap-transformed-layer-with-transform-body-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/overlap-transforms-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/remove-clipping-layer-with-no-children-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/rotate3d-overlap-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/spanOverlapsCanvas-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/squashing-into-ancestor-clipping-layer-change-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/stacking-context-overlap-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/stacking-context-overlap-nested-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/translatez-added-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/translatez-overlap-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/layer-creation/translatez-removed-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/masks/mask-layer-size-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/accelerated-overflow-scroll-should-not-affect-perspective-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/clear-scroll-parent-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/clip-descendents-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/composited-scrolling-paint-phases-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/content-gains-scrollbars-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/content-loses-scrollbars-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/no-excessive-clip-parent-if-parent-escaped-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/overflow-auto-with-touch-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/overflow-auto-with-touch-no-overflow-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/overflow-hidden-with-touch-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/overflow-overlay-with-touch-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/overflow-overlay-with-touch-no-overflow-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/overflow-scroll-with-touch-no-overflow-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/overflow-scrollbar-layers-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/overflow-visible-with-touch-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/reparented-scrollbars-non-sc-anc-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/resize-painting-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/scroll-parent-absolute-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/scroll-parent-absolute-with-backdrop-filter-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/scroll-parent-with-non-stacking-context-composited-ancestor-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/scrollbar-layer-placement-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/scrolling-content-clip-to-viewport-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/overflow/universal-accelerated-overflow-scroll-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/rtl/rtl-absolute-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/rtl/rtl-absolute-overflow-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/rtl/rtl-fixed-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/rtl/rtl-fixed-overflow-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/rtl/rtl-relative-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/scrollbars/nested-overlay-scrollbars-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/squashing/clipping-ancestor-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/squashing/composited-bounds-for-negative-z-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/squashing/dont-squash-into-iframes-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/squashing/dont-squash-into-videos-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/squashing/iframes-are-never-squashed-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/squashing/invalidations-with-large-negative-margin-inline-content-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/squashing/no-squashing-for-filters-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/squashing/no-squashing-into-fixed-position-that-clips-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/squashing/opacity-squashed-owner-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/squashing/squash-onto-distant-relative-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/squashing/squash-onto-nephew-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/squashing/squash-onto-transform-backing-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/squashing/squash-same-transform-ancestor-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/squashing/squash-simple-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/squashing/squash-three-layers-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/squashing/squash-transform-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/squashing/squashing-inside-perspective-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/squashing/squashing-sparsity-heuristic-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/update-paint-phases-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/visibility/layer-visible-content-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/compositing/will-change/will-change-contents-suppresses-compositing-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/css3/blending/mix-blend-mode-2nd-stacking-context-composited-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/css3/blending/mix-blend-mode-composited-reason-children-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/css3/blending/mix-blend-mode-isolation-2-stacking-contexts-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/css3/blending/mix-blend-mode-isolation-layer-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/css3/blending/mix-blend-mode-isolation-remove-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/css3/filters/composited-layer-bounds-after-sw-blur-animation-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/css3/filters/composited-layer-bounds-with-composited-blur-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/css3/filters/filtered-compositing-descendant-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/css3/filters/should-not-have-compositing-layer-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/fast/borders/overflow-hidden-border-radius-force-backing-store-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/fast/multicol/composited-layer-expected.txt
[add] https://crrev.com/2ea3968e0c87432c0d759026fa4be13c6d54c82e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/absolute-display-block-to-none-expected.html
[add] https:/
Blockedon: 771832
Project Member

Comment 13 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c9067519a145a957ec37f9ba003e16e99bca06d

commit 8c9067519a145a957ec37f9ba003e16e99bca06d
Author: Steve Kobes <skobes@chromium.org>
Date: Fri Oct 06 07:19:37 2017

Regenerate RLS flag expectations.

These were produced with the new try-flag script (http://crrev.com/c/699658/3),
using the workflow described at the top of try_flag.py.

The number of failures is dramatically smaller thanks to the recent rebaseline
in http://crrev.com/506522.

Bug:  711468 
Change-Id: I976f0fa1c26025b5a72787eccdf4e15401e9c87a
Reviewed-on: https://chromium-review.googlesource.com/704269
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#507000}
[modify] https://crrev.com/8c9067519a145a957ec37f9ba003e16e99bca06d/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls

Blockedon: 773362
Blockedon: 773376
Project Member

Comment 16 by bugdroid1@chromium.org, Oct 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b70d5c34988b5f83354cf1f927c2d89097e0989e

commit b70d5c34988b5f83354cf1f927c2d89097e0989e
Author: Stefan Zager <szager@chromium.org>
Date: Fri Oct 13 06:37:23 2017

[root layer scrolls] More test rebaselines

More baselines identified by the same process as:

https://chromium-review.googlesource.com/699752

BUG= 711468 
R=skobes@chromium.org,pdr@chromium.org

Change-Id: Id46fc9420b7ca1f3018c99518039af02d4028e75
Reviewed-on: https://chromium-review.googlesource.com/716824
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#508619}
[modify] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/nested-fixed-iframe-scrolled-expected.txt
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/clip-path-child-changes-expected.txt
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/clip-path-href-changes-expected.txt
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/clip-path-id-changes-expected.txt
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/clip-path-units-changes-expected.txt
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/foreignObject-crash-on-hover-expected.txt
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/js-update-bounce-expected.txt
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/marker-child-changes-css-expected.txt
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/marker-child-changes-expected.txt
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/marker-strokeWidth-changes-expected.txt
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/marker-viewBox-changes-expected.txt
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/mask-child-changes-expected.txt
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.txt
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.txt
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/resource-invalidate-on-target-update-expected.txt
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/table/collapsed-border-change-rowspan-expected.txt
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/video-paint-invalidation-expected.txt
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/invalidation/svg/text-repaint-including-stroke-expected.txt
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/svg/text-repaint-including-stroke-expected.txt
[add] https://crrev.com/b70d5c34988b5f83354cf1f927c2d89097e0989e/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/svg/text-repaint-including-stroke-expected.txt

Project Member

Comment 17 by bugdroid1@chromium.org, Oct 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42a7e4ef34b497c5d64694999adc105824fa2171

commit 42a7e4ef34b497c5d64694999adc105824fa2171
Author: Steve Kobes <skobes@chromium.org>
Date: Fri Oct 27 00:47:10 2017

Regenerate RLS flag expectations (297 outstanding failures).

The following process was used:

1. Patch http://crrev.com/c/740292/4 and branch.
2. try-flag trigger --flag=--root-layer-scrolls --regenerate
3. try-flag update --bug= 417782 
4. Copy output under "unexpected failures".

The flag try job is http://crrev.com/c/740361.

Bug:  711468 
Change-Id: If7d1564b07b3cfb9d69dc8d4c0832c676f6876e1
Reviewed-on: https://chromium-review.googlesource.com/740678
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512044}
[modify] https://crrev.com/42a7e4ef34b497c5d64694999adc105824fa2171/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls

Project Member

Comment 18 by bugdroid1@chromium.org, Oct 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d4c1f1929063c759aac19a456562de43f1f09e3

commit 1d4c1f1929063c759aac19a456562de43f1f09e3
Author: Stefan Zager <szager@chromium.org>
Date: Mon Oct 30 18:44:38 2017

[root layer scrolls] New test expectations

BUG= 711468 
R=pdr@chromium.org,skobes@chromium.org

Change-Id: I80afa54cb5315fe2a37f7198655476cdd9f58253
Reviewed-on: https://chromium-review.googlesource.com/742700
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512551}
[modify] https://crrev.com/1d4c1f1929063c759aac19a456562de43f1f09e3/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[add] https://crrev.com/1d4c1f1929063c759aac19a456562de43f1f09e3/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change-expected.txt
[add] https://crrev.com/1d4c1f1929063c759aac19a456562de43f1f09e3/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow-expected.txt
[add] https://crrev.com/1d4c1f1929063c759aac19a456562de43f1f09e3/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow-expected.txt
[add] https://crrev.com/1d4c1f1929063c759aac19a456562de43f1f09e3/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/css3/filters/composited-layer-child-bounds-after-composited-to-sw-shadow-change-expected.txt
[add] https://crrev.com/1d4c1f1929063c759aac19a456562de43f1f09e3/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/css3/filters/composited-layer-promotion-after-outset-overlap-change-using-composited-shadow-expected.txt
[add] https://crrev.com/1d4c1f1929063c759aac19a456562de43f1f09e3/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/css3/filters/composited-layer-promotion-after-outset-overlap-change-using-sw-shadow-expected.txt

Project Member

Comment 19 by bugdroid1@chromium.org, Oct 31 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7b9f2e671d8ebece538e2354314e7879003ec31

commit b7b9f2e671d8ebece538e2354314e7879003ec31
Author: Stefan Zager <szager@chromium.org>
Date: Tue Oct 31 01:48:18 2017

[root layer scrolls] New test expectations

First patch set has the old non-RLS expectations copied into
flag-specific/root-layer-scrolls, for comparison.

BUG= 711468 
R=pdr@chromium.org,skobes@chromium.org

Change-Id: Iaaaf6a31b37e80289c8265d53f18973b4eb8018c
Reviewed-on: https://chromium-review.googlesource.com/743710
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#512702}
[modify] https://crrev.com/b7b9f2e671d8ebece538e2354314e7879003ec31/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[add] https://crrev.com/b7b9f2e671d8ebece538e2354314e7879003ec31/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/fast/events/touch/compositor-touch-hit-rects-animation-expected.txt
[add] https://crrev.com/b7b9f2e671d8ebece538e2354314e7879003ec31/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/fast/events/touch/compositor-touch-hit-rects-expected.txt
[add] https://crrev.com/b7b9f2e671d8ebece538e2354314e7879003ec31/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/fast/events/touch/compositor-touch-hit-rects-global-expected.txt
[add] https://crrev.com/b7b9f2e671d8ebece538e2354314e7879003ec31/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/fast/events/touch/compositor-touch-hit-rects-non-composited-scroll-expected.txt
[add] https://crrev.com/b7b9f2e671d8ebece538e2354314e7879003ec31/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/fast/events/touch/compositor-touch-hit-rects-transform-changed-nolayout-expected.txt

Blockedon: 777506
Blockedon: 774716
Blockedon: 781419
Blockedon: 781428
Blockedon: 781431
Update: dependent bugs have been filed for all layout test directories with significant numbers of RLS failures.  (The bugs are also listed at http://bit.ly/rls-bugs.)

In addition, the following directories have less than five failures each:

1 in editing/input
1 in external/wpt/css/css-position
1 in external/wpt/paint-timing
1 in fast/body-propagation
3 in fast/css
5 in fast/dom
1 in fast/forms
1 in fast/frames
1 in fast/layers
1 in fast/layout
3 in fast/loader
2 in fast/overflow
4 in fast/spatial-navigation
2 in fast/sub-pixel
4 in fullscreen
1 in html/dialog
3 in http/tests/csspaint
1 in http/tests/misc
3 in inspector-protocol
1 in paint/overflow
2 in plugins
3 in svg
1 in transforms
Cc: -cbiesin...@chromium.org bokan@chromium.org pdr@chromium.org
Project Member

Comment 27 by bugdroid1@chromium.org, Nov 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b27a7e29a492e72ec00bada8cbb954501322006f

commit b27a7e29a492e72ec00bada8cbb954501322006f
Author: Steve Kobes <skobes@chromium.org>
Date: Tue Nov 14 03:53:28 2017

Skip virtual/spv175 with RLS.

These virtual test suites were added in http://crrev.com/516084.

Bug:  711468 
Change-Id: I1332aa20d89012e9ddc2a1a1627fb634c6a3af83
Reviewed-on: https://chromium-review.googlesource.com/767860
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516184}
[modify] https://crrev.com/b27a7e29a492e72ec00bada8cbb954501322006f/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls

Project Member

Comment 28 by bugdroid1@chromium.org, Nov 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e78503f82bff3ecb34edfbc1189154957577a956

commit e78503f82bff3ecb34edfbc1189154957577a956
Author: Stefan Zager <szager@chromium.org>
Date: Wed Nov 15 21:10:19 2017

[RootLayerScrolls] Fix printing with a frame scroll.

Before this fix, page contents were scrolled above the top of the
printed pages.  This doesn't affect the non-RLS printing code, which
already bypasses the scroll-offset-applying part of painting.

BUG= 711468 
R=pdr@chromium.org,skobes@chromium.org

Change-Id: I1b5bfe1ca0fee5c0454c5852cce9cb09c83394a8
Reviewed-on: https://chromium-review.googlesource.com/769856
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#516829}
[modify] https://crrev.com/e78503f82bff3ecb34edfbc1189154957577a956/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/e78503f82bff3ecb34edfbc1189154957577a956/third_party/WebKit/Source/core/page/PrintContext.cpp

Blockedon: 786117
Project Member

Comment 30 by bugdroid1@chromium.org, Nov 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70824559d883b7d1ad7ebd832ba7f5fb914d0377

commit 70824559d883b7d1ad7ebd832ba7f5fb914d0377
Author: Stefan Zager <szager@chromium.org>
Date: Fri Nov 17 11:34:56 2017

[RootLayerScrolls] Don't double-adjust scroll offset for page zoom

The page zoom factor will propagate down to the LayoutView's style,
and the scroll offset will be adjusted in LayoutBox::StyleDidChange.

I'm not sure why the affected test isn't in FlagExpectations...

BUG= 711468 
R=skobes@chromium.org,pdr@chromium.org
TEST=cssom/elementfrompoint-scrolloffset.html

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Change-Id: I87c8fc3334244b17b41fd7e185822b0f35a763bd
Reviewed-on: https://chromium-review.googlesource.com/775895
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517381}
[modify] https://crrev.com/70824559d883b7d1ad7ebd832ba7f5fb914d0377/third_party/WebKit/Source/core/frame/LocalFrame.cpp

Project Member

Comment 31 by bugdroid1@chromium.org, Nov 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/08b0819307cc7d1a973e7d938ff156527519c791

commit 08b0819307cc7d1a973e7d938ff156527519c791
Author: Stefan Zager <szager@chromium.org>
Date: Tue Nov 21 19:31:02 2017

[RootLayerScrolls] Fix ScrollRectToVisible for iframes

We only need to convert to root layer content coordinates if we're
calling into RootFrameViewport.

BUG= 711468 

Change-Id: Iff2632078950350d00b3c1cee8741a9190fc07d6
Reviewed-on: https://chromium-review.googlesource.com/780201
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#518332}
[modify] https://crrev.com/08b0819307cc7d1a973e7d938ff156527519c791/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/08b0819307cc7d1a973e7d938ff156527519c791/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp
[modify] https://crrev.com/08b0819307cc7d1a973e7d938ff156527519c791/third_party/WebKit/Source/core/layout/LayoutBox.cpp

Project Member

Comment 32 by bugdroid1@chromium.org, Nov 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6387be41d490018213a382843a1adc98d3c89256

commit 6387be41d490018213a382843a1adc98d3c89256
Author: Stefan Zager <szager@chromium.org>
Date: Tue Nov 28 01:36:00 2017

[RootLayerScrolls] New baselines for printing tests.

The text diffs are due to the new layer tree structure.  The image
diffs are only on Win10, and they appear to be shading differences
due to antialiasing.  Most likely, this is caused by floating point
numerical differences when the printing code applies a zoom factor
to the page.

BUG= 711468 
R=pdr@chromium.org,skobes@chromium.org
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls

Change-Id: I0d33a98a98bdf5203f26f97ab7787c162619af1c
Reviewed-on: https://chromium-review.googlesource.com/792332
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#519513}
[modify] https://crrev.com/6387be41d490018213a382843a1adc98d3c89256/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[add] https://crrev.com/6387be41d490018213a382843a1adc98d3c89256/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/printing/thead-repeats-at-top-of-each-page-expected.png
[add] https://crrev.com/6387be41d490018213a382843a1adc98d3c89256/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/printing/thead-repeats-at-top-of-each-page-expected.txt
[add] https://crrev.com/6387be41d490018213a382843a1adc98d3c89256/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/printing/thead-repeats-at-top-of-each-page-expected.png
[add] https://crrev.com/6387be41d490018213a382843a1adc98d3c89256/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/printing/thead-repeats-at-top-of-each-page-expected.txt
[add] https://crrev.com/6387be41d490018213a382843a1adc98d3c89256/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/printing/thead-repeats-at-top-of-each-page-expected.png
[add] https://crrev.com/6387be41d490018213a382843a1adc98d3c89256/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/printing/thead-repeats-at-top-of-each-page-expected.txt
[add] https://crrev.com/6387be41d490018213a382843a1adc98d3c89256/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/printing/quirks-percentage-height-body-expected.png
[add] https://crrev.com/6387be41d490018213a382843a1adc98d3c89256/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/printing/quirks-percentage-height-body-expected.txt
[add] https://crrev.com/6387be41d490018213a382843a1adc98d3c89256/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/printing/quirks-percentage-height-expected.png
[add] https://crrev.com/6387be41d490018213a382843a1adc98d3c89256/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/printing/quirks-percentage-height-expected.txt
[add] https://crrev.com/6387be41d490018213a382843a1adc98d3c89256/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/printing/standards-percentage-heights-expected.png
[add] https://crrev.com/6387be41d490018213a382843a1adc98d3c89256/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/printing/standards-percentage-heights-expected.txt
[add] https://crrev.com/6387be41d490018213a382843a1adc98d3c89256/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/printing/subframes-percentage-height-expected.png
[add] https://crrev.com/6387be41d490018213a382843a1adc98d3c89256/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/printing/subframes-percentage-height-expected.txt

Project Member

Comment 33 by bugdroid1@chromium.org, Nov 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa599d184e9af341b2ffd4e5a635836bc5418b16

commit aa599d184e9af341b2ffd4e5a635836bc5418b16
Author: Steve Kobes <skobes@chromium.org>
Date: Wed Nov 29 04:34:41 2017

Regenerate RLS flag expectations (126 outstanding failures).

The following process was used:

1. Patch in http://crrev.com/c/794896/1 and http://crrev.com/c/795350/1.
2. Create a local branch.
3. try-flag trigger --flag=--root-layer-scrolls --regenerate
4. try-flag update --flag=--root-layer-scrolls --bug= 417782 
5. Copy output under "unexpected failures".
6. Paste into flag expectations file, replacing all content above
   "# Tests known to be flaky".
7. Manually remove "Missing" expectation on one test (TODO: investigate).
8. Move all lines with multiple expectations (e.g. [ Crash Failure ]) to
   the known flakes section.

The flag try job is http://crrev.com/c/794897.

Bug:  711468 
Change-Id: I1907f02e1b3b7dcd8d1cddbc0738e465334cea6f
Reviewed-on: https://chromium-review.googlesource.com/795354
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520003}
[modify] https://crrev.com/aa599d184e9af341b2ffd4e5a635836bc5418b16/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls

Project Member

Comment 34 by bugdroid1@chromium.org, Dec 1 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/851414c6cdd6ea1e55588b8010e7b57227d6da4d

commit 851414c6cdd6ea1e55588b8010e7b57227d6da4d
Author: Stefan Zager <szager@chromium.org>
Date: Fri Dec 01 02:22:45 2017

[RootLayerScrolling] Fix position:sticky

If there are any non-composited position:sticky objects that stick
to the root layer, then we must force main thread scrolling to
prevent an "over-scrolling" effect.

BUG= 711468 
R=skobes@chromium.org,pdr@chromium.org,bokan@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Change-Id: I4c36eaf118b8d4d0078c4d5c5e8b633eb71fe733
Reviewed-on: https://chromium-review.googlesource.com/797221
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#520807}
[modify] https://crrev.com/851414c6cdd6ea1e55588b8010e7b57227d6da4d/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/851414c6cdd6ea1e55588b8010e7b57227d6da4d/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/851414c6cdd6ea1e55588b8010e7b57227d6da4d/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp
[modify] https://crrev.com/851414c6cdd6ea1e55588b8010e7b57227d6da4d/third_party/WebKit/Source/core/layout/LayoutBoxModelObject.h
[modify] https://crrev.com/851414c6cdd6ea1e55588b8010e7b57227d6da4d/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp
[modify] https://crrev.com/851414c6cdd6ea1e55588b8010e7b57227d6da4d/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.h

Project Member

Comment 35 by bugdroid1@chromium.org, Dec 5 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5577210e596c6e879e12a5d67aff967a0951f53c

commit 5577210e596c6e879e12a5d67aff967a0951f53c
Author: Stefan Zager <szager@chromium.org>
Date: Tue Dec 05 03:52:23 2017

[RootLayerScrolls] Update scroll dimensions before clamping

When an overflow:auto vertical scrollbar is removed from an RTL
LayoutView, then the call to ClampScrollOffsetAfterOverflowChange in
LayoutView::UpdateAfterLayout during the second layout pass (after
removing the scrollbar) will happen when the ScrollableArea's
overflow_rect_ needs updating.

BUG= 711468 
R=skobes@chromium.org,pdr@chromium.org,bokan@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I191a7142808851b266904b1916afc57b4b305940
Reviewed-on: https://chromium-review.googlesource.com/802179
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521607}
[modify] https://crrev.com/5577210e596c6e879e12a5d67aff967a0951f53c/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/5577210e596c6e879e12a5d67aff967a0951f53c/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/5577210e596c6e879e12a5d67aff967a0951f53c/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Comment 36 by pdr@chromium.org, Dec 5 2017

Blockedon: 792156
Project Member

Comment 37 by bugdroid1@chromium.org, Dec 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1c3de3712cc2d6704930681cc29a17ab89490445

commit 1c3de3712cc2d6704930681cc29a17ab89490445
Author: Stefan Zager <szager@chromium.org>
Date: Wed Dec 06 19:52:04 2017

[RootLayerScrolls] New test baselines

A few more layer tree dumps.

BUG= 711468 

Change-Id: I8648cd7070f43a0bddc0bde24f7a30cfe93b0433
Reviewed-on: https://chromium-review.googlesource.com/809847
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522175}
[modify] https://crrev.com/1c3de3712cc2d6704930681cc29a17ab89490445/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[add] https://crrev.com/1c3de3712cc2d6704930681cc29a17ab89490445/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/fast/dom/scroll-reveal-left-overflow-expected.txt
[add] https://crrev.com/1c3de3712cc2d6704930681cc29a17ab89490445/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/fast/dom/scroll-reveal-top-overflow-expected.txt
[add] https://crrev.com/1c3de3712cc2d6704930681cc29a17ab89490445/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/fast/forms/huge-mac-input-clamped-width-expected.txt
[add] https://crrev.com/1c3de3712cc2d6704930681cc29a17ab89490445/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/fast/layers/scroll-rect-to-visible-expected.txt
[add] https://crrev.com/1c3de3712cc2d6704930681cc29a17ab89490445/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/fast/dom/scroll-reveal-left-overflow-expected.txt
[add] https://crrev.com/1c3de3712cc2d6704930681cc29a17ab89490445/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/fast/dom/scroll-reveal-top-overflow-expected.txt
[add] https://crrev.com/1c3de3712cc2d6704930681cc29a17ab89490445/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/fast/forms/huge-mac-input-clamped-width-expected.txt
[add] https://crrev.com/1c3de3712cc2d6704930681cc29a17ab89490445/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/fast/layers/scroll-rect-to-visible-expected.txt
[add] https://crrev.com/1c3de3712cc2d6704930681cc29a17ab89490445/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/plugins/webview-plugin-nested-iframe-scroll-expected.txt
[add] https://crrev.com/1c3de3712cc2d6704930681cc29a17ab89490445/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/plugins/webview-plugin-scroll-expected.txt
[add] https://crrev.com/1c3de3712cc2d6704930681cc29a17ab89490445/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/fast/dom/scroll-reveal-left-overflow-expected.txt
[add] https://crrev.com/1c3de3712cc2d6704930681cc29a17ab89490445/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/fast/dom/scroll-reveal-top-overflow-expected.txt
[add] https://crrev.com/1c3de3712cc2d6704930681cc29a17ab89490445/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/fast/forms/huge-mac-input-clamped-width-expected.txt
[add] https://crrev.com/1c3de3712cc2d6704930681cc29a17ab89490445/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/fast/layers/scroll-rect-to-visible-expected.txt
[add] https://crrev.com/1c3de3712cc2d6704930681cc29a17ab89490445/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/plugins/webview-plugin-nested-iframe-scroll-expected.txt
[add] https://crrev.com/1c3de3712cc2d6704930681cc29a17ab89490445/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/plugins/webview-plugin-scroll-expected.txt

Project Member

Comment 38 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5165b8fb056bfcfa6c92c12ebd9e7ad75729868e

commit 5165b8fb056bfcfa6c92c12ebd9e7ad75729868e
Author: Stefan Zager <szager@chromium.org>
Date: Wed Dec 13 00:58:11 2017

[RootLayerScrolls] Fix spatial navigation

Add some calls to LayoutViewportScrollableArea and replace some
faulty custom geometry logic with calls into LocalFrameView.

BUG= 711468 
R=skobes@chromium.org,bokan@chromium.org

Change-Id: Id937278809ed59710a76722d6219b98f539d6e06
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Reviewed-on: https://chromium-review.googlesource.com/822159
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523634}
[modify] https://crrev.com/5165b8fb056bfcfa6c92c12ebd9e7ad75729868e/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[modify] https://crrev.com/5165b8fb056bfcfa6c92c12ebd9e7ad75729868e/third_party/WebKit/Source/core/page/SpatialNavigation.cpp

Project Member

Comment 39 by bugdroid1@chromium.org, Dec 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9631babbfaf4563f9b8385b13827476b175d76cb

commit 9631babbfaf4563f9b8385b13827476b175d76cb
Author: Stefan Zager <szager@chromium.org>
Date: Wed Dec 13 02:28:51 2017

Fix rounding of overflow rect location when setting scroll origin

This patch makes the rounding in UpdateScrollOrigin match the
implementation of MaximumScrollOffsetInt(), by snapping to the
box location minus border top/left (which is subtlely different
from the client top/left).

All of the test expectation changes are cases where a scrollable
area is scrolled all the way to the right, but the scrollX is
off by one.

Bug:  711468 
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ie017c21b12c611e7166de8e828054b875a268955
Reviewed-on: https://chromium-review.googlesource.com/811889
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523659}
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls
[add] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt
[add] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt
[add] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/platform/linux/fast/css/text-overflow-ellipsis-bidi-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/platform/mac-mac10.11/fast/forms/search/search-rtl-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/platform/mac/editing/selection/dont-select-text-overflow-ellipsis-when-wrapping-rtl-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-block-with-border-and-padding-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-text-align-center-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-text-align-left-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/platform/mac/fast/css/text-overflow-ellipsis-text-align-right-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/platform/mac/paint/markers/ellipsis-ltr-text-in-rtl-flow-with-markers-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/platform/mac/paint/markers/ellipsis-mixed-text-in-rtl-flow-with-markers-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/platform/win/fast/css/text-overflow-ellipsis-bidi-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/platform/win/fast/css/text-overflow-ellipsis-block-with-border-and-padding-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/platform/win/fast/css/text-overflow-ellipsis-text-align-center-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/platform/win/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/LayoutTests/platform/win/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt
[modify] https://crrev.com/9631babbfaf4563f9b8385b13827476b175d76cb/third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp

Project Member

Comment 40 by bugdroid1@chromium.org, Dec 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db7ca8c4009844b26cf03a20a1c93a15519d4ea3

commit db7ca8c4009844b26cf03a20a1c93a15519d4ea3
Author: Stefan Zager <szager@chromium.org>
Date: Thu Dec 14 00:20:40 2017

[RootLayerScrolls] Fix typo in flag-specific test expectation.

I modified this file manually in the previous patch, and made a
typo.

BUG= 711468 
R=skobes@chromium.org

Change-Id: I63cc6c285ea47a10dd41aec4de4049413311a0ed
Reviewed-on: https://chromium-review.googlesource.com/824946
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#523947}
[modify] https://crrev.com/db7ca8c4009844b26cf03a20a1c93a15519d4ea3/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/fast/dom/rtl-scroll-to-leftmost-and-resize-expected.txt

Project Member

Comment 41 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/691937a564ea406db89f66a324f4d8c4c806a621

commit 691937a564ea406db89f66a324f4d8c4c806a621
Author: Stefan Zager <szager@chromium.org>
Date: Thu Jan 25 00:38:34 2018

[RootLayerScrolls] Delete unnecessary flag-specific baseline.

This was mistakenly added during a bulk operation.  It has no diff
from the non-rls version.

BUG= 711468 
TBR=skobes@chromium.org,bokan@chromium.org
NOTRY=true

Change-Id: Ib3de59015f751869cd0f5efd74d9e4872bb08df3
Reviewed-on: https://chromium-review.googlesource.com/885061
Commit-Queue: Stefan Zager <szager@chromium.org>
Reviewed-by: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531762}
[delete] https://crrev.com/bc1eaa0208d1e1191de8a680810237f231c350b0/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/fecomponenttransfer-in1-change-expected.svg

Project Member

Comment 42 by bugdroid1@chromium.org, Jan 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8462eeb050d19b92dac107f1399e073a99f91ad1

commit 8462eeb050d19b92dac107f1399e073a99f91ad1
Author: Stefan Zager <szager@chromium.org>
Date: Sat Jan 27 05:41:27 2018

[RootLayerScrolls] Update some paint/invalidation test baselines.

These are tests whose non-rls expectations have changed since the
flag-specific/root-layer-scrolls expectations were created.  A lot
of them changed in https://chromium-review.googlesource.com/872256.

BUG= 711468 
R=skobes@chromium.org,chrishtr@chromium.org

Change-Id: Icbb2cd94b89af0c91b7e8b52525fc26955034927
Reviewed-on: https://chromium-review.googlesource.com/890038
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532165}
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/clip/clip-path-constant-repaint-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/compositing/column-span-under-composited-column-child-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/compositing/fixed-pos-inside-composited-intermediate-layer-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/compositing/fixed-scroll-in-empty-root-layer-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/filters/effect-reference-repaint-displacement-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/invalidate-descendants-when-receiving-paint-layer-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/reflection/scroll-absolute-layer-with-reflection-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/reflection/scroll-fixed-layer-with-reflection-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/scroll/fixed-img-src-change-after-scroll-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/scroll/fixed-scroll-simple-expected.txt
[add] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/scroll/iframe-scroll-repaint-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/scroll/overflow-auto-in-overflow-auto-scrolled-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/scroll/overflow-hidden-in-overflow-hidden-scrolled-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/scroll/overflow-hidden-yet-scrolled-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/scroll/overflow-hidden-yet-scrolled-with-custom-scrollbar-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/scroll/overflow-scroll-composited-non-stacking-child-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/scroll/overflow-scroll-in-overflow-scroll-scrolled-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/scroll/scroll-fixed-layer-with-no-visible-content-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/scroll/scroll-fixed-layer-with-transformed-parent-layer-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/scroll/scroll-in-clipped-layer-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/scroll/scroll-in-fixed-layer-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/scroll/scroll-with-transformed-parent-layer-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/js-late-marker-and-object-creation-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/js-late-marker-creation-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/js-late-mask-and-object-creation-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/svg/js-late-mask-creation-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/table/scroll-inside-table-cell-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/table/scroll-relative-table-inside-table-cell-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/table/table-overflow-auto-in-overflow-auto-scrolled-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/paint/invalidation/table/table-overflow-scroll-in-overflow-scroll-scrolled-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/invalidation/compositing/fixed-pos-with-abs-pos-child-scroll-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/invalidation/table/single-line-cells-repeating-thead-break-inside-on-thead-only-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/linux/paint/overflow/fixed-background-scroll-window-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/compositing/fixed-pos-with-abs-pos-child-scroll-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/position/fixed-element-repaint-after-compositing-update-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/scroll/scroll-stacking-context-backface-visiblity-leaves-traces-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/svg/js-late-clipPath-and-object-creation-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/svg/js-late-clipPath-creation-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/svg/js-late-gradient-creation-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/svg/js-late-pattern-creation-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/invalidation/table/single-line-cells-repeating-thead-break-inside-on-thead-only-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/mac/paint/overflow/fixed-background-scroll-window-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/compositing/fixed-pos-with-abs-pos-child-scroll-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/position/fixed-element-repaint-after-compositing-update-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/scroll/scroll-stacking-context-backface-visiblity-leaves-traces-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/svg/js-late-clipPath-and-object-creation-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/svg/js-late-clipPath-creation-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/svg/js-late-gradient-creation-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/svg/js-late-pattern-creation-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/invalidation/table/single-line-cells-repeating-thead-break-inside-on-thead-only-expected.txt
[modify] https://crrev.com/8462eeb050d19b92dac107f1399e073a99f91ad1/third_party/WebKit/LayoutTests/flag-specific/root-layer-scrolls/platform/win/paint/overflow/fixed-background-scroll-window-expected.txt

Project Member

Comment 43 by bugdroid1@chromium.org, Jan 29 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da763f1ccda12815f5bc24f66e6e32265f33e12a

commit da763f1ccda12815f5bc24f66e6e32265f33e12a
Author: Steve Kobes <skobes@chromium.org>
Date: Mon Jan 29 22:44:04 2018

Regenerate RLS flag expectations (64 outstanding failures).

The updated expectations were generated with the try-flag tool,
documented at http://bit.ly/flag-try-jobs.  The flag try job's test
results are at http://crrev.com/c/794897.

The spv175 tests are no longer skipped, as they seem to be passing.

Bug:  711468 
Change-Id: Ie9e8addc75dbcc428d234039afb02956e731383b
Reviewed-on: https://chromium-review.googlesource.com/891645
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532638}
[modify] https://crrev.com/da763f1ccda12815f5bc24f66e6e32265f33e12a/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls

Blockedon: 807162
Project Member

Comment 45 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc20b42a2b21840b9aa18bd8bb022e1be44266c2

commit cc20b42a2b21840b9aa18bd8bb022e1be44266c2
Author: Steve Kobes <skobes@chromium.org>
Date: Tue Jan 30 19:17:25 2018

Mark two more layout tests failing with RLS.

These weren't caught in http://crrev.com/532638, but they are failing on
win7_chromium_rel_ng:

https://ci.chromium.org/buildbot/tryserver.chromium.win/win7_chromium_rel_ng/91452

Bug:  711468 
Change-Id: Iae4b8a5e5a56e96bc835556fe6cc5fcdf11dedac
Reviewed-on: https://chromium-review.googlesource.com/893214
Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Steve Kobes <skobes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532982}
[modify] https://crrev.com/cc20b42a2b21840b9aa18bd8bb022e1be44266c2/third_party/WebKit/LayoutTests/FlagExpectations/root-layer-scrolls

Project Member

Comment 46 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/46b32c16768bf706e6d64072d10ebaab8c7d9913

commit 46b32c16768bf706e6d64072d10ebaab8c7d9913
Author: Stefan Zager <szager@chromium.org>
Date: Tue Feb 06 03:51:03 2018

Fix parent contribution to iframe content layer position.

Prior to this patch, the clipping box offset erroneously appeared in
both the child containment layer position and the main graphics layer
position.

BUG= 711468 
R=skobes@chromium.org,chrishtr@chromium.org

Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I7931b0b7ea94fce121232d2ab52a55375994224d
Reviewed-on: https://chromium-review.googlesource.com/903263
Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534616}
[modify] https://crrev.com/46b32c16768bf706e6d64072d10ebaab8c7d9913/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/46b32c16768bf706e6d64072d10ebaab8c7d9913/third_party/WebKit/Source/core/paint/compositing/CompositedLayerMapping.cpp

Cc: skobes@chromium.org
 Issue 808112  has been merged into this issue.
Cc: cbiesin...@chromium.org sriram...@samsung.com satay...@samsung.com
 Issue 711474  has been merged into this issue.
Blockedon: 773373
Project Member

Comment 50 by bugdroid1@chromium.org, Feb 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/86db023e68033cb039e3a91dc3015844369763a4

commit 86db023e68033cb039e3a91dc3015844369763a4
Author: Steve Kobes <skobes@chromium.org>
Date: Fri Feb 16 05:38:13 2018

Organize RLS test expectations.

Bug:  711468 
Change-Id: I036ac47727885a4ea57367e384e9fc388b5a7bf5
Reviewed-on: https://chromium-review.googlesource.com/917422
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537218}
[modify] https://crrev.com/86db023e68033cb039e3a91dc3015844369763a4/third_party/WebKit/LayoutTests/TestExpectations

Project Member

Comment 51 by bugdroid1@chromium.org, Mar 1 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/48ec74d7989862a82990827d4898d016d2942615

commit 48ec74d7989862a82990827d4898d016d2942615
Author: David Bokan <bokan@chromium.org>
Date: Thu Mar 01 18:36:14 2018

[root-layer-scrolls] Fix android fullscreen video

Android uses an "overlay" composited video layer when a video is
fullscreened. This layer is parented to the PaintLayerCompositor's
root_content_layer and the actual content (LayoutView) is detached.

With root-layer-scrolling enabled, PLC doesn't create a
root_content_layer and the top-most GraphicsLayer in PLC is that of the
LayoutView. This CL connects the video layer to the PLC's parent
instead. This is currently the outer viewport scroll layer. We also need
to make sure painting starts from the child of this layer, rather than
the PLC's root layer since the video layer is no longer connected to the
root. This doesn't matter for the video itself, however, the media
player controls need to be painted from Blink.

These changes exposed some brittleness in the compositor and the Android
fullscreen video layout tests were hitting the DCHECK in
ScrollbarLayerImplBase::CanScrollOrientation. This is because the
viewport scrollbars use the outer/layout viewport as their ElementId but
are owned by the inner/visual viewport. So when we disconnect the PLC's
content layers, we remove the ScrollNode in the compositor but the
visual viewport and its scrollbar layers live on. The rest of this patch
changes the visual viewport scrollbars to use the visual viewport's
element id.

TEST=virtual/android/fullscreen/video-scrolled-iframe.html,
     virtual/android/fullscreen/video-controls-timeline.html,
     virtual/android/fullscreen/full-screen-iframe-allowed-video.html

Bug:  711468 , 811024 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ic1c52e1853f14842ee3ae19119476b8945ecae17
Reviewed-on: https://chromium-review.googlesource.com/923397
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540226}
[modify] https://crrev.com/48ec74d7989862a82990827d4898d016d2942615/cc/input/scrollbar_animation_controller.cc
[modify] https://crrev.com/48ec74d7989862a82990827d4898d016d2942615/cc/trees/layer_tree_host_impl.cc
[modify] https://crrev.com/48ec74d7989862a82990827d4898d016d2942615/cc/trees/layer_tree_impl.cc
[modify] https://crrev.com/48ec74d7989862a82990827d4898d016d2942615/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/48ec74d7989862a82990827d4898d016d2942615/third_party/WebKit/Source/core/exported/WebViewImpl.cpp
[modify] https://crrev.com/48ec74d7989862a82990827d4898d016d2942615/third_party/WebKit/Source/core/frame/LocalFrameView.cpp
[modify] https://crrev.com/48ec74d7989862a82990827d4898d016d2942615/third_party/WebKit/Source/core/frame/VisualViewport.cpp
[modify] https://crrev.com/48ec74d7989862a82990827d4898d016d2942615/third_party/WebKit/Source/core/frame/VisualViewport.h
[modify] https://crrev.com/48ec74d7989862a82990827d4898d016d2942615/third_party/WebKit/Source/core/paint/compositing/PaintLayerCompositor.cpp
[modify] https://crrev.com/48ec74d7989862a82990827d4898d016d2942615/third_party/WebKit/Source/core/paint/compositing/PaintLayerCompositor.h

Project Member

Comment 52 by bugdroid1@chromium.org, Mar 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d707c20476717b074f94584f90ddbefa05ad0d02

commit d707c20476717b074f94584f90ddbefa05ad0d02
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Thu Mar 08 00:20:03 2018

Remove site-per-process expectations already covered by TestExpectations.

This CL tries to remove test expectations from
LayoutTests/FlagExpectations/site-per-process
if they are already covered by expectations in
LayoutTests/TestExpectations

Bug: 477150,  711468 ,  788390 
Change-Id: I89b0838d7fc3dbdbb536d542baf2d3e5e31b6faf
Reviewed-on: https://chromium-review.googlesource.com/953222
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541649}
[modify] https://crrev.com/d707c20476717b074f94584f90ddbefa05ad0d02/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Status: Fixed (was: Assigned)
Project Member

Comment 54 by bugdroid1@chromium.org, Aug 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9d2b24b2ba5e3dd767a1f2e9141520ae7f07c359

commit 9d2b24b2ba5e3dd767a1f2e9141520ae7f07c359
Author: Stefan Zager <szager@chromium.org>
Date: Tue Aug 14 19:52:54 2018

Don't compute viewport intersection if parent frame is throttled

If a RemoteFrameView is inside a throttled LocalFrameView with out-of-
date layout, then it's not possible to compute its viewport
intersection. In that case, just propagate an empty intersection (which
is probably correct, because a throttled frame is presumably off
screen).

BUG= 711468 
R=kenrb@chromium.org

Change-Id: Ie400c407871aab74561b4e34eefece17aa8c3e27
Reviewed-on: https://chromium-review.googlesource.com/1173345
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583002}
[modify] https://crrev.com/9d2b24b2ba5e3dd767a1f2e9141520ae7f07c359/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process
[modify] https://crrev.com/9d2b24b2ba5e3dd767a1f2e9141520ae7f07c359/third_party/blink/renderer/core/frame/remote_frame_view.cc

Project Member

Comment 55 by bugdroid1@chromium.org, Aug 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b7663e81247c1494770dd8de1603b648a4aaeeeb

commit b7663e81247c1494770dd8de1603b648a4aaeeeb
Author: Lukasz Anforowicz <lukasza@chromium.org>
Date: Tue Aug 21 18:23:30 2018

|RenderFrameHost*| shouldn't be used as a key by BlinkTestController.

Addresses can be reused and therefore pointers shouldn't be used as
container keys (unless the code maintaining the container can guarantee
that the old entry will be destroyed before the pointer gets freed).
In particular, using |RenderFrameHost*| as a key of BlinkTestController's
layout_test_control_map_ was incorrect and led to timeouts described
in more details in  https://crbug.com/834185#c13  - #c14.

This CL replaces
    std::map<RenderFrameHost*, ...>
with
    std::map<std::pair<int, int>, ...>
and uses (process id, frame routing id) as a key.

After this CL around ~200 flaky timeouts from
FlagExpectations/site-per-process seem to avoided.  Before this CL, I
could reliably repro a timeout in
- http/tests/fetch/window/thorough/redirect-nocors-base-https-other-https.html
- http/tests/fetch/serviceworker-proxied/thorough/scheme-data-base-https-other-https.html
when running it 20 iterations.  After this CL, I cannot repro any
timeouts when running all ~200 tests 20 times:

    $ DISPLAY=:20 third_party/WebKit/Tools/Scripts/run-webkit-tests \
        -t rel --no-retry --additional-driver-flag=--site-per-process \
        --iterations=20 \
        --exit-after-n-failures=1 --exit-after-n-crashes-or-timeouts=1 \
        --additional-driver-flag=--no-sandbox \
        --additional-driver-flag=--isolate-origins=http://www.web-platform.test:8001/,http://www1.web-platform.test:8001/,http://www2.web-platform.test:8001/,http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8001/,http://xn--lve-6lad.web-platform.test:8001/,http://www.web-platform.test:8081/,http://www1.web-platform.test:8081/,http://www2.web-platform.test:8081/,http://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8081/,http://xn--lve-6lad.web-platform.test:8081/,https://www.web-platform.test:8444/,https://www1.web-platform.test:8444/,https://www2.web-platform.test:8444/,https://xn--n8j6ds53lwwkrqhv28a.web-platform.test:8444/,https://xn--lve-6lad.web-platform.test:8444/ \
        --test-list=$HOME/scratch/test-list
    ...
    Found 206 tests; running 206 (20 times each: --repeat-each=1 --iterations=20), skipping 0.
    ...
    All 4120 tests ran as expected.

Bug:  801992 ,  834185 ,  711468 , 859988
Change-Id: I9f2c1abf87027fcb3824c54e597e561ac72babb9
Reviewed-on: https://chromium-review.googlesource.com/1182316
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584841}
[modify] https://crrev.com/b7663e81247c1494770dd8de1603b648a4aaeeeb/content/shell/browser/layout_test/blink_test_controller.cc
[modify] https://crrev.com/b7663e81247c1494770dd8de1603b648a4aaeeeb/content/shell/browser/layout_test/blink_test_controller.h
[modify] https://crrev.com/b7663e81247c1494770dd8de1603b648a4aaeeeb/third_party/WebKit/LayoutTests/FlagExpectations/site-per-process

Sign in to add a comment