New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711461 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Aug 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature


Sign in to add a comment

binutils: upgrade to 2.27

Project Member Reported by rahulchaudhry@chromium.org, Apr 13 2017

Issue description

This is the tracking bug for binutils upgrade to 2.27 for Chrome OS and Android.

The source tree is being prepared under binutils-2_27-branch in the aosp/binutils repo: https://android.googlesource.com/toolchain/binutils/+log/binutils-2_27-branch

Alternate view: https://android-review.googlesource.com/#/q/status:merged+project:toolchain/binutils+branch:binutils-2_27-branch

Ongoing: building and testing Chrome OS and Android with binutils 2.27.

 
Blockedon: 711767
Blockedon: 712784
Blockedon: 715331
Blockedon: 715779
Blockedon: 715780
Blockedon: -711767
Blockedon: 715788
Blockedon: 715795
Blockedon: -715788
Blockedon: 722616
Blockedon: 723906
Blockedon: 724671
Blockedon: 732961
Project Member

Comment 14 by bugdroid1@chromium.org, Jun 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9f711d87bce8a2bcc23015c90aa43828c9253bf9

commit 9f711d87bce8a2bcc23015c90aa43828c9253bf9
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Fri Jun 23 00:03:59 2017

sys-devel/binutils: upgrade to binutils-2_27.

The source tree was prepared at https://android-review.googlesource.com/#/q/status:merged+project:toolchain/binutils+branch:binutils-2_27-branch

For more details, including testing, see http://go/chromeos-toolchain-team/binutils-2_27

BUG= chromium:711461 
TEST='cbuildbot --remote -g 486144 --latest-toolchain chromiumos-sdk' was successful.
TEST='cbuildbot --remote -g 486144 --latest-toolchain panther-release' was successful.
TEST='cbuildbot --remote -g 486144 --latest-toolchain daisy-release' was successful (except TestSimpleChromeWorkflow:  http://crbug.com/724671 ).
TEST='cbuildbot --remote -g 486144 --latest-toolchain elm-release' was successful.
TEST='Built a panther image with binutils-2_27 and flashed a device successfully.'
TEST='Built a daisy image with binutils-2_27 and flashed a device successfully.'
TEST='Built a elm image with binutils-2_27 and flashed a device successfully.'

Change-Id: I254e53c0cc3c3145d69dccb94c37982138a04b91
Reviewed-on: https://chromium-review.googlesource.com/486144
Commit-Ready: Rahul Chaudhry <rahulchaudhry@chromium.org>
Tested-by: Rahul Chaudhry <rahulchaudhry@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[rename] https://crrev.com/9f711d87bce8a2bcc23015c90aa43828c9253bf9/sys-devel/binutils/binutils-2.27.ebuild
[modify] https://crrev.com/9f711d87bce8a2bcc23015c90aa43828c9253bf9/sys-devel/binutils/binutils-9999.ebuild

Project Member

Comment 15 by bugdroid1@chromium.org, Jun 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/d384dfadd5326f5804f90f88e80afe05b250150e

commit d384dfadd5326f5804f90f88e80afe05b250150e
Author: Manoj Gupta <manojgupta@chromium.org>
Date: Tue Jun 27 00:05:29 2017

Revert "sys-devel/binutils: upgrade to binutils-2_27."

This reverts commit 9f711d87bce8a2bcc23015c90aa43828c9253bf9.

Reason for revert: Broke lakitu. Other breakages also reported.

BUG=chromium:736534
Original change's description:
> sys-devel/binutils: upgrade to binutils-2_27.
>
> The source tree was prepared at https://android-review.googlesource.com/#/q/status:merged+project:toolchain/binutils+branch:binutils-2_27-branch
>
> For more details, including testing, see http://go/chromeos-toolchain-team/binutils-2_27
>
> BUG= chromium:711461 
> TEST='cbuildbot --remote -g 486144 --latest-toolchain chromiumos-sdk' was successful.
> TEST='cbuildbot --remote -g 486144 --latest-toolchain panther-release' was successful.
> TEST='cbuildbot --remote -g 486144 --latest-toolchain daisy-release' was successful (except TestSimpleChromeWorkflow:  http://crbug.com/724671 ).
> TEST='cbuildbot --remote -g 486144 --latest-toolchain elm-release' was successful.
> TEST='Built a panther image with binutils-2_27 and flashed a device successfully.'
> TEST='Built a daisy image with binutils-2_27 and flashed a device successfully.'
> TEST='Built a elm image with binutils-2_27 and flashed a device successfully.'
>
> Change-Id: I254e53c0cc3c3145d69dccb94c37982138a04b91
> Reviewed-on: https://chromium-review.googlesource.com/486144
> Commit-Ready: Rahul Chaudhry <rahulchaudhry@chromium.org>
> Tested-by: Rahul Chaudhry <rahulchaudhry@chromium.org>
> Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

Bug:  chromium:711461 
Change-Id: Ib215872e547ff6f27ce26585ae73ec077d8246a2
Reviewed-on: https://chromium-review.googlesource.com/547575
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Commit-Queue: Luis Lozano <llozano@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Luis Lozano <llozano@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Luis Lozano <llozano@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[rename] https://crrev.com/d384dfadd5326f5804f90f88e80afe05b250150e/sys-devel/binutils/binutils-2.25.51-r67.ebuild
[modify] https://crrev.com/d384dfadd5326f5804f90f88e80afe05b250150e/sys-devel/binutils/binutils-9999.ebuild

Project Member

Comment 16 by bugdroid1@chromium.org, Jun 30 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/a2a29e45f4a6185c5396bb634fc2480d16c60947

commit a2a29e45f4a6185c5396bb634fc2480d16c60947
Author: Manoj Gupta <manojgupta@google.com>
Date: Fri Jun 30 01:49:20 2017

Disable copy reloc with pie in gcc.

This feature was getting enabled with binutils 2.27.
However, it broke libbrillo unitests.

This is because of the upstream gcc bug for which the patches were not
backported to 4.9.x branches.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65248
This can be removed once patches for the bug are backported to CroS
GCC 4.9.2 branch.

BUG= chromium:711461 
TEST=libbrillo tests pass (using gcc as the compiler).

Change-Id: Ia1f2c902252b8bd7a50d409ef6f9ae0c7c772c78
Reviewed-on: https://chromium-review.googlesource.com/552871
Commit-Queue: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[add] https://crrev.com/a2a29e45f4a6185c5396bb634fc2480d16c60947/sys-devel/gcc/files/gcc-disable-linker-pie-copyreloc.patch
[rename] https://crrev.com/a2a29e45f4a6185c5396bb634fc2480d16c60947/sys-devel/gcc/gcc-4.9.2-r157.ebuild

Blocking: 738283
Blockedon: 738188
Manoj, I think you mean that this is issue is blocked on 738283 and 738188. Not the other way around.
Blocking: -738283
Blockedon: 738283
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 8 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/9a87b73b1b7517d1dfcca6c3d9ccc8ef46de67f2

commit 9a87b73b1b7517d1dfcca6c3d9ccc8ef46de67f2
Author: Manoj Gupta <manojgupta@google.com>
Date: Sat Jul 08 04:30:06 2017

Disable copy reloc with pie in gcc.

This feature was getting enabled with binutils 2.27.
However, it broke libbrillo unitests.

This is because of the upstream gcc bug for which the patches were not
backported to 4.9.x branches.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=65248
This can be removed once patches for the bug are backported to CroS
GCC 4.9.2 branch.

(Forgot to update 9999 ebuild in CL:552871.)

BUG= chromium:711461 
BUG= chromium:738188 
TEST=libbrillo tests pass (using gcc as the compiler).

Change-Id: I0b138f0b02316f1359972b513394408e00a8eba7
Reviewed-on: https://chromium-review.googlesource.com/563822
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/9a87b73b1b7517d1dfcca6c3d9ccc8ef46de67f2/sys-devel/gcc/gcc-9999.ebuild

Project Member

Comment 23 by bugdroid1@chromium.org, Jul 13 2017

Labels: merge-merged-chromeos-3.14
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/781bec55d5355d81d1d0792fec9a5b106d57115b

commit 781bec55d5355d81d1d0792fec9a5b106d57115b
Author: Andy Lutomirski <luto@kernel.org>
Date: Thu Jul 13 00:55:51 2017

BACKPORT: x86/asm/irq: Stop relying on magic JMP behavior for early_idt_handlers

commit 425be5679fd292a3c36cb1fe423086708a99f11a upstream.

The early_idt_handlers asm code generates an array of entry
points spaced nine bytes apart.  It's not really clear from that
code or from the places that reference it what's going on, and
the code only works in the first place because GAS never
generates two-byte JMP instructions when jumping to global
labels.

Clean up the code to generate the correct array stride (member size)
explicitly. This should be considerably more robust against
screw-ups, as GAS will warn if a .fill directive has a negative
count.  Using '. =' to advance would have been even more robust
(it would generate an actual error if it tried to move
backwards), but it would pad with nulls, confusing anyone who
tries to disassemble the code.  The new scheme should be much
clearer to future readers.

While we're at it, improve the comments and rename the array and
common code.

Binutils may start relaxing jumps to non-weak labels.  If so,
this change will fix our build, and we may need to backport this
change.

Before, on x86_64:

  0000000000000000 <early_idt_handlers>:
     0:   6a 00                   pushq  $0x0
     2:   6a 00                   pushq  $0x0
     4:   e9 00 00 00 00          jmpq   9 <early_idt_handlers+0x9>
                          5: R_X86_64_PC32        early_idt_handler-0x4
  ...
    48:   66 90                   xchg   %ax,%ax
    4a:   6a 08                   pushq  $0x8
    4c:   e9 00 00 00 00          jmpq   51 <early_idt_handlers+0x51>
                          4d: R_X86_64_PC32       early_idt_handler-0x4
  ...
   117:   6a 00                   pushq  $0x0
   119:   6a 1f                   pushq  $0x1f
   11b:   e9 00 00 00 00          jmpq   120 <early_idt_handler>
                          11c: R_X86_64_PC32      early_idt_handler-0x4

After:

  0000000000000000 <early_idt_handler_array>:
     0:   6a 00                   pushq  $0x0
     2:   6a 00                   pushq  $0x0
     4:   e9 14 01 00 00          jmpq   11d <early_idt_handler_common>
  ...
    48:   6a 08                   pushq  $0x8
    4a:   e9 d1 00 00 00          jmpq   120 <early_idt_handler_common>
    4f:   cc                      int3
    50:   cc                      int3
  ...
   117:   6a 00                   pushq  $0x0
   119:   6a 1f                   pushq  $0x1f
   11b:   eb 03                   jmp    120 <early_idt_handler_common>
   11d:   cc                      int3
   11e:   cc                      int3
   11f:   cc                      int3

BUG= chromium:738283 
BUG= chromium:711461 
TEST=caroline boots with new binutils deployed.
TEST=No issues seen in toolchain team rotating builders.

dianders NOTE: Picked from v3.14 linuxstable instead of mainline Linux
to avoid conflicts.

Change-Id: I6a4c70aad54fe92564db055f4df28d0ccb21a66d
Signed-off-by: Andy Lutomirski <luto@kernel.org>
Acked-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: Binutils <binutils@sourceware.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: H.J. Lu <hjl.tools@gmail.com>
Cc: Jan Beulich <JBeulich@suse.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/ac027962af343b0c599cbfcf50b945ad2ef3d7a8.1432336324.git.luto@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
(cherry picked from commit 510458cb7da6205526445fcba0ea6fae7641698c)
Reviewed-on: https://chromium-review.googlesource.com/565355
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>

[modify] https://crrev.com/781bec55d5355d81d1d0792fec9a5b106d57115b/arch/x86/kernel/head_32.S
[modify] https://crrev.com/781bec55d5355d81d1d0792fec9a5b106d57115b/arch/x86/include/asm/segment.h
[modify] https://crrev.com/781bec55d5355d81d1d0792fec9a5b106d57115b/arch/x86/kernel/head64.c
[modify] https://crrev.com/781bec55d5355d81d1d0792fec9a5b106d57115b/arch/x86/kernel/head_64.S

Project Member

Comment 24 by bugdroid1@chromium.org, Jul 13 2017

Labels: merge-merged-chromeos-3.10
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/e838c0f9413bef9a550b70eead41c4e5f76fbfa3

commit e838c0f9413bef9a550b70eead41c4e5f76fbfa3
Author: Andy Lutomirski <luto@kernel.org>
Date: Thu Jul 13 00:55:53 2017

BACKPORT: x86/asm/irq: Stop relying on magic JMP behavior for early_idt_handlers

commit 425be5679fd292a3c36cb1fe423086708a99f11a upstream.

The early_idt_handlers asm code generates an array of entry
points spaced nine bytes apart.  It's not really clear from that
code or from the places that reference it what's going on, and
the code only works in the first place because GAS never
generates two-byte JMP instructions when jumping to global
labels.

Clean up the code to generate the correct array stride (member size)
explicitly. This should be considerably more robust against
screw-ups, as GAS will warn if a .fill directive has a negative
count.  Using '. =' to advance would have been even more robust
(it would generate an actual error if it tried to move
backwards), but it would pad with nulls, confusing anyone who
tries to disassemble the code.  The new scheme should be much
clearer to future readers.

While we're at it, improve the comments and rename the array and
common code.

Binutils may start relaxing jumps to non-weak labels.  If so,
this change will fix our build, and we may need to backport this
change.

Before, on x86_64:

  0000000000000000 <early_idt_handlers>:
     0:   6a 00                   pushq  $0x0
     2:   6a 00                   pushq  $0x0
     4:   e9 00 00 00 00          jmpq   9 <early_idt_handlers+0x9>
                          5: R_X86_64_PC32        early_idt_handler-0x4
  ...
    48:   66 90                   xchg   %ax,%ax
    4a:   6a 08                   pushq  $0x8
    4c:   e9 00 00 00 00          jmpq   51 <early_idt_handlers+0x51>
                          4d: R_X86_64_PC32       early_idt_handler-0x4
  ...
   117:   6a 00                   pushq  $0x0
   119:   6a 1f                   pushq  $0x1f
   11b:   e9 00 00 00 00          jmpq   120 <early_idt_handler>
                          11c: R_X86_64_PC32      early_idt_handler-0x4

After:

  0000000000000000 <early_idt_handler_array>:
     0:   6a 00                   pushq  $0x0
     2:   6a 00                   pushq  $0x0
     4:   e9 14 01 00 00          jmpq   11d <early_idt_handler_common>
  ...
    48:   6a 08                   pushq  $0x8
    4a:   e9 d1 00 00 00          jmpq   120 <early_idt_handler_common>
    4f:   cc                      int3
    50:   cc                      int3
  ...
   117:   6a 00                   pushq  $0x0
   119:   6a 1f                   pushq  $0x1f
   11b:   eb 03                   jmp    120 <early_idt_handler_common>
   11d:   cc                      int3
   11e:   cc                      int3
   11f:   cc                      int3

BUG= chromium:738283 
BUG= chromium:711461 
TEST=caroline boots with new binutils deployed.
TEST=No issues seen in toolchain team rotating builders.

dianders NOTE: Picked from v3.10 linuxstable instead of mainline Linux
to avoid conflicts.

Change-Id: I6a4c70aad54fe92564db055f4df28d0ccb21a66d
Signed-off-by: Andy Lutomirski <luto@kernel.org>
Acked-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: Binutils <binutils@sourceware.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: H.J. Lu <hjl.tools@gmail.com>
Cc: Jan Beulich <JBeulich@suse.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/ac027962af343b0c599cbfcf50b945ad2ef3d7a8.1432336324.git.luto@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
(cherry picked from commit 4800af91229e06e9d8517a6961f5b5d304b7e9bf)
Reviewed-on: https://chromium-review.googlesource.com/565908
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>

[modify] https://crrev.com/e838c0f9413bef9a550b70eead41c4e5f76fbfa3/arch/x86/kernel/head_32.S
[modify] https://crrev.com/e838c0f9413bef9a550b70eead41c4e5f76fbfa3/arch/x86/include/asm/segment.h
[modify] https://crrev.com/e838c0f9413bef9a550b70eead41c4e5f76fbfa3/arch/x86/kernel/head64.c
[modify] https://crrev.com/e838c0f9413bef9a550b70eead41c4e5f76fbfa3/arch/x86/kernel/head_64.S

Project Member

Comment 25 by bugdroid1@chromium.org, Jul 14 2017

Labels: merge-merged-chromeos-3.18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/kernel/+/92d776e4ce619c2b3a5100d4aaeb7d028f0a9046

commit 92d776e4ce619c2b3a5100d4aaeb7d028f0a9046
Author: Andy Lutomirski <luto@kernel.org>
Date: Fri Jul 14 02:46:05 2017

BACKPORT: x86/asm/irq: Stop relying on magic JMP behavior for early_idt_handlers

[ Upstream commit 425be5679fd292a3c36cb1fe423086708a99f11a ]

The early_idt_handlers asm code generates an array of entry
points spaced nine bytes apart.  It's not really clear from that
code or from the places that reference it what's going on, and
the code only works in the first place because GAS never
generates two-byte JMP instructions when jumping to global
labels.

Clean up the code to generate the correct array stride (member size)
explicitly. This should be considerably more robust against
screw-ups, as GAS will warn if a .fill directive has a negative
count.  Using '. =' to advance would have been even more robust
(it would generate an actual error if it tried to move
backwards), but it would pad with nulls, confusing anyone who
tries to disassemble the code.  The new scheme should be much
clearer to future readers.

While we're at it, improve the comments and rename the array and
common code.

Binutils may start relaxing jumps to non-weak labels.  If so,
this change will fix our build, and we may need to backport this
change.

Before, on x86_64:

  0000000000000000 <early_idt_handlers>:
     0:   6a 00                   pushq  $0x0
     2:   6a 00                   pushq  $0x0
     4:   e9 00 00 00 00          jmpq   9 <early_idt_handlers+0x9>
                          5: R_X86_64_PC32        early_idt_handler-0x4
  ...
    48:   66 90                   xchg   %ax,%ax
    4a:   6a 08                   pushq  $0x8
    4c:   e9 00 00 00 00          jmpq   51 <early_idt_handlers+0x51>
                          4d: R_X86_64_PC32       early_idt_handler-0x4
  ...
   117:   6a 00                   pushq  $0x0
   119:   6a 1f                   pushq  $0x1f
   11b:   e9 00 00 00 00          jmpq   120 <early_idt_handler>
                          11c: R_X86_64_PC32      early_idt_handler-0x4

After:

  0000000000000000 <early_idt_handler_array>:
     0:   6a 00                   pushq  $0x0
     2:   6a 00                   pushq  $0x0
     4:   e9 14 01 00 00          jmpq   11d <early_idt_handler_common>
  ...
    48:   6a 08                   pushq  $0x8
    4a:   e9 d1 00 00 00          jmpq   120 <early_idt_handler_common>
    4f:   cc                      int3
    50:   cc                      int3
  ...
   117:   6a 00                   pushq  $0x0
   119:   6a 1f                   pushq  $0x1f
   11b:   eb 03                   jmp    120 <early_idt_handler_common>
   11d:   cc                      int3
   11e:   cc                      int3
   11f:   cc                      int3

BUG= chromium:738283 
BUG= chromium:711461 
TEST=caroline boots with new binutils deployed.
TEST=No issues seen in toolchain team rotating builders.

dianders NOTE: Picked from v3.18 linuxstable instead of mainline Linux
to avoid conflicts.

Change-Id: I6a4c70aad54fe92564db055f4df28d0ccb21a66d
Signed-off-by: Andy Lutomirski <luto@kernel.org>
Acked-by: H. Peter Anvin <hpa@linux.intel.com>
Cc: Binutils <binutils@sourceware.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: H.J. Lu <hjl.tools@gmail.com>
Cc: Jan Beulich <JBeulich@suse.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: <stable@vger.kernel.org>
Link: http://lkml.kernel.org/r/ac027962af343b0c599cbfcf50b945ad2ef3d7a8.1432336324.git.luto@kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
(cherry picked from commit b28283637b3bd5dc31c0995602b86513ebbaeba7)
Reviewed-on: https://chromium-review.googlesource.com/565354
Commit-Ready: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Guenter Roeck <groeck@chromium.org>

[modify] https://crrev.com/92d776e4ce619c2b3a5100d4aaeb7d028f0a9046/arch/x86/kernel/head_32.S
[modify] https://crrev.com/92d776e4ce619c2b3a5100d4aaeb7d028f0a9046/arch/x86/include/asm/segment.h
[modify] https://crrev.com/92d776e4ce619c2b3a5100d4aaeb7d028f0a9046/arch/x86/kernel/head64.c
[modify] https://crrev.com/92d776e4ce619c2b3a5100d4aaeb7d028f0a9046/arch/x86/kernel/head_64.S

Project Member

Comment 26 by bugdroid1@chromium.org, Jul 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bc25a902690b60562c208cde13df787cf670b81c

commit bc25a902690b60562c208cde13df787cf670b81c
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Wed Jul 26 23:30:30 2017

sys-devel/binutils: upgrade to binutils-2_27.

The source tree was prepared at https://android-review.googlesource.com/#/q/status:merged+project:toolchain/binutils+branch:binutils-2_27-branch

Trybot results are at https://docs.google.com/a/google.com/spreadsheets/d/1Dyha7xOBVjSJM0wVPk-JiDSTimCJRORSG2MJKak0wGk/edit?usp=sharing

For more details, see http://go/chromeos-toolchain-team/binutils-2_27

BUG= chromium:711461 
TEST='cbuildbot --remote -g 566066 --latest-toolchain chromiumos-sdk' was successful.
TEST='Built a panther image with binutils-2_27 and flashed a device successfully.'
TEST='Built a daisy image with binutils-2_27 and flashed a device successfully.'
TEST='Built a elm image with binutils-2_27 and flashed a device successfully.'
TEST='More at https://docs.google.com/a/google.com/spreadsheets/d/1Dyha7xOBVjSJM0wVPk-JiDSTimCJRORSG2MJKak0wGk/edit?usp=sharing'

Change-Id: I386aa7ee0453d4915ac041caff6be7fbdc4ec8f5
Reviewed-on: https://chromium-review.googlesource.com/566066
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Rahul Chaudhry <rahulchaudhry@chromium.org>

[rename] https://crrev.com/bc25a902690b60562c208cde13df787cf670b81c/sys-devel/binutils/binutils-2.27.ebuild
[modify] https://crrev.com/bc25a902690b60562c208cde13df787cf670b81c/sys-devel/binutils/binutils-9999.ebuild

Project Member

Comment 27 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/0774e70fb90ff3c350af666d5d4915ac956b17ce

commit 0774e70fb90ff3c350af666d5d4915ac956b17ce
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Wed Aug 02 17:13:34 2017

generic_stages: temporarily ignore all target prebuilts.

Clear all binaries to build from scratch with binutils-2.27.

Revert this CL once it has participated in a green CQ run.
This process is documented at
- https://sites.google.com/a/google.com/chromeos/for-team-members/infrastructure/chromeos-admin/clear_binaries

BUG= chromium:711461 
TEST='./cbuildbot/run_tests' passed.

Change-Id: I80ef2749a0f63416b26b0e419641df966373864d
Reviewed-on: https://chromium-review.googlesource.com/596494
Commit-Ready: Rahul Chaudhry <rahulchaudhry@chromium.org>
Tested-by: Rahul Chaudhry <rahulchaudhry@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>
Reviewed-by: Luis Lozano <llozano@chromium.org>

[modify] https://crrev.com/0774e70fb90ff3c350af666d5d4915ac956b17ce/cbuildbot/config_dump.json
[modify] https://crrev.com/0774e70fb90ff3c350af666d5d4915ac956b17ce/cbuildbot/stages/build_stages_unittest.py
[modify] https://crrev.com/0774e70fb90ff3c350af666d5d4915ac956b17ce/cbuildbot/stages/generic_stages.py
[modify] https://crrev.com/0774e70fb90ff3c350af666d5d4915ac956b17ce/lib/config_lib.py

Project Member

Comment 28 by bugdroid1@chromium.org, Aug 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/4753160ca0fbb6cfd9a3741bd859093023b7e775

commit 4753160ca0fbb6cfd9a3741bd859093023b7e775
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Wed Aug 02 20:46:03 2017

Revert 'generic_stages: temporarily ignore all target prebuilts.'

This CL reverts the previous CL to clear all binaries to build from
scratch with binutils-2.27.
This process is documented at
- https://sites.google.com/a/google.com/chromeos/for-team-members/infrastructure/chromeos-admin/clear_binaries

BUG= chromium:711461 
TEST='./cbuildbot/run_tests' passed.

Change-Id: I155e47332374c4b6fae174e178d8970bc1d3d97b
Reviewed-on: https://chromium-review.googlesource.com/596495
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Tested-by: Rahul Chaudhry <rahulchaudhry@chromium.org>

[modify] https://crrev.com/4753160ca0fbb6cfd9a3741bd859093023b7e775/cbuildbot/config_dump.json
[modify] https://crrev.com/4753160ca0fbb6cfd9a3741bd859093023b7e775/cbuildbot/stages/build_stages_unittest.py
[modify] https://crrev.com/4753160ca0fbb6cfd9a3741bd859093023b7e775/cbuildbot/stages/generic_stages.py
[modify] https://crrev.com/4753160ca0fbb6cfd9a3741bd859093023b7e775/lib/config_lib.py

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
Closing. Please reopen it if its not fixed. Thanks!
Project Member

Comment 31 by bugdroid1@chromium.org, Sep 21 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/6772be5e6a59eeace7f7deeffdb524a4be78d1eb

commit 6772be5e6a59eeace7f7deeffdb524a4be78d1eb
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Thu Sep 21 08:08:00 2017

sys-devel/binutils: improve configure file lookup in chromeos-version.

In master branch of aosp binutils repo, the binutils sources are not at
top level. The source tree is under a top level directory binutils-2.27/

BUG= chromium:711461 
TEST='cros_mark_as_stable -o ~/trunk/src/third_party/chromiumos-overlay -p sys-devel/binutils commit'
     works and gets version from the correct configure file.

Change-Id: I0cfbb3492acab5202d670087bc91c59b7f955708
Reviewed-on: https://chromium-review.googlesource.com/676200
Commit-Ready: Rahul Chaudhry <rahulchaudhry@chromium.org>
Tested-by: Rahul Chaudhry <rahulchaudhry@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/6772be5e6a59eeace7f7deeffdb524a4be78d1eb/sys-devel/binutils/files/chromeos-version.sh
[rename] https://crrev.com/6772be5e6a59eeace7f7deeffdb524a4be78d1eb/sys-devel/binutils/binutils-2.27.0-r3.ebuild

Project Member

Comment 32 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/915a25e62d771a30d19d785e3b0e11bd46609eab

commit 915a25e62d771a30d19d785e3b0e11bd46609eab
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Fri Sep 29 18:24:37 2017

manifest: sync binutils sources to tip of master branch on aosp.

binutils-2_27-branch has been merged into the master branch on
the aosp binutils repo. There have been a few minor changes to
resolve various build issues on non-linux platforms.

BUG= chromium:711461 
TEST='cros_mark_as_stable -o ~/trunk/src/third_party/chromiumos-overlay -p sys-devel/binutils commit'
     works and uprevs sys-devel/binutils to use the new commit-id.
TEST=built chell image and flashed on a device; boots fine.
TEST=built daisy image and flashed on a device; boots fine.
TEST=built elm image and flashed on a device; boots fine.
CQ-DEPEND=CL:*460012

Change-Id: I51e4a2832789ac523112cd0e1ea4256e055d6b4e
Reviewed-on: https://chromium-review.googlesource.com/676750
Commit-Ready: Rahul Chaudhry <rahulchaudhry@chromium.org>
Tested-by: Rahul Chaudhry <rahulchaudhry@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Rahul Chaudhry <rahulchaudhry@chromium.org>

[modify] https://crrev.com/915a25e62d771a30d19d785e3b0e11bd46609eab/full.xml

Project Member

Comment 33 by bugdroid1@chromium.org, Sep 29 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/5b330543e7af874220bebe4b0d45f239d93ad3f4

commit 5b330543e7af874220bebe4b0d45f239d93ad3f4
Author: Rahul Chaudhry <rahulchaudhry@chromium.org>
Date: Fri Sep 29 18:24:37 2017

Sign in to add a comment