New issue
Advanced search Search tips

Issue 711458 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug

Blocking:
issue 706017



Sign in to add a comment

Call MountEx with a new flag before requesting MigrateToDircrypto to cryptohome.

Project Member Reported by fukino@chromium.org, Apr 13 2017

Issue description

As a preparation for the actual migration process, we should call MountEx with a dedicated mount flag before requesting MigrateToDircrypto.
 

Comment 1 by fukino@chromium.org, Apr 13 2017

Blocking: 706017
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d698c77f8ab3b0e0e61d3fe99bc5ec9c24f8c813

commit d698c77f8ab3b0e0e61d3fe99bc5ec9c24f8c813
Author: fukino <fukino@chromium.org>
Date: Mon Apr 17 17:39:09 2017

cros: Mount the existing eCryptfs vault to start migration.

Before we call cryptohome's MigrateToDircrypto method, we need to mount
existing eCryptfs valut to start migration by calling MountEx method with
|to_migrate_from_ecryptfs| mount flag.

Additionally, this CL removes |auth| argument from MigrateToDircrypto method,
since it was removed from DBUS call in the latest cryptohome.
https://chromium-review.googlesource.com/#/c/472409/6/cryptohome/cryptohome.xml

BUG= 711458 

Review-Url: https://codereview.chromium.org/2818393002
Cr-Commit-Position: refs/heads/master@{#464945}

[modify] https://crrev.com/d698c77f8ab3b0e0e61d3fe99bc5ec9c24f8c813/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
[modify] https://crrev.com/d698c77f8ab3b0e0e61d3fe99bc5ec9c24f8c813/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.h
[modify] https://crrev.com/d698c77f8ab3b0e0e61d3fe99bc5ec9c24f8c813/chromeos/cryptohome/cryptohome_parameters.h
[modify] https://crrev.com/d698c77f8ab3b0e0e61d3fe99bc5ec9c24f8c813/chromeos/cryptohome/homedir_methods.cc
[modify] https://crrev.com/d698c77f8ab3b0e0e61d3fe99bc5ec9c24f8c813/chromeos/cryptohome/homedir_methods.h
[modify] https://crrev.com/d698c77f8ab3b0e0e61d3fe99bc5ec9c24f8c813/chromeos/cryptohome/mock_homedir_methods.h
[modify] https://crrev.com/d698c77f8ab3b0e0e61d3fe99bc5ec9c24f8c813/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/d698c77f8ab3b0e0e61d3fe99bc5ec9c24f8c813/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/d698c77f8ab3b0e0e61d3fe99bc5ec9c24f8c813/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/d698c77f8ab3b0e0e61d3fe99bc5ec9c24f8c813/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/d698c77f8ab3b0e0e61d3fe99bc5ec9c24f8c813/chromeos/dbus/mock_cryptohome_client.h

Comment 3 by fukino@chromium.org, Apr 17 2017

Labels: Merge-Request-59

Comment 4 by gkihumba@google.com, Apr 18 2017

Labels: Merge-Approved-59
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 18 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by bugdroid1@chromium.org, Apr 20 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/268dd43e110778c23fbf94ecac3171664589b751

commit 268dd43e110778c23fbf94ecac3171664589b751
Author: Naoki Fukino <fukino@chromium.org>
Date: Thu Apr 20 03:05:59 2017

cros: Mount the existing eCryptfs vault to start migration.

Before we call cryptohome's MigrateToDircrypto method, we need to mount
existing eCryptfs valut to start migration by calling MountEx method with
|to_migrate_from_ecryptfs| mount flag.

Additionally, this CL removes |auth| argument from MigrateToDircrypto method,
since it was removed from DBUS call in the latest cryptohome.
https://chromium-review.googlesource.com/#/c/472409/6/cryptohome/cryptohome.xml

BUG= 711458 
TBR=xiyuan@chromium.org,hashimoto@chromium.org

Review-Url: https://codereview.chromium.org/2818393002
Cr-Commit-Position: refs/heads/master@{#464945}
(cherry picked from commit d698c77f8ab3b0e0e61d3fe99bc5ec9c24f8c813)

Review-Url: https://codereview.chromium.org/2827203002 .
Cr-Commit-Position: refs/branch-heads/3071@{#77}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/268dd43e110778c23fbf94ecac3171664589b751/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc
[modify] https://crrev.com/268dd43e110778c23fbf94ecac3171664589b751/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.h
[modify] https://crrev.com/268dd43e110778c23fbf94ecac3171664589b751/chromeos/cryptohome/cryptohome_parameters.h
[modify] https://crrev.com/268dd43e110778c23fbf94ecac3171664589b751/chromeos/cryptohome/homedir_methods.cc
[modify] https://crrev.com/268dd43e110778c23fbf94ecac3171664589b751/chromeos/cryptohome/homedir_methods.h
[modify] https://crrev.com/268dd43e110778c23fbf94ecac3171664589b751/chromeos/cryptohome/mock_homedir_methods.h
[modify] https://crrev.com/268dd43e110778c23fbf94ecac3171664589b751/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/268dd43e110778c23fbf94ecac3171664589b751/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/268dd43e110778c23fbf94ecac3171664589b751/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/268dd43e110778c23fbf94ecac3171664589b751/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/268dd43e110778c23fbf94ecac3171664589b751/chromeos/dbus/mock_cryptohome_client.h

Comment 7 by fukino@chromium.org, Apr 26 2017

Status: Fixed (was: Assigned)
Labels: code-change
Status: Verified (was: Fixed)
Labels: -M59 M-59

Sign in to add a comment