New issue
Advanced search Search tips

Issue 711455 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Oct 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Tab switcher snapshots not created for some websites

Project Member Reported by srikanthg@chromium.org, Apr 13 2017

Issue description

App Version: 58.0.3029.71 beta
iOS Version: 10.3.2, 10.3, 10.2
Device: iPhone7, iPad
URL: cnn.com, amazon.com

Steps to reproduce:
  1. Launch Google Chrome
  2. Visit cnn.com, amazon.com and close the tabs
  3. Open new tab and navigate to cnn.com and let the page preload while typing the address in omnibox
  4. Tap on the tab switcher icon to enter tab switcher mode

Observed results: Observe that black snapshot is displayed.
I am able to consistently reproduce this cnn.com, but also noticed sometimes with amazon.com.
Note: Works fine if Preload webpages is disabled. Settings → Bandwidth → Preload webpages → Never

Expected results: Correct snapshot of the webpage should be displayed

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: NA
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): M57 NO
Bug reproducible on the current beta channel build (App Version, iOS Version): M58 Yes

Link to video/image: https://drive.google.com/file/d/0B-xmXLQhjeKuVWt5WGl6bjM1bFE/view
 

Comment 1 by sczs@chromium.org, Apr 19 2017

Cc: edchin@chromium.org
Labels: M-59
Owner: jif@chromium.org
Status: Assigned (was: Untriaged)
jif@ could you please take a look.

Comment 2 by sczs@chromium.org, Apr 19 2017

Labels: ReleaseBlock-Stable
jif@ any update on this RBS?

Comment 4 by jif@chromium.org, May 3 2017

Status: Started (was: Assigned)

Comment 5 by jif@chromium.org, May 5 2017

Labels: -ReleaseBlock-Stable
Owner: srikanthg@chromium.org
Status: Assigned (was: Started)
I can't reproduce.
srikanthg, can you still reproduce?

This is definitely not RBS: according to #0, it requires the page to preload completely, which I doubt happens often. And even then, it's not a crash.
Status: WontFix (was: Assigned)
I am not to reproduce either. Will reopen the issue If i can reproduce again.
Verified on M58 stable and M60 canary.
Cc: -edchin@chromium.org srikanthg@chromium.org yangulo@chromium.org
Labels: -M-59 -found-in-m58 M-64 found-in-m64
Owner: edchin@chromium.org
Status: Assigned (was: WontFix)
I am able to reproduce this issue on M64 and M63

App Version:  Chrome 64.0.3282.31 beta
iOS Version: iOS 10.3.3
Device: iPad

Steps to reproduce:
1. Launch Chrome
2. Navigate to ccn.com 
3. Tap the tab-switcher button
4. Tap the tab-switcher button again
5. Try opening and closing the tab switcher several times quickly.

Observed results:
CNN.com site does not persist the screenshot of the page in tab switcher mode. This is not reproducible in other sites like Fox news and Newsweek.

Expected results:
CNN.com should persist the screenshot of the page in tab switcher mode. 

Note: There are two behaviors found. 1) the screenshot is blank in tab switcher mode as shown in the video and 2) after clean install it shows always the top of the page screenshot. Sometimes ESPN.com has similar behavior.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Safari/Firefox: Firefox: No, Safari: No
Bug reproducible on current stable build (App Version, iOS Version): Yes M63 (behavior 2)
Bug reproducible on the current beta channel build (App Version, iOS Version): Yes M64

Type-bug-regression? No

Link to video/image:
https://drive.google.com/open?id=1yuHydxrbfFIE-z2WHvOHta0eGerB1R3W
Cc: marq@chromium.org martijnb@chromium.org pschaffner@chromium.org mard...@chromium.org edchin@chromium.org
 Issue 868289  has been merged into this issue.
Cc: pinkerton@chromium.org
Labels: -Pri-2 -M-64 M-70 Pri-1
I commented here: https://bugs.chromium.org/p/chromium/issues/detail?id=868289#c8 
Is that the same issue? and why is the snapshotting behaviour on today's stable with YouTube different from M69?
Mardini@ I replied to your comment on 
https://bugs.chromium.org/p/chromium/issues/detail?id=868289#c8 
Labels: -Pri-1 -M-70 Pri-2
This is a known issue. The snapshot mechanism just is not able to take a snapshot for some websites, such as some that play video ads somewhere on the page or is playing videos like cnn.com. 

Previously, we used to show a stale snapshot if the snapshotting failed. This could lead to mismatched snapshots (such as a completely different webpage). 

In the latest build, we take the approach of showing a blank snapshot if the snapshotting failed on the webpage. This is better since we won't show a stale or mismatched snapshot. 

The solution is to use the new iOS 11 snapshotting API. For iOS 10 users, there is no fix. 
Thanks for the clarification, Ed. Is using the new iOS 11 snapshotting API scoped for M70 or M71? I think it's a pretty critical and visible improvement.
Labels: -Pri-2 Pri-1
Project Member

Comment 14 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/716114301facb965707db82df94a6433a21b2969

commit 716114301facb965707db82df94a6433a21b2969
Author: edchin <edchin@chromium.org>
Date: Tue Sep 25 19:31:34 2018

[ios] Update snapshotting to use WKWebView API

This CL creates a codepath that utilizes the WKWebView snapshotting
API when IsWKWebViewSnapshotsEnabled() is true. This CL intentionally
keeps the original codepath intact so as to minimize the risk of
refactoring errors.

Bug:  739840 , 869256,  711455 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I80324e82573851b1a62cda75242679cf59008c3e
Reviewed-on: https://chromium-review.googlesource.com/1235714
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#594055}
[modify] https://crrev.com/716114301facb965707db82df94a6433a21b2969/ios/chrome/app/main_controller.mm
[modify] https://crrev.com/716114301facb965707db82df94a6433a21b2969/ios/chrome/browser/snapshots/BUILD.gn
[modify] https://crrev.com/716114301facb965707db82df94a6433a21b2969/ios/chrome/browser/snapshots/snapshot_generator.h
[modify] https://crrev.com/716114301facb965707db82df94a6433a21b2969/ios/chrome/browser/snapshots/snapshot_generator.mm
[modify] https://crrev.com/716114301facb965707db82df94a6433a21b2969/ios/chrome/browser/snapshots/snapshot_tab_helper.h
[modify] https://crrev.com/716114301facb965707db82df94a6433a21b2969/ios/chrome/browser/snapshots/snapshot_tab_helper.mm

Status: Fixed (was: Assigned)
This is fixed in the snapshots improvements. Enable flag WKWebViewSnapshots. This flag will be enabled by default this week.
Status: Verified (was: Fixed)
Issue verified 
Version: Chrome Beta 71.0.3578.76
Device: iPad Air
iOS: 11.4.1

Correct snapshots
https://drive.google.com/open?id=1xbBcE8pBKnwU_YxXadX_vxW5oVJNFHr1

Sign in to add a comment