Prevent users from shutting down the device during encryption migration. |
||||||||
Issue descriptionEven when a user shuts down the device during migration, we can resume the migration in the next sign in. However, preventing the user from shutting down the device should make the migration process safer.
,
Apr 25 2017
,
Apr 25 2017
,
Apr 25 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e88b030f517ff578aff9af1a5a7762fc313163ad commit e88b030f517ff578aff9af1a5a7762fc313163ad Author: fukino <fukino@chromium.org> Date: Tue Apr 25 05:18:39 2017 cros: Prevent casual shut down and power save during migration. In the migration UI, we ask users that "Don't turn off or close your Chromebook". In addition, we can resume migration even when user shut down / suspend the device during migration. That said, it should be even safer to prevent casual shutdown and power save mode by: - Hide "Shut down" button during migration. - Block power save during migration. Note that if the user close the lid, the system will be suspended. We have heard about heat issues when the lid is closed, and the system will be heated by heavy CPU usage of migration. It should be safer not to keep the device awake when the lid is closed. BUG= 711454 TEST=manually tested that the "Shut down" button was hidden and the device did not go to sleep mode during migration. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2842433002 Cr-Commit-Position: refs/heads/master@{#466879} [modify] https://crrev.com/e88b030f517ff578aff9af1a5a7762fc313163ad/chrome/browser/resources/chromeos/login/header_bar.css [modify] https://crrev.com/e88b030f517ff578aff9af1a5a7762fc313163ad/chrome/browser/resources/chromeos/login/screen_encryption_migration.js [modify] https://crrev.com/e88b030f517ff578aff9af1a5a7762fc313163ad/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/e88b030f517ff578aff9af1a5a7762fc313163ad/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc [modify] https://crrev.com/e88b030f517ff578aff9af1a5a7762fc313163ad/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.h
,
Apr 26 2017
,
Apr 26 2017
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Apr 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55a06d1004b127df1fde63455dcb6cdd458714e2 commit 55a06d1004b127df1fde63455dcb6cdd458714e2 Author: Naoki Fukino <fukino@chromium.org> Date: Wed Apr 26 10:46:10 2017 cros: Prevent casual shut down and power save during migration. In the migration UI, we ask users that "Don't turn off or close your Chromebook". In addition, we can resume migration even when user shut down / suspend the device during migration. That said, it should be even safer to prevent casual shutdown and power save mode by: - Hide "Shut down" button during migration. - Block power save during migration. Note that if the user close the lid, the system will be suspended. We have heard about heat issues when the lid is closed, and the system will be heated by heavy CPU usage of migration. It should be safer not to keep the device awake when the lid is closed. BUG= 711454 TEST=manually tested that the "Shut down" button was hidden and the device did not go to sleep mode during migration. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation TBR=xiyuan@chromium.org Review-Url: https://codereview.chromium.org/2842433002 Cr-Commit-Position: refs/heads/master@{#466879} (cherry picked from commit e88b030f517ff578aff9af1a5a7762fc313163ad) Review-Url: https://codereview.chromium.org/2842143002 . Cr-Commit-Position: refs/branch-heads/3071@{#222} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/55a06d1004b127df1fde63455dcb6cdd458714e2/chrome/browser/resources/chromeos/login/header_bar.css [modify] https://crrev.com/55a06d1004b127df1fde63455dcb6cdd458714e2/chrome/browser/resources/chromeos/login/screen_encryption_migration.js [modify] https://crrev.com/55a06d1004b127df1fde63455dcb6cdd458714e2/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/55a06d1004b127df1fde63455dcb6cdd458714e2/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.cc [modify] https://crrev.com/55a06d1004b127df1fde63455dcb6cdd458714e2/chrome/browser/ui/webui/chromeos/login/encryption_migration_screen_handler.h
,
Apr 26 2017
,
May 8 2017
Verified on ChromeOS 9532.0.0, 60.0.3092.0 |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by dspaid@chromium.org
, Apr 24 2017