New issue
Advanced search Search tips

Issue 711452 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jun 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

Make +1 / +2 review flags sticky

Project Member Reported by dgarr...@chromium.org, Apr 13 2017

Issue description

We currently clear the +1 / +2 review flags whenever a new revision is uploaded, but it's very common to +2 / nits. This either requires a round trip to the reviewer, or for the author to +2 the CL themselves.

Maybe we should instead configure the +2 to be sticky so that there is more visibility into who really reviewed a change, and so there is less overhead for review management.

Before just doing this, we should get signoff from the ChromeOS team.

Assigning to Richard, who inspired this by forgetting he had a +2 and was annoyed nobody was reviewing his CL.
 
Labels: Hotlist-Fixit
Owner: ----
Status: Available (was: Untriaged)
This'd be nice to have, but it's not my problem to fix.

Another example of confusion from this morning.

https://chromium-review.googlesource.com/#/c/465423/
Owner: dgarr...@chromium.org

Comment 4 by aut...@google.com, Apr 18 2017

Labels: -current-issue
Status: WontFix (was: Available)

Sign in to add a comment