SystemMetrics2Test.GetSystemMemoryInfo is flaky on iOS devices |
||||||||
Issue descriptionThis test is flaky on iOS devices and fails on the following line: EXPECT_LT(info.free, info.total); The test fails about 30 runs during the past 100 builds. And here are some examples: https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad9-device-x64/builds/10468 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad9-device-x64/builds/10456 https://uberchromegw.corp.google.com/i/internal.bling.main/builders/ipad9-device-x64/builds/10441
,
Apr 13 2017
I think process_metrics_ios.mm is relevant here, recently touched in https://chromium.googlesource.com/chromium/src/+/01ac10b7938701bc9f9f2c05faf18229f9573b4c
,
Apr 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/71606ecc2ff8f79fd8aa0b9d6f41c8f747a6d470 commit 71606ecc2ff8f79fd8aa0b9d6f41c8f747a6d470 Author: liaoyuke <liaoyuke@chromium.org> Date: Thu Apr 13 22:46:17 2017 Disable invalid assertion in GetSystemMemoryInfo test on iOS. SystemMetrics2Test.GetSystemMemoryInfo is flaky on iOS devices and fails on the following line: EXPECT_LT(info.free, info.total). The test fails about 30 runs during the past 100 builds. This CL disables the invalid assertion. BUG=711450 Review-Url: https://codereview.chromium.org/2814303003 Cr-Commit-Position: refs/heads/master@{#464583} [modify] https://crrev.com/71606ecc2ff8f79fd8aa0b9d6f41c8f747a6d470/base/process/process_metrics_unittest.cc
,
Apr 14 2017
I'm the author of that EXPECT_LT. Could you post here its failures/logs plz? I (I do't have an access to the builds above)
,
Apr 14 2017
Thanks for looking at it! Sure, below is the one of the logs, the other two look similar, let me know if you need me to post all of the three. [----------] 1 test from SystemMetrics2Test [ RUN ] SystemMetrics2Test.GetSystemMemoryInfo ../../base/process/process_metrics_unittest.cc:422: Failure Expected: (info.free) < (info.total), actual: 1042928 vs 997376 [ FAILED ] SystemMetrics2Test.GetSystemMemoryInfo (1 ms) [----------] 1 test from SystemMetrics2Test (2 ms total) Retry #1 for SystemMetrics2Test.GetSystemMemoryInfo. idevice-app-runner --udid cac6fdb0640d5c6ffebc912b30c6082901e5c7ad --start com.google.gtest.base-unittests -D GKIF_SCENARIO_FILTER=NAME:SystemMetrics2Test.GetSystemMemoryInfo --args --gtest_filter=SystemMetrics2Test.GetSystemMemoryInfo Detected presence of a debugger, running without test timeouts. Note: Google Test filter = SystemMetrics2Test.GetSystemMemoryInfo [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from SystemMetrics2Test [ RUN ] SystemMetrics2Test.GetSystemMemoryInfo ../../base/process/process_metrics_unittest.cc:422: Failure Expected: (info.free) < (info.total), actual: 1068272 vs 997376 [ FAILED ] SystemMetrics2Test.GetSystemMemoryInfo (0 ms) [----------] 1 test from SystemMetrics2Test (3 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (4 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] SystemMetrics2Test.GetSystemMemoryInfo 1 FAILED TEST idevice-app-runner returned 0 Retry #2 for SystemMetrics2Test.GetSystemMemoryInfo. idevice-app-runner --udid cac6fdb0640d5c6ffebc912b30c6082901e5c7ad --start com.google.gtest.base-unittests -D GKIF_SCENARIO_FILTER=NAME:SystemMetrics2Test.GetSystemMemoryInfo --args --gtest_filter=SystemMetrics2Test.GetSystemMemoryInfo Detected presence of a debugger, running without test timeouts. Note: Google Test filter = SystemMetrics2Test.GetSystemMemoryInfo [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from SystemMetrics2Test [ RUN ] SystemMetrics2Test.GetSystemMemoryInfo ../../base/process/process_metrics_unittest.cc:422: Failure Expected: (info.free) < (info.total), actual: 1058336 vs 997376 [ FAILED ] SystemMetrics2Test.GetSystemMemoryInfo (1 ms) [----------] 1 test from SystemMetrics2Test (2 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (2 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] SystemMetrics2Test.GetSystemMemoryInfo 1 FAILED TEST idevice-app-runner returned 0 Retry #3 for SystemMetrics2Test.GetSystemMemoryInfo. idevice-app-runner --udid cac6fdb0640d5c6ffebc912b30c6082901e5c7ad --start com.google.gtest.base-unittests -D GKIF_SCENARIO_FILTER=NAME:SystemMetrics2Test.GetSystemMemoryInfo --args --gtest_filter=SystemMetrics2Test.GetSystemMemoryInfo Detected presence of a debugger, running without test timeouts. Note: Google Test filter = SystemMetrics2Test.GetSystemMemoryInfo [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from SystemMetrics2Test [ RUN ] SystemMetrics2Test.GetSystemMemoryInfo ../../base/process/process_metrics_unittest.cc:422: Failure Expected: (info.free) < (info.total), actual: 1066912 vs 997376 [ FAILED ] SystemMetrics2Test.GetSystemMemoryInfo (1 ms) [----------] 1 test from SystemMetrics2Test (2 ms total) [----------] Global test environment tear-down [==========] 1 test from 1 test case ran. (2 ms total) [ PASSED ] 0 tests. [ FAILED ] 1 test, listed below: [ FAILED ] SystemMetrics2Test.GetSystemMemoryInfo
,
Apr 14 2017
,
May 16 2017
mkolom@ any update on the fix?
,
May 17 2017
Removing RBB as this test is only flaky and disabled on devices.
,
Sep 14 2017
,
Jan 24 2018
,
Jan 24 2018
,
Feb 23 2018
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by liaoyuke@chromium.org
, Apr 13 2017