New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711425 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
EstimatedDays: ----
NextAction: ----
OS: Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

close-x button on dialogs 2px too low

Project Member Reported by bettes@chromium.org, Apr 13 2017

Issue description

Splitting hairs here but the 16x16 close-x icon is 2px too low in 59.0.3070.0
 
Artboard 2 (1).png
137 KB View Download
current.png
33.2 KB View Download
Status: WontFix (was: Assigned)
Button height 36px + top margin 4px + bottom margin 4px = 44 px. Title height 47px. 
To be center aligned with title, there'll be a 1~2px offset comparing to spec, otherwise the math won't add up.

Comment 2 by bettes@chromium.org, Apr 14 2017

Status: Assigned (was: WontFix)
I wasn't considering alignment with a title a requirement actually. Something like the following?


close-x.png
84.5 KB View Download
Discarding center alignment and having a fixed 4px margin top/right in very large fonts will look like the attached screenshot. Please let me know if thats what we want and I can make the change.
Screenshot from 2017-04-14 11:00:37.png
17.8 KB View Download

Comment 4 by bettes@chromium.org, Apr 18 2017

Is there a reason to evaluate this for large fonts only?
The larger the font, the more vertically off-centered it would be comparing to the title font. 
You did already mention that center-alignment wasn't a requirement, I just wanted to confirm that the result actually does look okay to you.

Comment 6 by bettes@chromium.org, Apr 18 2017

I see. Yeah your screenshot in #3 lgtm. Thanks for clarifying dude!
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Apr 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f6cbd1a7c6fc9970840ad5242dad4cfb55753630

commit f6cbd1a7c6fc9970840ad5242dad4cfb55753630
Author: scottchen <scottchen@chromium.org>
Date: Thu Apr 20 21:34:23 2017

WebUI: dialog close button should have fixed 4px top margin

BUG= 711425 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2826763002
Cr-Commit-Position: refs/heads/master@{#466146}

[modify] https://crrev.com/f6cbd1a7c6fc9970840ad5242dad4cfb55753630/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html

Status: Fixed (was: Started)

Sign in to add a comment