close-x button on dialogs 2px too low |
||||
Issue descriptionSplitting hairs here but the 16x16 close-x icon is 2px too low in 59.0.3070.0
,
Apr 14 2017
I wasn't considering alignment with a title a requirement actually. Something like the following?
,
Apr 14 2017
Discarding center alignment and having a fixed 4px margin top/right in very large fonts will look like the attached screenshot. Please let me know if thats what we want and I can make the change.
,
Apr 18 2017
Is there a reason to evaluate this for large fonts only?
,
Apr 18 2017
The larger the font, the more vertically off-centered it would be comparing to the title font. You did already mention that center-alignment wasn't a requirement, I just wanted to confirm that the result actually does look okay to you.
,
Apr 18 2017
I see. Yeah your screenshot in #3 lgtm. Thanks for clarifying dude!
,
Apr 18 2017
,
Apr 20 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6cbd1a7c6fc9970840ad5242dad4cfb55753630 commit f6cbd1a7c6fc9970840ad5242dad4cfb55753630 Author: scottchen <scottchen@chromium.org> Date: Thu Apr 20 21:34:23 2017 WebUI: dialog close button should have fixed 4px top margin BUG= 711425 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2826763002 Cr-Commit-Position: refs/heads/master@{#466146} [modify] https://crrev.com/f6cbd1a7c6fc9970840ad5242dad4cfb55753630/ui/webui/resources/cr_elements/cr_dialog/cr_dialog.html
,
Apr 21 2017
|
||||
►
Sign in to add a comment |
||||
Comment 1 by scottchen@chromium.org
, Apr 13 2017