New issue
Advanced search Search tips

Issue 711413 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Optimize pre-paint tree walk further.

Project Member Reported by chrishtr@chromium.org, Apr 13 2017

Issue description

https://codereview.chromium.org/2810503 changed the output in SPv2
mode. Why?
 
Labels: BugSource-Team PaintTeamTriaged-20170413
Status: WontFix (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1cf31c84ed81fce3a5033e601afafd402fee87f

commit d1cf31c84ed81fce3a5033e601afafd402fee87f
Author: chrishtr <chrishtr@chromium.org>
Date: Fri Apr 14 03:54:48 2017

Only store previous clip rects for PaintLayers that support subsequences.

To do this:

2. When updating paint properties, only invalidate painting optimizations like
subsequence for PaintLayers that support it (stacking context, SVG root), or
have clip-related properties

BUG= 692614 , 711413 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2810503002
Cr-Commit-Position: refs/heads/master@{#464670}

[modify] https://crrev.com/d1cf31c84ed81fce3a5033e601afafd402fee87f/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/d1cf31c84ed81fce3a5033e601afafd402fee87f/third_party/WebKit/Source/core/paint/PaintLayer.h
[modify] https://crrev.com/d1cf31c84ed81fce3a5033e601afafd402fee87f/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/d1cf31c84ed81fce3a5033e601afafd402fee87f/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp
[modify] https://crrev.com/d1cf31c84ed81fce3a5033e601afafd402fee87f/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
[modify] https://crrev.com/d1cf31c84ed81fce3a5033e601afafd402fee87f/third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp

Labels: -Pri-3 Merge-Request-59 M-59 Pri-2
Status: Assigned (was: WontFix)
Summary: Optimize pre-paint tree walk further. (was: Clip change in paint/invalidation/clip-unclip-and-change.html in SPv2 mode.)
Repurposing this bug. :)

Requesting merge of https://codereview.chromium.org/2810503002 into M59 - just
barely missed the cut.
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 14 2017

Labels: -Merge-Request-59 Merge-Review-59 Hotlist-Merge-Review
This bug requires manual review: We don't branch M59 until 2017-04-13.
Please contact the milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Ping - can I merge to M59?
Can you please confirm if this has been baked into canary, tested, verified, and if there is enough unit testing coverage for this?
Re comment 7: yes and yes. It has baked with tests since 5 days ago.
Labels: -Merge-Review-59 Merge-Approved-59
Thanks for confirming - approving this for M59. 
Project Member

Comment 10 by bugdroid1@chromium.org, Apr 19 2017

Labels: -merge-approved-59 merge-merged-3071
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a3ba22889b3f2565f6e430eca4a827e0e52e0301

commit a3ba22889b3f2565f6e430eca4a827e0e52e0301
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Wed Apr 19 18:15:44 2017

Only store previous clip rects for PaintLayers that support subsequences.

To do this:

2. When updating paint properties, only invalidate painting optimizations like
subsequence for PaintLayers that support it (stacking context, SVG root), or
have clip-related properties

BUG= 692614 , 711413 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2810503002
Cr-Commit-Position: refs/heads/master@{#464670}
(cherry picked from commit d1cf31c84ed81fce3a5033e601afafd402fee87f)

Review-Url: https://codereview.chromium.org/2832603002 .
Cr-Commit-Position: refs/branch-heads/3071@{#57}
Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

[modify] https://crrev.com/a3ba22889b3f2565f6e430eca4a827e0e52e0301/third_party/WebKit/Source/core/paint/PaintLayer.cpp
[modify] https://crrev.com/a3ba22889b3f2565f6e430eca4a827e0e52e0301/third_party/WebKit/Source/core/paint/PaintLayer.h
[modify] https://crrev.com/a3ba22889b3f2565f6e430eca4a827e0e52e0301/third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp
[modify] https://crrev.com/a3ba22889b3f2565f6e430eca4a827e0e52e0301/third_party/WebKit/Source/core/paint/PaintLayerTest.cpp
[modify] https://crrev.com/a3ba22889b3f2565f6e430eca4a827e0e52e0301/third_party/WebKit/Source/core/paint/PrePaintTreeWalk.cpp
[modify] https://crrev.com/a3ba22889b3f2565f6e430eca4a827e0e52e0301/third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp

Status: Fixed (was: Assigned)

Sign in to add a comment