New issue
Advanced search Search tips

Issue 711412 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 2
Type: Bug



Sign in to add a comment

DevTools: move eye dropper functionality from protocol to embedder API

Project Member Reported by dgozman@chromium.org, Apr 13 2017

Issue description

This feature does not make sense for remote debugging or automation, which suggests it's an embedder feature.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9adbfb97089e255303e640084c0eb45481766457

commit 9adbfb97089e255303e640084c0eb45481766457
Author: dgozman <dgozman@chromium.org>
Date: Fri Apr 14 00:52:37 2017

Allow content embedder to set a cursor for RenderWidgetHost

One example is DevTools eye dropper feature which changes
cursor to custom image built from the rendered page contents.

content::CursorInfo is introduced to pass the data through
public API.

BUG= 711412 
TBR=inferno@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2808763009
Cr-Commit-Position: refs/heads/master@{#464633}

[modify] https://crrev.com/9adbfb97089e255303e640084c0eb45481766457/content/browser/devtools/protocol/color_picker.cc
[modify] https://crrev.com/9adbfb97089e255303e640084c0eb45481766457/content/browser/renderer_host/input/touch_emulator.cc
[modify] https://crrev.com/9adbfb97089e255303e640084c0eb45481766457/content/browser/renderer_host/input/touch_emulator_unittest.cc
[modify] https://crrev.com/9adbfb97089e255303e640084c0eb45481766457/content/browser/renderer_host/render_widget_host_impl.cc
[modify] https://crrev.com/9adbfb97089e255303e640084c0eb45481766457/content/browser/renderer_host/render_widget_host_impl.h
[modify] https://crrev.com/9adbfb97089e255303e640084c0eb45481766457/content/common/cursors/webcursor.h
[modify] https://crrev.com/9adbfb97089e255303e640084c0eb45481766457/content/common/cursors/webcursor_unittest.cc
[modify] https://crrev.com/9adbfb97089e255303e640084c0eb45481766457/content/public/browser/render_widget_host.h
[modify] https://crrev.com/9adbfb97089e255303e640084c0eb45481766457/content/public/common/BUILD.gn
[add] https://crrev.com/9adbfb97089e255303e640084c0eb45481766457/content/public/common/cursor_info.h
[modify] https://crrev.com/9adbfb97089e255303e640084c0eb45481766457/content/renderer/cursor_utils.cc
[modify] https://crrev.com/9adbfb97089e255303e640084c0eb45481766457/tools/ipc_fuzzer/fuzzer/fuzzer.cc

Status: Fixed (was: Assigned)
Done in https://codereview.chromium.org/2817593004/.

Sign in to add a comment