New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 711409 link

Starred by 2 users
Status: Fixed
Owner:
█ lilyhoughton@chromium.org
Last visit > 30 days ago
Closed: Jun 2017
Cc:
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug



Sign in to add a comment

Presubmit warning from components/cronet/tools/generate_accept_languages.py

Project Member Reported by xunji...@chromium.org, Apr 13 2017 
It looks like the filter() function is discouraged.

This gives a presubmit warning:


************* Module cronet.tools.generate_accept_languages
W: 28,14: Used builtin function 'filter' (bad-builtin)

Comment 1 by mef@chromium.org, Apr 13 2017

Labels: OS-iOS
Owner: lilyhoughton@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Jun 28 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f1a5a6b25d91ad86812bdc7a214d5d71d9c61de5

commit f1a5a6b25d91ad86812bdc7a214d5d71d9c61de5
Author: lilyhoughton <lilyhoughton@chromium.org>
Date: Wed Jun 28 15:47:25 2017

[cronet] replace filter with comprehension in build script

BUG= 711409 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2960673003
Cr-Commit-Position: refs/heads/master@{#483001}

[modify] https://crrev.com/f1a5a6b25d91ad86812bdc7a214d5d71d9c61de5/components/cronet/tools/generate_accept_languages.py

Comment 3 by lilyhoughton@chromium.org, Jun 28 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment