New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711402 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: Bug-Regression



Sign in to add a comment

22.6% regression in graphics_SanAngeles at 30650000944000000:30650000944100000

Project Member Reported by marcheu@google.com, Apr 13 2017

Issue description

Comment 1 by marcheu@google.com, Apr 13 2017

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=711402

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgIDggoiPtQoM


Bot(s) for this bug's original alert(s):

cros-glimmer
Cc: marc...@chromium.org
 Issue 711403  has been merged into this issue.
I think it's the same regression as 2 years ago, on the same device, but different kernel: https://bugs.chromium.org/p/chromium/issues/detail?id=440290
44fdf0bad4fd06c2d24d1657d63c869610f780c2 is the first bad commit
commit 44fdf0bad4fd06c2d24d1657d63c869610f780c2
Author: Philippe Longepe <philippe.longepe@intel.com>
Date:   Fri Dec 4 17:40:30 2015 +0100

    UPSTREAM: cpufreq: intel_pstate: Configurable algorithm to get target pstate
    
    Target systems using different cpus have different power and performance
    requirements. They may use different algorithms to get the next P-state
    based on their power or performance preference.
    
    For example, power-constrained systems may not want to use
    high-performance P-states as aggressively as a full-size desktop or a
    server platform. A server platform may want to run close to the max to
    achieve better performance, while laptop-like systems may prefer
    sacrificing performance for longer battery lifes.
    
    For the above reasons, modify intel_pstate to allow the target P-state
    selection algorithm to be depend on the CPU ID.
    
    Signed-off-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
    Signed-off-by: Philippe Longepe <philippe.longepe@intel.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    (cherry picked from commit 157386b6fc1465f292b66c4133409033650ad335)
    Signed-off-by: Aditya Swarup <aditya.swarup@intel.com>
    
    BUG=chrome-os-partner:61059
    TEST=cd /sys/devices/system/cpu -> sysfs entry for intel_pstate/
    iotools rdmsr 0(cpu no) 0x770 -> 1 (Intel HWP enabled)
    
    Change-Id: Ie47d655d6573b931eb48e44b78ab20caecd6e384
    Reviewed-on: https://chromium-review.googlesource.com/458999
    Commit-Ready: Aditya Swarup <aditya.swarup@intel.com>
    Tested-by: Casey G Bowman <casey.g.bowman@intel.com>
    Reviewed-by: Puthikorn Voravootivat <puthik@chromium.org>

:040000 040000 c4d52af3fd368a694a247bce1d8236955a511621 760ae084a8a55a0b0bbda070f7c7daf9b6cee391 M      drivers

Cc: puthik@chromium.org
Revert stack coming...
Reverts happened there: https://chromium-review.googlesource.com/c/477460/

Comment 7 by ihf@chromium.org, Apr 17 2017

Status: Fixed (was: Assigned)
On the positive side performance is back.

Comment 8 by ihf@chromium.org, Apr 17 2017

Status: Verified (was: Fixed)

Sign in to add a comment