New issue
Advanced search Search tips

Issue 711395 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

Presubmit and git format disagreeing on wrapped java annotation formatting

Project Member Reported by dgn@chromium.org, Apr 13 2017

Issue description

Current code:

```
@Features({
        @Features.Register(value = ChromeFeatureList.NTP_CONDENSED_LAYOUT, enabled = false),
        @Features.Register(value = ChromeFeatureList.CHROME_HOME, enabled = false)})
public class NewTabPageAdapterTest { ...
```

This results in a presubmit warning, requiring to run `git cl format`
When I run it I get


```
@Features({
    @Features.Register(value = ChromeFeatureList.NTP_CONDENSED_LAYOUT, enabled = false)
    , @Features.Register(value = ChromeFeatureList.CHROME_HOME, enabled = false)
})
public class NewTabPageAdapterTest {
```

This results in a presubmit error:

.../NewTabPageAdapterTest.java:86: '@' have incorrect indentation level 4, expected level should be 8.
.../NewTabPageAdapterTest.java:87: ',' have incorrect indentation level 4, expected level should be 8.
.../NewTabPageAdapterTest.java:87:5: ',' should be on the previous line.
.../NewTabPageAdapterTest.java:88: '}' have incorrect indentation level 0, expected level should be 8.

 

Sign in to add a comment