New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711369 link

Starred by 1 user

Issue metadata

Status: Available
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature

Blocked on:
issue 855981
issue 884949



Sign in to add a comment

rename armv7a-cros-linux-gnueabi to armv7a-cros-linux-gnueabihf

Project Member Reported by vapier@chromium.org, Apr 13 2017

Issue description

we should figure out what it'd take to rename this tuple.  the wider ecosystem has moved away from the ambiguous gnueabi to gnueabihf for hardfloat.  we've had to patch a few places (notably in llvm) to deal with it.

it'll also let us clean up USE=hardfp everywhere.  and if/when we get softfp requests, we can satisfy them -- i recall some internal teams asking in the past (related to firmware/bare metal) and we just told them no.

off the top of my head, the process could look like (done in a way we can take stable small steps):
- update chromite to handle armv7a-cros-linux-gnueabihf everywhere (in addition to gnueabi)
- add armv7a-cros-linux-gnueabihf to overlay-arm-generic/toolchain.conf
- let the sdk bot run and build this new toolchain
- switch arm-generic's default CHOST to gnueabihf
- add an upgrade hook that nukes arm-generic installs that use the old CHOST
- see what blows up (some binpkgs might need regenerating if they hardcoded the tuple)
- once everything is smooth, convert all the other boards to gnueabihf
- drop armv7a-cros-linux-gnueabi everywhere
- drop USE=hardfp everywhere
- drop any hacks we have that rewrite gnueabi to gnueabi (like llvm)
- drop -mfloat-abi=hard everywhere (since that's the default)

once we figure out how to pull this off, we should also rename i686-pc-linux-gnu to i686-cros-linux-gnu.  it clashes with many distros that use i686-pc-linux-gnu for their system tuple.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/44ebc164a2eaea4b594a0ecf4c841dec19e3d253

commit 44ebc164a2eaea4b594a0ecf4c841dec19e3d253
Author: Yunlian Jiang <yunlian@google.com>
Date: Fri Oct 06 04:24:44 2017

set USE=hardfp for armv7a-cros-linux-gnueabihf-gcc

We need to configure armv7a-cros-linux-gnueabihf-gcc
with the flag --with-float=hard.

BUG=chromium:711369
TEST=armv7a-cros-linux-gnueabihf-gcc is configured
     with --with-float=hard

Change-Id: I6b00d2bade202f1929fdd5203128f049e54c90ea
Reviewed-on: https://chromium-review.googlesource.com/702645
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/44ebc164a2eaea4b594a0ecf4c841dec19e3d253/profiles/default/linux/package.use

Project Member

Comment 2 by bugdroid1@chromium.org, Oct 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/16c1a422af5adcf23b6147ebe21ce5784dc769e2

commit 16c1a422af5adcf23b6147ebe21ce5784dc769e2
Author: Yunlian Jiang <yunlian@google.com>
Date: Fri Oct 06 10:57:51 2017

add armv7a-cros-linux-gnueabihf suport.

This adds armv7a-cros-linux-gnueabihf to cros_setup_toolchain.
Currently it does not affect anything.

BUG=chromium:711369
TEST=cros_setup_toolchain --board daisy --create-package

Change-Id: I29ca133d5e9cc6b1412d97b6a9b708c61cc530b6
Reviewed-on: https://chromium-review.googlesource.com/699840
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/16c1a422af5adcf23b6147ebe21ce5784dc769e2/scripts/cros_setup_toolchains.py

Project Member

Comment 3 by bugdroid1@chromium.org, Oct 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/1b77ee498ef0c3b4d3a453374c286f4efbd515b8

commit 1b77ee498ef0c3b4d3a453374c286f4efbd515b8
Author: Yunlian Jiang <yunlian@google.com>
Date: Sat Oct 07 04:31:15 2017

build compiler-rt for armv7a-cros-linux-gnueabihf

It turns out we still need compiler-rt for armv7a-cros-linux-gnueabihf.
Previously, we remove it because it has installation conflict with
armv7a-cros-linux-gnueabi. However, we need this package to build the whole
armv7a-cros-linux-gnueabihf toolchain. The installation conflict problem
can be avoided if these two sets of toolchain does not appear in the
same board(chroot).

BUG=chromium:711369
TEST=None

Change-Id: Idef04f29667930bf612eb4d4d016f33ca9e66dec
Reviewed-on: https://chromium-review.googlesource.com/706065
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/1b77ee498ef0c3b4d3a453374c286f4efbd515b8/scripts/cros_setup_toolchains.py

Project Member

Comment 4 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/78faca2d39fa919a5610948ef1b0431bf52e1a23

commit 78faca2d39fa919a5610948ef1b0431bf52e1a23
Author: Yunlian Jiang <yunlian@google.com>
Date: Thu Oct 12 07:09:36 2017

compiler-rt: skip install stage for armv7a-cros-linux-gnueabihf

We want compiler-rt for armv7a-cros-linux-gnueabihf toolchain. But
it conflicts with the one from armv7a-cros-linux-gnueabi. As a
workaround, we do not install it for armv7a-cros-linux-gnueabihf but
we keep the dependency. To use the armv7a-cros-linux-gnueabihf
toolchain, we need the board include armv7a-cros-linux-gnueabi toolchain
as well.

BUG=chromium:711369
TEST=cbuildbot chromiumos-sdk with armv7a-cros-linux-gnueabihf added
     to a board with armv7a-cros-linux-gnueabi

Change-Id: I495fe0bd286e802f9c859d99be15cb9ed0998f68
Reviewed-on: https://chromium-review.googlesource.com/710859
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[rename] https://crrev.com/78faca2d39fa919a5610948ef1b0431bf52e1a23/sys-libs/compiler-rt/compiler-rt-5.0_pre305632-r7.ebuild

Cc: bcf@chromium.org
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/85c606aae820e29d6ccfa5589af365536eaf9ad1

commit 85c606aae820e29d6ccfa5589af365536eaf9ad1
Author: Yunlian Jiang <yunlian@google.com>
Date: Thu Oct 12 18:21:13 2017

build target by the alphabetical order

We want to replace armv7a-cros-linux-gnueabi with
armv7a-cros-linux-gnueabihf. During the transition, we have to keep
these two sets of toolchain at the same time. Because of install
conflict issue, we do not install compiler-rt for
armv7a-cros-linux-gnueabihf and use the one from
armv7a-cros-linux-gnueabi. This incurs implicit dependency between
armv7a-cros-linux-gnueabi and armv7a-cros-linux-gnueabihf. This
patch makes sure armv7a-cros-linux-gnueabi get installed before
armv7a-cros-linux-gnueabihf.

BUG=chromium:711369
TEST=cbuildbot chromiumos-sdk

Change-Id: I29d17456b18f6c8d608de4973aa5f5fecac1a869
Reviewed-on: https://chromium-review.googlesource.com/711595
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/85c606aae820e29d6ccfa5589af365536eaf9ad1/scripts/cros_setup_toolchains.py

Project Member

Comment 7 by bugdroid1@chromium.org, Oct 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/5e6686598c8a2c8299690309b7e41114bf611daa

commit 5e6686598c8a2c8299690309b7e41114bf611daa
Author: Yunlian Jiang <yunlian@google.com>
Date: Thu Oct 12 22:54:44 2017

arm64-generic: add armv7a-cros-linux-gnueabihf

We add armv7a-cros-linux-gnueabihf to arm64-generic to make SDK
builder produce binpkgs. Will remove this once the binpkgs for
armv7a-cros-linux-gnueabihf is built.

BUG=chromium:711369
TEST=None

Change-Id: I249680174ff5de6dcd1e53e3501baa06076307ba
Reviewed-on: https://chromium-review.googlesource.com/705474
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Commit-Queue: Yunlian Jiang <yunlian@chromium.org>
Trybot-Ready: Yunlian Jiang <yunlian@chromium.org>

[modify] https://crrev.com/5e6686598c8a2c8299690309b7e41114bf611daa/overlay-arm64-generic/toolchain.conf

Comment 8 by vapier@chromium.org, Oct 13 2017

a wrinkle: arm-generic is used as a binpkg provider for all arm boards.  if we change its CHOST, all other arm boards are implicitly impacted.  we might need to do a bottom-up conversion where we switch a leaf board (like spring or skate) first, and if everything looks good, switch all the rest at once.

also need to double check if portage will ignore binpkgs that don't have a matching CHOST.  if it does, that's what we want.  if it doesn't, we'll need to adjust things (perhaps changing portage to take that into account).
Project Member

Comment 9 by bugdroid1@chromium.org, Oct 15 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/4d63becb14f95291159978de7043f22419bcece6

commit 4d63becb14f95291159978de7043f22419bcece6
Author: Yunlian Jiang <yunlian@google.com>
Date: Sat Oct 14 04:55:22 2017

daisy: add armv7a-cros-linux-gnueabihf

We need to add armv7a-cros-linux-gnueabihf toolchain to daisy
so that we can test this toolchain on skate board.

BUG=chromium:711369
TEST=None

Change-Id: I1f2d72738a14913011d061b04caa2cb6c2665241
Reviewed-on: https://chromium-review.googlesource.com/719724
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/4d63becb14f95291159978de7043f22419bcece6/overlay-daisy/toolchain.conf

regarding #8, how can I change the CHOST for a particular board?
the CL https://chrome-internal-review.googlesource.com/c/chromeos/overlays/overlay-variant-daisy-skate-private/+/480197

changes CC, CXX, but it could not change CHOST.
CHOST is dictated by the first entry in toolchain.conf.  so re-order them so the hf one comes first.

mark it up to obscure trivia ;).
Project Member

Comment 12 by bugdroid1@chromium.org, Oct 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/7c4faf73808f67f7afcb06cc35890c378dfd6e10

commit 7c4faf73808f67f7afcb06cc35890c378dfd6e10
Author: Yunlian Jiang <yunlian@google.com>
Date: Tue Oct 17 20:02:52 2017

profile: disable hardened glibc for arm.

We disabled hardened glibc for
cross-armv7a-cros-linux-gnueabi, so we should disable it for
cross-armv7a-cros-linux-gnueabihf as well.
BUG=chromium:711369
TEST=None

Change-Id: I486afeba6641d013cb8ca352fa1f04a5aeea1100
Reviewed-on: https://chromium-review.googlesource.com/720070
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/7c4faf73808f67f7afcb06cc35890c378dfd6e10/profiles/default/linux/package.use.mask

Project Member

Comment 13 by bugdroid1@chromium.org, Oct 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/6da777097da0e1f3f0fd31c44d7b20fb25cd2ebb

commit 6da777097da0e1f3f0fd31c44d7b20fb25cd2ebb
Author: Yunlian Jiang <yunlian@google.com>
Date: Thu Oct 19 02:08:29 2017

gcc: make wrapper handle armv7a-cros-linux-gnueabihf

While we are moving arm32 abi from armv7a-cros-linux-gnueabi
to armv7a-cros-linux-gnueabihf, we want the sysroot wrapper to
handle both tuples.

BUG=chromium:711369
TEST=cbuildbot daisy-release

Change-Id: I9032a59366f5af28dfae7e28214e102c7c374f7b
Reviewed-on: https://chromium-review.googlesource.com/724179
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[rename] https://crrev.com/6da777097da0e1f3f0fd31c44d7b20fb25cd2ebb/sys-devel/gcc/gcc-4.9.2-r168.ebuild
[modify] https://crrev.com/6da777097da0e1f3f0fd31c44d7b20fb25cd2ebb/sys-devel/gcc/files/sysroot_wrapper.hardened.body

Components: Infra
Components: -Infra Infra>Client>ChromeOS
[It appears that a bunch of old cros issues bulk-added the "Infra" component recently, but they should probably be "Infra>Client>ChromeOS".]
Components: -Infra>Client>ChromeOS
Components: Tools>ChromeOS-Toolchain
Project Member

Comment 18 by bugdroid1@chromium.org, May 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/923d6ffaaa2a20c9bbab3ef2307395939cb73b19

commit 923d6ffaaa2a20c9bbab3ef2307395939cb73b19
Author: Yunlian Jiang <yunlian@google.com>
Date: Fri May 04 01:32:22 2018

add armv7a-cros-linux-gnueabihf to ARM overlays.

This pulls armv7a-cros-linux-gnueabihf toolchain to ARM boards.
Currently this does not has any effects, however, we will replace
armv7a-cros-linux-gnueabi with armv7a-cros-linux-gnueabihf in the
future.

BUG=chromium:711369
TEST=The armv7a-cros-linux-gnueabihf is downloaded when
     running ./setup_board --board elm

Change-Id: Ib155bd8e3a72ff76980b79b30b2d7944a5374e18
Reviewed-on: https://chromium-review.googlesource.com/1038664
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/overlay-peach/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/overlay-elm/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/overlay-acorn/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/overlay-arm-generic/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/overlay-variant-beaglebone-servo/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/baseboard-cheza/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/overlay-foster/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/overlay-nyan/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/overlay-sama5d3/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/chipset-mt8173/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/overlay-puppy/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/overlay-arm64-generic/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/overlay-beaglebone/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/overlay-arm64-llvmpipe/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/overlay-rainier/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/baseboard-gru/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/overlay-hana/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/overlay-tael/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/overlay-reptile/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/overlay-oak/toolchain.conf
[modify] https://crrev.com/923d6ffaaa2a20c9bbab3ef2307395939cb73b19/overlay-veyron/toolchain.conf

Project Member

Comment 19 by bugdroid1@chromium.org, May 7 2018

Project Member

Comment 20 by bugdroid1@chromium.org, May 7 2018

Project Member

Comment 21 by bugdroid1@chromium.org, May 7 2018

Project Member

Comment 22 by bugdroid1@chromium.org, May 7 2018

Project Member

Comment 23 by bugdroid1@chromium.org, May 7 2018

Project Member

Comment 24 by bugdroid1@chromium.org, May 7 2018

Project Member

Comment 25 by bugdroid1@chromium.org, May 7 2018

Project Member

Comment 26 by bugdroid1@chromium.org, May 7 2018

Project Member

Comment 27 by bugdroid1@chromium.org, May 7 2018

Project Member

Comment 28 by bugdroid1@chromium.org, May 7 2018

Project Member

Comment 29 by bugdroid1@chromium.org, May 8 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/chipset-x30-private/+/3f20064933866b746d22086519adc4c64bf6eccd

commit 3f20064933866b746d22086519adc4c64bf6eccd
Author: Yunlian Jiang <yunlian@google.com>
Date: Tue May 08 11:58:02 2018

Project Member

Comment 30 by bugdroid1@chromium.org, May 8 2018

Project Member

Comment 31 by bugdroid1@chromium.org, May 9 2018

Project Member

Comment 32 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/29962254d7e715f35df866956650b4925709b259

commit 29962254d7e715f35df866956650b4925709b259
Author: Yunlian Jiang <yunlian@google.com>
Date: Wed May 16 19:41:28 2018

compiler-rt: install for armv7a-cros-linux-gnueabihf only.

Now all the ARM boards have armv7a-cros-linux-gnueabihf and
armv7a-cros-linux-gnueabi toolchain. We can safely install
compiler-rt for armv7a-cros-linux-gnueabihf and skip the
installation for armv7a-cros-linux-gnueabi now.

CQ-DEPEND=CL:1056058
BUG=chromium:711369
TEST=chromiumos-sdk

Change-Id: Iadf7bad12a5ee6d3145a8dccd4d887899948f86c
Reviewed-on: https://chromium-review.googlesource.com/1056057
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[rename] https://crrev.com/29962254d7e715f35df866956650b4925709b259/sys-libs/compiler-rt/compiler-rt-7.0_pre328903-r3.ebuild

Project Member

Comment 33 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/4ff841776dc51bef52ca6b19d1deba7dbf9e16ef

commit 4ff841776dc51bef52ca6b19d1deba7dbf9e16ef
Author: Yunlian Jiang <yunlian@google.com>
Date: Wed May 16 19:41:29 2018

cros_setup_toolchain: build toolchains in reversed order.

CL:1056057 changed the dependency order between
armv7a-cros-linux-gnueabi and armv7a-cros-linux-gnueabihf toolchain.
Now armv7a-cros-linux-gnueabihf needs to be built before
armv7a-cros-linux-gnueabi, so we want to change the build order here.

CQ-DEPEND=CL:1056057
BUG=chromium:711369
TEST=chromiumos-sdk

Change-Id: Ia4cc9c8a2c87ce04f3a1fd31b7fbfc83374dd588
Reviewed-on: https://chromium-review.googlesource.com/1056058
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/4ff841776dc51bef52ca6b19d1deba7dbf9e16ef/scripts/cros_setup_toolchains.py

Project Member

Comment 34 by bugdroid1@chromium.org, May 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4f522e01e2856828612aec72e303d3b870a78515

commit 4f522e01e2856828612aec72e303d3b870a78515
Author: chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed May 16 22:42:12 2018

Roll src/third_party/chromite/ 5f638a109..4c1562dfd (3 commits)

https://chromium.googlesource.com/chromiumos/chromite.git/+log/5f638a1091fb..4c1562dfdeef

$ git log 5f638a109..4c1562dfd --date=short --no-merges --format='%ad %ae %s'
2018-05-14 shapiroc cbuildbot: Fix file check outside chroot
2018-05-04 bmgordon cros_test_lib: Refactor cros_build_lib mocks
2018-05-12 yunlian cros_setup_toolchain: build toolchains in reversed order.

Created with:
  roll-dep src/third_party/chromite
BUG= chromium:842834 , chromium:809634 ,chromium:711369


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: Icd8ebd153995e7b541c78dc08f8072239c16a140
Reviewed-on: https://chromium-review.googlesource.com/1062649
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#559319}
[modify] https://crrev.com/4f522e01e2856828612aec72e303d3b870a78515/DEPS

Project Member

Comment 35 by bugdroid1@chromium.org, May 21 2018

Project Member

Comment 36 by bugdroid1@chromium.org, May 22 2018

Project Member

Comment 37 by bugdroid1@chromium.org, May 22 2018

Project Member

Comment 38 by bugdroid1@chromium.org, May 30 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/third_party/qca-framework/+/40a62389e6830cb53f26e1df8577d738cbd57c91

commit 40a62389e6830cb53f26e1df8577d738cbd57c91
Author: Yunlian Jiang <yunlian@chromium.org>
Date: Wed May 30 04:22:45 2018

Project Member

Comment 39 by bugdroid1@chromium.org, Jun 1 2018

I'm trying to switch Mosys over to using Rust, and when I compile on whirlwind I get an error saying:

error: failed to run `rustc` to learn about target-specific information

Caused by:
  process didn't exit successfully: `rustc - --crate-name ___ --print=file-names --target armv7a-cros-linux-gnueabihf --crate-type bin --crate-type rlib` (exit code: 101)
--- stderr
error: Error loading target specification: Could not find specification for target "armv7a-cros-linux-gnueabihf"

It looks like this is caused by the name change in this bug. Once this bug is complete, we should be able to switch the Rust ebuild to the new name.

How far along is this bug?
I think we are close, currently the major issue is it breaks the emerge --usepkge when changing the CHOST.
As a workaround, we can install armv7a-cros-linux-gnueabihf for rust.
Cc: jclinton@chromium.org
Installing armv7a-cros-linux-gnueabihf sounds great! Thanks! How do we do that?
rmv7a-cros-linux-gnueabihf toolchain should be already installed on all the sysroots with arm toolchain. 

Comment 46 by za...@chromium.org, Jun 11 2018

There a few parts of the rust ebuild that special case the arm triple because of naming incongruities between us and the rest of upstream. Changing just the array you linked would likely not be sufficient.
Project Member

Comment 47 by bugdroid1@chromium.org, Jun 12 2018

Project Member

Comment 48 by bugdroid1@chromium.org, Jun 13 2018

Project Member

Comment 49 by bugdroid1@chromium.org, Jun 13 2018

Project Member

Comment 50 by bugdroid1@chromium.org, Jun 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/211a6dd1f072e6934664f3788850ffb0347e4fec

commit 211a6dd1f072e6934664f3788850ffb0347e4fec
Author: Yunlian Jiang <yunlian@google.com>
Date: Thu Jun 14 00:02:10 2018

rust: add armv7a-cros-linux-gnueabihf suport.

We added another arm toolchain armv7a-cros-linux-gnueabihf when we
try to rename the arm toolchain. Currenlty some boards have set
CHOST to armv7a-cros-linux-gnueabihf already. We need rust to
support this new toolchain too.

BUG=chromium:711369
TEST=cros chromimos-sdk-tryjob

Change-Id: I618c663a4cd6611a829fe033e0c2237fdc3d39e6
Reviewed-on: https://chromium-review.googlesource.com/1095476
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Zach Reizner <zachr@chromium.org>

[rename] https://crrev.com/211a6dd1f072e6934664f3788850ffb0347e4fec/dev-lang/rust/rust-1.26.0-r4.ebuild
[modify] https://crrev.com/211a6dd1f072e6934664f3788850ffb0347e4fec/dev-lang/rust/files/0002-add-target-armv7a-cros-linux.patch

Project Member

Comment 51 by bugdroid1@chromium.org, Jun 22 2018

Labels: merge-merged-chromeos-2.2.28
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/portage_tool/+/329c5bc7b2f6fda2f491c66d043dd71c7d6b1796

commit 329c5bc7b2f6fda2f491c66d043dd71c7d6b1796
Author: Yunlian Jiang <yunlian@google.com>
Date: Fri Jun 22 02:56:21 2018

ebuild: hack the chost check for armv7a-cros-linux-gnueabihf

We are in the process of rename armv7a-cros-linux-gnueabi to
armv7a-cros-linux-gnueabihf. See crbug.com/711369
We created two sets to toolchains, namely armv7a-cros-linux-gnueabi
and armv7a-cros-linux-gnueabihf, they are basically then same with
different names.
When changing the CHOST for one board from armv7a-cros-linux-gnueabi
to armv7a-cros-linux-gnueabihf, it failed on pre-cq. Because in the
build_package stage, it calls function VerifyBinpkg to verify that
an binary package exists for chromeos-chrome. The check requires the
CHOST from board configure and prebuilt packages are the same, and the
change broke that.
This patch silence the error to make pre-cq pass.

BUG=chromium:711369
TEST=emerge-daisy -G zlib succeeded with new CHOST set.

Change-Id: I6ae231ebc663b2afc0c3773418258daa4f78d984
Reviewed-on: https://chromium-review.googlesource.com/1055211
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/329c5bc7b2f6fda2f491c66d043dd71c7d6b1796/pym/portage/package/ebuild/config.py

Project Member

Comment 52 by bugdroid1@chromium.org, Jun 22 2018

Project Member

Comment 53 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/9956aac2548532f2c13f7e76ad4d5b962b8a076c

commit 9956aac2548532f2c13f7e76ad4d5b962b8a076c
Author: Yunlian Jiang <yunlian@google.com>
Date: Fri Jun 22 18:37:57 2018

nyan:  set CHOST to armv7a-cros-linux-gnueabihf

The sets the CHOST to armv7a-cros-linux-gnueabihf for nyan
board. It also sets default CC to armv7a-cros-linux-gnueabihf-clang
to test the new toolchain before rolling it to all the arm boards.

BUG=chromium:711369
TEST=cros tryjob -g nyan_big-release

Change-Id: If2d51f9bd99f4b90e30e380687efac6abe44e4f1
Reviewed-on: https://chromium-review.googlesource.com/1111648
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/9956aac2548532f2c13f7e76ad4d5b962b8a076c/overlay-nyan/toolchain.conf
[modify] https://crrev.com/9956aac2548532f2c13f7e76ad4d5b962b8a076c/overlay-nyan/make.conf

Project Member

Comment 54 by bugdroid1@chromium.org, Jun 22 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/09c89f00ee485dd3623e6dc6d9b0c93c365add2e

commit 09c89f00ee485dd3623e6dc6d9b0c93c365add2e
Author: Jonathan Brandmeyer <jbrandmeyer@chromium.org>
Date: Fri Jun 22 22:32:32 2018

Revert "nyan:  set CHOST to armv7a-cros-linux-gnueabihf"

This reverts commit 9956aac2548532f2c13f7e76ad4d5b962b8a076c.

Reason for revert: Broken nyan PreCQ

Original change's description:
> nyan:  set CHOST to armv7a-cros-linux-gnueabihf
> 
> The sets the CHOST to armv7a-cros-linux-gnueabihf for nyan
> board. It also sets default CC to armv7a-cros-linux-gnueabihf-clang
> to test the new toolchain before rolling it to all the arm boards.
> 
> BUG=chromium:711369
> TEST=cros tryjob -g nyan_big-release
> 
> Change-Id: If2d51f9bd99f4b90e30e380687efac6abe44e4f1
> Reviewed-on: https://chromium-review.googlesource.com/1111648
> Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
> Tested-by: Yunlian Jiang <yunlian@chromium.org>
> Reviewed-by: Mike Frysinger <vapier@chromium.org>

Bug: chromium:711369
Change-Id: Ifb2f0ddddbde172742617776d3af85a1841f82ae
Reviewed-on: https://chromium-review.googlesource.com/1112399
Trybot-Ready: Jonathan Brandmeyer <jbrandmeyer@chromium.org>
Reviewed-by: Jonathan Brandmeyer <jbrandmeyer@chromium.org>
Tested-by: Jonathan Brandmeyer <jbrandmeyer@chromium.org>

[modify] https://crrev.com/09c89f00ee485dd3623e6dc6d9b0c93c365add2e/overlay-nyan/toolchain.conf
[modify] https://crrev.com/09c89f00ee485dd3623e6dc6d9b0c93c365add2e/overlay-nyan/make.conf

Blockedon: 855981
Project Member

Comment 56 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/9024b7e15134a918aac48bbb6892c978ab26ef29

commit 9024b7e15134a918aac48bbb6892c978ab26ef29
Author: Yunlian Jiang <yunlian@google.com>
Date: Thu Sep 13 08:23:04 2018

arm-generic:  set CHOST to armv7a-cros-linux-gnueabihf

The sets the CHOST to armv7a-cros-linux-gnueabihf for arm-generic
board. It also sets default CC to armv7a-cros-linux-gnueabihf-clang
to test the new toolchain before rolling it to all the arm boards.

CQ-DEPEND=CL:1217486
BUG=chromium:711369
TEST=cros tryjob -g arm-generic-full-tryjob

Change-Id: I9716646eb52c0ebab221ca4995ebdadb41a7f3b2
Reviewed-on: https://chromium-review.googlesource.com/1214294
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/9024b7e15134a918aac48bbb6892c978ab26ef29/overlay-arm-generic/make.conf
[modify] https://crrev.com/9024b7e15134a918aac48bbb6892c978ab26ef29/overlay-arm-generic/toolchain.conf

Project Member

Comment 57 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f59f749b469e8206bc5df48b516b5025d6dbb13c

commit f59f749b469e8206bc5df48b516b5025d6dbb13c
Author: Yunlian Jiang <yunlian@google.com>
Date: Thu Sep 13 08:23:04 2018

generic_stages: temporarily ignore all target prebuilts.

Ignore the target prebuilts and rebuild packages from source.
We want to change the CHOST for arm-generic, this requires a
prebuilt package update.

This is a temporary CL. Revert this CL once in has participated in
a green CQ run. This process is documented at:

https://sites.google.com/a/google.com/chromeos/for-team-members/infrastructure/chromeos-admin/clear_binaries

CQ-DEPEND=CL:1214294
BUG=chromium:711369
TEST='./cbuildbot/run_tests' passed.

Change-Id: I0d93b4b34616b223e52145b8090312ae8662cb95
Reviewed-on: https://chromium-review.googlesource.com/1217486
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>

[modify] https://crrev.com/f59f749b469e8206bc5df48b516b5025d6dbb13c/lib/sysroot_lib.py
[modify] https://crrev.com/f59f749b469e8206bc5df48b516b5025d6dbb13c/cbuildbot/stages/build_stages_unittest.py
[modify] https://crrev.com/f59f749b469e8206bc5df48b516b5025d6dbb13c/cbuildbot/stages/generic_stages.py
[modify] https://crrev.com/f59f749b469e8206bc5df48b516b5025d6dbb13c/lib/config_lib.py
[modify] https://crrev.com/f59f749b469e8206bc5df48b516b5025d6dbb13c/config/config_dump.json

Project Member

Comment 58 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/bad0715c6f3c78ee7b9dbcf20d7d2814111bbaf9

commit bad0715c6f3c78ee7b9dbcf20d7d2814111bbaf9
Author: Yunlian Jiang <yunlian@chromium.org>
Date: Thu Sep 13 15:36:59 2018

Revert "generic_stages: temporarily ignore all target prebuilts."

This reverts commit f59f749b469e8206bc5df48b516b5025d6dbb13c.

Reason for revert: arm-generic-paladin has a green run after it lands

Original change's description:
> generic_stages: temporarily ignore all target prebuilts.
> 
> Ignore the target prebuilts and rebuild packages from source.
> We want to change the CHOST for arm-generic, this requires a
> prebuilt package update.
> 
> This is a temporary CL. Revert this CL once in has participated in
> a green CQ run. This process is documented at:
> 
> https://sites.google.com/a/google.com/chromeos/for-team-members/infrastructure/chromeos-admin/clear_binaries
> 
> CQ-DEPEND=CL:1214294
> BUG=chromium:711369
> TEST='./cbuildbot/run_tests' passed.
> 
> Change-Id: I0d93b4b34616b223e52145b8090312ae8662cb95
> Reviewed-on: https://chromium-review.googlesource.com/1217486
> Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
> Tested-by: Yunlian Jiang <yunlian@chromium.org>
> Reviewed-by: Lann Martin <lannm@chromium.org>

Bug: chromium:711369
Change-Id: I53fa7f5fe857c5ca275265a6aeb99341e78e2e32
Reviewed-on: https://chromium-review.googlesource.com/1224710
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
Commit-Queue: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>

[modify] https://crrev.com/bad0715c6f3c78ee7b9dbcf20d7d2814111bbaf9/lib/sysroot_lib.py
[modify] https://crrev.com/bad0715c6f3c78ee7b9dbcf20d7d2814111bbaf9/cbuildbot/stages/build_stages_unittest.py
[modify] https://crrev.com/bad0715c6f3c78ee7b9dbcf20d7d2814111bbaf9/cbuildbot/stages/generic_stages.py
[modify] https://crrev.com/bad0715c6f3c78ee7b9dbcf20d7d2814111bbaf9/lib/config_lib.py
[modify] https://crrev.com/bad0715c6f3c78ee7b9dbcf20d7d2814111bbaf9/config/config_dump.json

Project Member

Comment 59 by bugdroid1@chromium.org, Sep 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/d7d11650ca3794720a99d2003ce64df354edd743

commit d7d11650ca3794720a99d2003ce64df354edd743
Author: Yunlian Jiang <yunlian@chromium.org>
Date: Thu Sep 13 15:42:13 2018

Reland "generic_stages: temporarily ignore all target prebuilts."

This reverts commit bad0715c6f3c78ee7b9dbcf20d7d2814111bbaf9.

Reason for revert: We need a full CQ run to make the prebuilds
active.

Original change's description:
> Revert "generic_stages: temporarily ignore all target prebuilts."
> 
> This reverts commit f59f749b469e8206bc5df48b516b5025d6dbb13c.
> 
> Reason for revert: arm-generic-paladin has a green run after it lands
> 
> Original change's description:
> > generic_stages: temporarily ignore all target prebuilts.
> > 
> > Ignore the target prebuilts and rebuild packages from source.
> > We want to change the CHOST for arm-generic, this requires a
> > prebuilt package update.
> > 
> > This is a temporary CL. Revert this CL once in has participated in
> > a green CQ run. This process is documented at:
> > 
> > https://sites.google.com/a/google.com/chromeos/for-team-members/infrastructure/chromeos-admin/clear_binaries
> > 
> > CQ-DEPEND=CL:1214294
> > BUG=chromium:711369
> > TEST='./cbuildbot/run_tests' passed.
> > 
> > Change-Id: I0d93b4b34616b223e52145b8090312ae8662cb95
> > Reviewed-on: https://chromium-review.googlesource.com/1217486
> > Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
> > Tested-by: Yunlian Jiang <yunlian@chromium.org>
> > Reviewed-by: Lann Martin <lannm@chromium.org>
> 
> Bug: chromium:711369
> Change-Id: I53fa7f5fe857c5ca275265a6aeb99341e78e2e32
> Reviewed-on: https://chromium-review.googlesource.com/1224710
> Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
> Commit-Queue: Yunlian Jiang <yunlian@chromium.org>
> Tested-by: Yunlian Jiang <yunlian@chromium.org>

Bug: chromium:711369
Change-Id: Ife2f7117410853bf999b6991ad913d2eb3e8297d
Reviewed-on: https://chromium-review.googlesource.com/1224460
Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
Commit-Queue: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>

[modify] https://crrev.com/d7d11650ca3794720a99d2003ce64df354edd743/lib/sysroot_lib.py
[modify] https://crrev.com/d7d11650ca3794720a99d2003ce64df354edd743/cbuildbot/stages/build_stages_unittest.py
[modify] https://crrev.com/d7d11650ca3794720a99d2003ce64df354edd743/cbuildbot/stages/generic_stages.py
[modify] https://crrev.com/d7d11650ca3794720a99d2003ce64df354edd743/lib/config_lib.py
[modify] https://crrev.com/d7d11650ca3794720a99d2003ce64df354edd743/config/config_dump.json

Project Member

Comment 60 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/d3fd8707f32d5aec69f88135f761283168b15e0e

commit d3fd8707f32d5aec69f88135f761283168b15e0e
Author: Yunlian Jiang <yunlian@chromium.org>
Date: Fri Sep 14 22:13:23 2018

Revert "generic_stages: temporarily ignore all target prebuilts.""

This reverts commit d7d11650ca3794720a99d2003ce64df354edd743.

Reason for revert: commit queue finally becomes green 

Original change's description:
> Reland "generic_stages: temporarily ignore all target prebuilts."
> 
> This reverts commit bad0715c6f3c78ee7b9dbcf20d7d2814111bbaf9.
> 
> Reason for revert: We need a full CQ run to make the prebuilds
> active.
> 
> Original change's description:
> > Revert "generic_stages: temporarily ignore all target prebuilts."
> > 
> > This reverts commit f59f749b469e8206bc5df48b516b5025d6dbb13c.
> > 
> > Reason for revert: arm-generic-paladin has a green run after it lands
> > 
> > Original change's description:
> > > generic_stages: temporarily ignore all target prebuilts.
> > > 
> > > Ignore the target prebuilts and rebuild packages from source.
> > > We want to change the CHOST for arm-generic, this requires a
> > > prebuilt package update.
> > > 
> > > This is a temporary CL. Revert this CL once in has participated in
> > > a green CQ run. This process is documented at:
> > > 
> > > https://sites.google.com/a/google.com/chromeos/for-team-members/infrastructure/chromeos-admin/clear_binaries
> > > 
> > > CQ-DEPEND=CL:1214294
> > > BUG=chromium:711369
> > > TEST='./cbuildbot/run_tests' passed.
> > > 
> > > Change-Id: I0d93b4b34616b223e52145b8090312ae8662cb95
> > > Reviewed-on: https://chromium-review.googlesource.com/1217486
> > > Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
> > > Tested-by: Yunlian Jiang <yunlian@chromium.org>
> > > Reviewed-by: Lann Martin <lannm@chromium.org>
> > 
> > Bug: chromium:711369
> > Change-Id: I53fa7f5fe857c5ca275265a6aeb99341e78e2e32
> > Reviewed-on: https://chromium-review.googlesource.com/1224710
> > Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
> > Commit-Queue: Yunlian Jiang <yunlian@chromium.org>
> > Tested-by: Yunlian Jiang <yunlian@chromium.org>
> 
> Bug: chromium:711369
> Change-Id: Ife2f7117410853bf999b6991ad913d2eb3e8297d
> Reviewed-on: https://chromium-review.googlesource.com/1224460
> Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
> Commit-Queue: Yunlian Jiang <yunlian@chromium.org>
> Tested-by: Yunlian Jiang <yunlian@chromium.org>

Bug: chromium:711369
Change-Id: I45073abf54598bffc7232fb2e3d48418361df858
Reviewed-on: https://chromium-review.googlesource.com/1226175
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Trybot-Ready: Yunlian Jiang <yunlian@chromium.org>

[modify] https://crrev.com/d3fd8707f32d5aec69f88135f761283168b15e0e/lib/sysroot_lib.py
[modify] https://crrev.com/d3fd8707f32d5aec69f88135f761283168b15e0e/cbuildbot/stages/build_stages_unittest.py
[modify] https://crrev.com/d3fd8707f32d5aec69f88135f761283168b15e0e/cbuildbot/stages/generic_stages.py
[modify] https://crrev.com/d3fd8707f32d5aec69f88135f761283168b15e0e/lib/config_lib.py
[modify] https://crrev.com/d3fd8707f32d5aec69f88135f761283168b15e0e/config/config_dump.json

Project Member

Comment 61 by bugdroid1@chromium.org, Sep 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/29341f59e9d397180be0b0118745b11528dd6a43

commit 29341f59e9d397180be0b0118745b11528dd6a43
Author: Yunlian Jiang <yunlian@google.com>
Date: Sat Sep 15 19:56:25 2018

nyan:  set CHOST to armv7a-cros-linux-gnueabihf

The sets the CHOST to armv7a-cros-linux-gnueabihf for nyan
board. It also sets default CC to armv7a-cros-linux-gnueabihf-clang
to test the new toolchain before rolling it to all the arm boards.

BUG=chromium:711369
TEST=cros tryjob -g nyan_big-release

Change-Id: Ie6081bd168b89759a387a9046b410e6417ddfe20
Reviewed-on: https://chromium-review.googlesource.com/1147202
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/29341f59e9d397180be0b0118745b11528dd6a43/overlay-nyan/toolchain.conf
[modify] https://crrev.com/29341f59e9d397180be0b0118745b11528dd6a43/overlay-nyan/make.conf

Project Member

Comment 62 by bugdroid1@chromium.org, Sep 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/c9b2e8d4b3db68eb8e097330dad4aab3d5de4a97

commit c9b2e8d4b3db68eb8e097330dad4aab3d5de4a97
Author: Yunlian Jiang <yunlian@google.com>
Date: Sun Sep 16 23:19:25 2018

daisy:  set CHOST to armv7a-cros-linux-gnueabihf

The sets the CHOST to armv7a-cros-linux-gnueabihf for daisy
board. It also sets default CC to armv7a-cros-linux-gnueabihf-clang
to test the new toolchain before rolling it to all the arm boards.

BUG=chromium:711369
TEST=cros tryjob -g daisy-release

Change-Id: Icd9a4924cd07f1813d636f2d418ef0abf6b544b7
Reviewed-on: https://chromium-review.googlesource.com/1226929
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/c9b2e8d4b3db68eb8e097330dad4aab3d5de4a97/overlay-daisy/make.conf
[modify] https://crrev.com/c9b2e8d4b3db68eb8e097330dad4aab3d5de4a97/overlay-daisy/toolchain.conf

Blockedon: 884949
Project Member

Comment 64 by bugdroid1@chromium.org, Sep 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/17a3ba36b2f30b1fc6c33915ea9cbc81b632f884

commit 17a3ba36b2f30b1fc6c33915ea9cbc81b632f884
Author: Yunlian Jiang <yunlian@google.com>
Date: Wed Sep 19 19:18:16 2018

arm: set default compiler to armv7a-cros-linux-gnueabihf-clang

This sets the default compiler to
armv7a-cros-linux-gnueabihf-clang for arm boards.

BUG=chromium:711369
TEST=cros tryjob kevin-release gale-release

Change-Id: I1669c782f5c905488b2a4478a8d4bf73842db91c
Reviewed-on: https://chromium-review.googlesource.com/1226187
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/17a3ba36b2f30b1fc6c33915ea9cbc81b632f884/profiles/features/llvm/arm/make.defaults

Project Member

Comment 65 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/e20824820500f7034a82c3aa4f81aa5ef9440664

commit e20824820500f7034a82c3aa4f81aa5ef9440664
Author: Yunlian Jiang <yunlian@google.com>
Date: Fri Sep 21 04:30:05 2018

arm-generic: remove armv7a-cros-linux-gnueabi

This removes armv7a-cros-linux-gnueabi from arm-generic.
It also unset CC in make.conf because we have set the CC
in the arm profile already.

BUG=chromium:711369
TEST=cros tryjob arm-generic-full-tryjob

Change-Id: Ic14a18220ab0bcd6a889104a83030f0621be9e97
Reviewed-on: https://chromium-review.googlesource.com/1234301
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/e20824820500f7034a82c3aa4f81aa5ef9440664/overlay-arm-generic/make.conf
[modify] https://crrev.com/e20824820500f7034a82c3aa4f81aa5ef9440664/overlay-arm-generic/toolchain.conf

Project Member

Comment 66 by bugdroid1@chromium.org, Sep 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/fcfcdf438e275d53d0934091ba23e1c2911c48dc

commit fcfcdf438e275d53d0934091ba23e1c2911c48dc
Author: Yunlian Jiang <yunlian@google.com>
Date: Fri Sep 21 04:30:06 2018

veyron: set default toolchain to armv7a-cros-linux-gnueabihf

This removes  armv7a-cros-linux-gnueabi toolchain from veyron
and sets the default one to armv7a-cros-linux-gnueabihf

BUG=chromium:711369
TEST=cros tryjob veyron_jaq-release veyron_minnie-paladin

Change-Id: I153c94ec5dbc312fb2045373a35bc95dd5f975e6
Reviewed-on: https://chromium-review.googlesource.com/1234302
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/fcfcdf438e275d53d0934091ba23e1c2911c48dc/overlay-veyron/toolchain.conf

Project Member

Comment 67 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/68bbfe8c28648b00f005e5eda81115b1c0f5921c

commit 68bbfe8c28648b00f005e5eda81115b1c0f5921c
Author: Yunlian Jiang <yunlian@google.com>
Date: Sat Sep 22 02:50:14 2018

daisy: drop armv7a-cros-linux-gnueabi toolchain

This drops armv7a-cros-linux-gnueabi toolchain from daisy board.
It also removes the settings of CC because we have done it in
the arm profile.

BUG=chromium:711369
TEST=cros tryjob -g daisy-release-tryjob

Change-Id: I2c2c9d3b03f81696d9b75d41fd329e5c33faa6a8
Reviewed-on: https://chromium-review.googlesource.com/1238874
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/68bbfe8c28648b00f005e5eda81115b1c0f5921c/overlay-daisy/make.conf
[modify] https://crrev.com/68bbfe8c28648b00f005e5eda81115b1c0f5921c/overlay-daisy/toolchain.conf

Project Member

Comment 68 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/7f9102eba37951cbd9f1c3252ed12dbb7a7436c0

commit 7f9102eba37951cbd9f1c3252ed12dbb7a7436c0
Author: Yunlian Jiang <yunlian@google.com>
Date: Sat Sep 22 02:50:19 2018

chipset-rk3399: Set the toolchain to armv7a-cros-linux-gnueabihf

This sets the toolchain for chipset rk3399  to
armv7a-cros-linux-gnueabihf

BUG=chromium:711369
TEST=cros tryjob gru-release-tryjob

Change-Id: I32d5b602f2c4ca12f4172a0700d25749d09934a2
Reviewed-on: https://chromium-review.googlesource.com/1238877
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/7f9102eba37951cbd9f1c3252ed12dbb7a7436c0/chipset-rk3399/toolchain.conf

Project Member

Comment 69 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/80f2cd022fd3ac09000526b57b6f5d35ce6d4785

commit 80f2cd022fd3ac09000526b57b6f5d35ce6d4785
Author: Yunlian Jiang <yunlian@google.com>
Date: Sat Sep 22 02:50:15 2018

arm64-llvmpipe: set the toolchain to armv7a-cros-linux-gnueabihf

This sets the toolchain for arm64-llvmpipe to
armv7a-cros-linux-gnueabihf

BUG=chromium:711369
TEST=cros tryjob arm64-llvmpipe-full-tryjob

Change-Id: I6200b317321e947eb3c4f77562150077c77099d6
Reviewed-on: https://chromium-review.googlesource.com/1238881
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/80f2cd022fd3ac09000526b57b6f5d35ce6d4785/overlay-arm64-llvmpipe/toolchain.conf

Project Member

Comment 70 by bugdroid1@chromium.org, Sep 22

Project Member

Comment 71 by bugdroid1@chromium.org, Sep 22

Project Member

Comment 72 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/381a087dddc1e4b85e5a7bba5e2df3bcfc14b26f

commit 381a087dddc1e4b85e5a7bba5e2df3bcfc14b26f
Author: Yunlian Jiang <yunlian@google.com>
Date: Sat Sep 22 15:30:09 2018

nyan: remove CC=armv7a-cros-linux-gnueabihf-clang

We have set CC=armv7a-cros-linux-gnueabihf-clang for all the arm boards,
so there is no need to set it in make.conf for nyan now.

BUG=chromium:711369
TEST=cros tryjob -g nyan_big-release

Change-Id: I67e6f74bc00b254552444937290d2e69deb1e5e4
Reviewed-on: https://chromium-review.googlesource.com/1238873
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/381a087dddc1e4b85e5a7bba5e2df3bcfc14b26f/overlay-nyan/make.conf

Project Member

Comment 73 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/8d275c0be3c09ac4fdc0ea1f8c491713db4025dc

commit 8d275c0be3c09ac4fdc0ea1f8c491713db4025dc
Author: Yunlian Jiang <yunlian@google.com>
Date: Sat Sep 22 15:30:12 2018

chipset-qc845: set toolchain to armv7a-cros-linux-gnueabihf

This sets the toolchain for chipset-qc845 to
armv7a-cros-linux-gnueabihf

BUG=chromium:711369
TEST=cros tryjob cheza-release-tryjob

Change-Id: I0d77700352950785c44f833fdce30f11f7c09432
Reviewed-on: https://chromium-review.googlesource.com/1238876
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/8d275c0be3c09ac4fdc0ea1f8c491713db4025dc/chipset-qc845/toolchain.conf

Project Member

Comment 74 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/90a79998b8361e74c669ed2bf9ee8de672e38a9e

commit 90a79998b8361e74c669ed2bf9ee8de672e38a9e
Author: Yunlian Jiang <yunlian@google.com>
Date: Sat Sep 22 15:30:11 2018

beaglebone: set toolchain to armv7a-cros-linux-gnueabihf

This sets the toolchain for beaglebone to
armv7a-cros-linux-gnueabihf

BUG=chromium:711369
TEST=cros tryjob beaglebone-release

Change-Id: I4bfb4faf72c7351db1fe8d221d1ac0dea24fa6f4
Reviewed-on: https://chromium-review.googlesource.com/1238878
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/90a79998b8361e74c669ed2bf9ee8de672e38a9e/overlay-variant-beaglebone-servo/toolchain.conf
[modify] https://crrev.com/90a79998b8361e74c669ed2bf9ee8de672e38a9e/overlay-beaglebone/toolchain.conf

Project Member

Comment 75 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/414d01fbe200bbf5d316886c1820200af415de45

commit 414d01fbe200bbf5d316886c1820200af415de45
Author: Yunlian Jiang <yunlian@google.com>
Date: Sat Sep 22 15:30:06 2018

overlay: change toolchain for acorn, reptile and sama5d3

This sets the toolchain to armv7a-cros-linux-gnueabihf for
acorn, reptile and sama5d3.

BUG=chromium:711369
TEST=None (there is no correspoding boards in cros tryjob)

Change-Id: If71a1d4b769db50e26469cda3e2ea4aa7ac15d1f
Reviewed-on: https://chromium-review.googlesource.com/1238879
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/414d01fbe200bbf5d316886c1820200af415de45/overlay-reptile/toolchain.conf
[modify] https://crrev.com/414d01fbe200bbf5d316886c1820200af415de45/overlay-sama5d3/toolchain.conf
[modify] https://crrev.com/414d01fbe200bbf5d316886c1820200af415de45/overlay-acorn/toolchain.conf

Project Member

Comment 76 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/6d442e1a94f5b55fb03ee806ea2c4ab7793b2cdf

commit 6d442e1a94f5b55fb03ee806ea2c4ab7793b2cdf
Author: Yunlian Jiang <yunlian@google.com>
Date: Sat Sep 22 15:30:12 2018

tael: Set the toolchain to armv7a-cros-linux-gnueabihf

This sets the toolchain for tael to
armv7a-cros-linux-gnueabihf

BUG=chromium:711369
TEST=cros tryjob tael-full-tryjob

Change-Id: I920444bb070fef7aebdd58355a5761bc11b6f33c
Reviewed-on: https://chromium-review.googlesource.com/1238880
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/6d442e1a94f5b55fb03ee806ea2c4ab7793b2cdf/overlay-tael/toolchain.conf

Project Member

Comment 77 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/ff6b683f6e87262e8f455a5c72e13a9d40225933

commit ff6b683f6e87262e8f455a5c72e13a9d40225933
Author: Yunlian Jiang <yunlian@google.com>
Date: Sat Sep 22 15:30:04 2018

overlay: change toolchain for foster, puppy

This sets the toolchain to armv7a-cros-linux-gnueabihf for
foster, puppy.

BUG=chromium:711369
TEST=None (there is no correspoding boards in cros tryjob)

Change-Id: I28b3122ecb8311fd1c6de4a0b30b0ce342132c8d
Reviewed-on: https://chromium-review.googlesource.com/1238882
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/ff6b683f6e87262e8f455a5c72e13a9d40225933/overlay-foster/toolchain.conf
[modify] https://crrev.com/ff6b683f6e87262e8f455a5c72e13a9d40225933/overlay-puppy/toolchain.conf

Project Member

Comment 78 by bugdroid1@chromium.org, Sep 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/db5470495b9a395174f1d7069166cdd5daef14e8

commit db5470495b9a395174f1d7069166cdd5daef14e8
Author: Yunlian Jiang <yunlian@google.com>
Date: Sat Sep 22 15:30:09 2018

peach: Set the toolchain to armv7a-cros-linux-gnueabihf

This sets the toolchain for peach to
armv7a-cros-linux-gnueabihf

BUG=chromium:711369
TEST=cros tryjob peach_pit-release-tryjob

Change-Id: Ia69cac8fa107fddc9b08c339351c4347efd2e9b4
Reviewed-on: https://chromium-review.googlesource.com/1238883
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/db5470495b9a395174f1d7069166cdd5daef14e8/overlay-peach/toolchain.conf

Project Member

Comment 79 by bugdroid1@chromium.org, Sep 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/0a63e8efdd93ba7342b8bbff202e29b18ce4249f

commit 0a63e8efdd93ba7342b8bbff202e29b18ce4249f
Author: Yunlian Jiang <yunlian@google.com>
Date: Sun Sep 23 20:10:05 2018

chipset-mt8173: Set the toolchain to armv7a-cros-linux-gnueabihf

This sets the toolchain for chipset-mt8173 to
armv7a-cros-linux-gnueabihf

BUG=chromium:711369
TEST=cros tryjob oak-release

Change-Id: Iac9dda924226bd41428dac7430aec9407e382a43
Reviewed-on: https://chromium-review.googlesource.com/1238875
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/0a63e8efdd93ba7342b8bbff202e29b18ce4249f/chipset-mt8173/toolchain.conf

Project Member

Comment 80 by bugdroid1@chromium.org, Sep 24

Project Member

Comment 81 by bugdroid1@chromium.org, Sep 24

Project Member

Comment 82 by bugdroid1@chromium.org, Sep 24

Project Member

Comment 83 by bugdroid1@chromium.org, Sep 24

Project Member

Comment 84 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/a374d2bdc5266fede2c1b37b34de5eebf51b1566

commit a374d2bdc5266fede2c1b37b34de5eebf51b1566
Author: Yunlian Jiang <yunlian@google.com>
Date: Wed Sep 26 03:41:04 2018

chipset-mt8183: Set the toolchain to armv7a-cros-linux-gnueabihf

This sets the toolchain for chipset-mt8183 to
armv7a-cros-linux-gnueabihf

BUG=chromium:711369
TEST=cros tryjob kukui-full-tryjob

Change-Id: I1cd7250791ecbb6873430bd67bbd7a3ab9418f54
Reviewed-on: https://chromium-review.googlesource.com/1240453
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/a374d2bdc5266fede2c1b37b34de5eebf51b1566/chipset-mt8183/toolchain.conf

Project Member

Comment 85 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/1416476fde6b485bede50db1e1e00f04a934906a

commit 1416476fde6b485bede50db1e1e00f04a934906a
Author: Yunlian Jiang <yunlian@google.com>
Date: Wed Sep 26 03:41:01 2018

libpayload: set ARM tool to armv7a-cros-linux-gnueabihf

We are renaming ARM32 toolchain from armv7a-cros-linux-gnueabi
to armv7a-cros-linux-gnueabihf, so we need to change the name of
arm toolchain here accordingly.

This does not have any functional change since we have USE=coreboot-sdk
set already.

BUG=chromium:711369
TEST=emerge-kevin libpayload

Change-Id: Iad0236168618e76235c944d17ac474d5522147d5
Reviewed-on: https://chromium-review.googlesource.com/1241477
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/1416476fde6b485bede50db1e1e00f04a934906a/sys-boot/libpayload/libpayload-9999.ebuild

Project Member

Comment 86 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/6db2b0231cce4546d357d985549d06c5b719df6b

commit 6db2b0231cce4546d357d985549d06c5b719df6b
Author: Yunlian Jiang <yunlian@google.com>
Date: Wed Sep 26 03:41:01 2018

coreboot: set ARM tool to armv7a-cros-linux-gnueabihf

We are renaming ARM32 toolchain from armv7a-cros-linux-gnueabi
to armv7a-cros-linux-gnueabihf, so we need to change the name of
arm toolchain here accordingly.

This does not have any functional change since we have USE=coreboot-sdk
set already.

BUG=chromium:711369
TEST=emerge-kevin coreboot

Change-Id: Id1955a7195fdf69f9d1ce8d14e32ddbd1b828bf2
Reviewed-on: https://chromium-review.googlesource.com/1242434
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Patrick Georgi <pgeorgi@chromium.org>

[modify] https://crrev.com/6db2b0231cce4546d357d985549d06c5b719df6b/sys-boot/coreboot/coreboot-9999.ebuild

Project Member

Comment 87 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/vboot_reference/+/f55573cee45f0392806333166cd040c99825e488

commit f55573cee45f0392806333166cd040c99825e488
Author: Yunlian Jiang <yunlian@google.com>
Date: Wed Sep 26 17:32:43 2018

vboot_reference: set CC=armv7a-cros-linux-gnueabihf-gcc for ARM

We want to drop armv7a-cros-linux-gnueabi toolchain, so we need
to use armv7a-cros-linux-gnueabihf-gcc instead.

BRANCH=None
BUG=chromium:711369
TEST=emerge-kevin vboot_reference

Change-Id: Ie6831079162916eb11e98da3aecdcd8c0bd0d82d
Reviewed-on: https://chromium-review.googlesource.com/1241856
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/f55573cee45f0392806333166cd040c99825e488/Makefile

Project Member

Comment 88 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3f78f82218968ed90bb296f0bb7d6d8ff30858c7

commit 3f78f82218968ed90bb296f0bb7d6d8ff30858c7
Author: Yunlian Jiang <yunlian@google.com>
Date: Wed Sep 26 17:33:19 2018

iozone: set ctarget=armv7a-cros-linux-gnueabihf for ARM

This change the ctarget from armv7a-cros-linux-gnueabi to
armv7a-cros-linux-gnueabihf for ARM as we are changing toolchain
names for ARM32.

BUG=chromium:711369
TEST=None

Change-Id: I4214138ad71fbe77576fbff873c6958e250e760b
Reviewed-on: https://chromium-review.googlesource.com/1241542
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/3f78f82218968ed90bb296f0bb7d6d8ff30858c7/client/tests/iozone/iozone.py

Project Member

Comment 89 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/crosvm/+/610fa31a0b03b9482a14f94e302a3dce45ecd2be

commit 610fa31a0b03b9482a14f94e302a3dce45ecd2be
Author: Yunlian Jiang <yunlian@google.com>
Date: Wed Sep 26 17:33:18 2018

crosvm: set ARM_TRIPLE to armv7a-cros-linux-gnueabihf

This changes ARM_TRIPLE to armv7a-cros-linux-gnueabihf because we are
renaming the abi from armv7a-cros-linux-gnueabi to armv7a-cros-linux-gnueabihf

BUG=chromium:711369
TEST=FEATURES="test" emerge-kevin crosvm

Change-Id: I4b4352f7cba47ba6492e733dd1d16796dadd3275
Reviewed-on: https://chromium-review.googlesource.com/1241538
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Chirantan Ekbote <chirantan@chromium.org>

[modify] https://crrev.com/610fa31a0b03b9482a14f94e302a3dce45ecd2be/build_test.py

Project Member

Comment 90 by bugdroid1@chromium.org, Sep 28

Project Member

Comment 91 by bugdroid1@chromium.org, Sep 28

Project Member

Comment 92 by bugdroid1@chromium.org, Sep 28

Project Member

Comment 93 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/b54e42c61263fd299a3ca458c13936ad6b987506

commit b54e42c61263fd299a3ca458c13936ad6b987506
Author: Yunlian Jiang <yunlian@google.com>
Date: Fri Sep 28 02:45:12 2018

build_go: change ABI name for ARM32

This changes ABI name from  armv7a-cros-linux-gnueabi to
armv7a-cros-linux-gnueabihf.

BUG=chromium:711369
TEST=build_go succeeds.

Change-Id: I6e7f1619e73fd70135c6e1e1cc787284d157f18f
Reviewed-on: https://chromium-review.googlesource.com/1246224
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/b54e42c61263fd299a3ca458c13936ad6b987506/go/chromeos/push_glibc
[modify] https://crrev.com/b54e42c61263fd299a3ca458c13936ad6b987506/go/chromeos/go_elm32
[modify] https://crrev.com/b54e42c61263fd299a3ca458c13936ad6b987506/go/chromeos/build_go

Project Member

Comment 94 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/bda291a9e83c1878676828c31c4074be2cbb1f13

commit bda291a9e83c1878676828c31c4074be2cbb1f13
Author: Yunlian Jiang <yunlian@google.com>
Date: Fri Sep 28 02:45:18 2018

rust: drop armv7a-cros-linux-gnueabi support

No arm board is using armv7a-cros-linux-gnueabi toolchain now, so
we can drop the armv7a-cros-linux-gnueabi support too.

BUG=chromium:711369
TEST=cros tryjob chromiumos-sdk-tryjob

Change-Id: Iae9efa6003c802e5f1757cf809e9ffb827d800f4
Reviewed-on: https://chromium-review.googlesource.com/1246277
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/bda291a9e83c1878676828c31c4074be2cbb1f13/dev-lang/rust/files/0001-add-target-armv7a-cros-linux.patch
[rename] https://crrev.com/bda291a9e83c1878676828c31c4074be2cbb1f13/dev-lang/rust/rust-1.29.0-r1.ebuild

Project Member

Comment 95 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/9cb5133c696e2a1ec6a2b3f9dd44da55da48d2db

commit 9cb5133c696e2a1ec6a2b3f9dd44da55da48d2db
Author: Yunlian Jiang <yunlian@google.com>
Date: Fri Sep 28 02:44:32 2018

native_Benchmarks: change default toolchain for ARM

This changes the ARM default toolchain from
armv7a-cros-linux-gnueabi-* to armv7a-cros-linux-gnueabihf-* because
we want to deprecate the armv7a-cros-linux-gnueabi toolchain.

BUG=chromium:711369
TEST=test_that --board kevin native_Benchmarks

Change-Id: I2daab799baf6914dd0ed7fee10afbaf06f226c5d
Reviewed-on: https://chromium-review.googlesource.com/1246466
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/9cb5133c696e2a1ec6a2b3f9dd44da55da48d2db/server/site_tests/native_Benchmarks/v8.py
[modify] https://crrev.com/9cb5133c696e2a1ec6a2b3f9dd44da55da48d2db/server/site_tests/native_Benchmarks/webm.py

Project Member

Comment 96 by bugdroid1@chromium.org, Sep 28

Project Member

Comment 97 by bugdroid1@chromium.org, Sep 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/chameleon/+/8eba23f5419f5e491692eed20fb3edb69f5b0c4e

commit 8eba23f5419f5e491692eed20fb3edb69f5b0c4e
Author: Yunlian Jiang <yunlian@google.com>
Date: Fri Sep 28 20:34:39 2018

chameleon: set CC=armv7a-cros-linux-gnueabihf-gcc for ARM

We want to drop armv7a-cros-linux-gnueabi toolchain, so we need
to use armv7a-cros-linux-gnueabihf-gcc instead.

BUG=chromium:711369
TEST=emerge-kevin chameleon

Change-Id: I4d14dd3a73b61d1d573c20233373873d43275017
Reviewed-on: https://chromium-review.googlesource.com/1241851
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Yu-Hsuan Hsu <yuhsuan@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>
Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org>

[modify] https://crrev.com/8eba23f5419f5e491692eed20fb3edb69f5b0c4e/Makefile

Project Member

Comment 98 by bugdroid1@chromium.org, Sep 29

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tast/+/0028613a1272a3f70b498770ef2348bf4fbf1c97

commit 0028613a1272a3f70b498770ef2348bf4fbf1c97
Author: Yunlian Jiang <yunlian@google.com>
Date: Sat Sep 29 11:27:35 2018

tast: change the name of 'go' for ARM

We want to drop armv7a-cros-linux-gnueabi toolchain, so we need
to use armv7a-cros-linux-gnueabihf-go instead.

BUG=chromium:711369
TEST=None

Change-Id: I98d298854f22335b136fe2c30c165193341945f7
Reviewed-on: https://chromium-review.googlesource.com/1252357
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Dan Erat <derat@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/0028613a1272a3f70b498770ef2348bf4fbf1c97/src/chromiumos/cmd/tast/build/build.go

Project Member

Comment 99 by bugdroid1@chromium.org, Oct 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/portage_tool/+/67da59454d0b70c97c01494bd228211a2814a335

commit 67da59454d0b70c97c01494bd228211a2814a335
Author: Yunlian Jiang <yunlian@chromium.org>
Date: Wed Oct 17 12:55:11 2018

Revert "ebuild: hack the chost check for armv7a-cros-linux-gnueabihf"

This reverts commit 329c5bc7b2f6fda2f491c66d043dd71c7d6b1796.

Reason for revert: We have finished the transition for all the live board and we just cleared the prebuilts, so this can be reverted now.

Original change's description:
> ebuild: hack the chost check for armv7a-cros-linux-gnueabihf
>
> We are in the process of rename armv7a-cros-linux-gnueabi to
> armv7a-cros-linux-gnueabihf. See crbug.com/711369
> We created two sets to toolchains, namely armv7a-cros-linux-gnueabi
> and armv7a-cros-linux-gnueabihf, they are basically then same with
> different names.
> When changing the CHOST for one board from armv7a-cros-linux-gnueabi
> to armv7a-cros-linux-gnueabihf, it failed on pre-cq. Because in the
> build_package stage, it calls function VerifyBinpkg to verify that
> an binary package exists for chromeos-chrome. The check requires the
> CHOST from board configure and prebuilt packages are the same, and the
> change broke that.
> This patch silence the error to make pre-cq pass.
>
> BUG=chromium:711369
> TEST=emerge-daisy -G zlib succeeded with new CHOST set.
>
> Change-Id: I6ae231ebc663b2afc0c3773418258daa4f78d984
> Reviewed-on: https://chromium-review.googlesource.com/1055211
> Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
> Tested-by: Yunlian Jiang <yunlian@chromium.org>
> Reviewed-by: Yunlian Jiang <yunlian@chromium.org>
> Reviewed-by: Mike Frysinger <vapier@chromium.org>

Bug: chromium:711369
Change-Id: I2480113073fe5e15d5ed2f2ea96f05c8e9538b9d
Reviewed-on: https://chromium-review.googlesource.com/1283434
Commit-Ready: Yunlian Jiang <yunlian@chromium.org>
Tested-by: Yunlian Jiang <yunlian@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/67da59454d0b70c97c01494bd228211a2814a335/pym/portage/package/ebuild/config.py

Owner: llozano@chromium.org
Things left:
1) make sure other toolchain users are using tools with new ABI name
2) remove armv7a-cros-linux-gnueabi from overlay/chipset-mt8183. (This would remove the toolchain from sdk builder)
3) drop USE=hardfp everywhere
4) drop any hacks we have that rewrite gnueabi to gnueabi (like llvm, compiler wrapper)
5) drop -mfloat-abi=hard everywhere (since that's the default)

Sign in to add a comment