The NextAction date has arrived: 2017-05-20

10.3.2 appears to have begun deployment; I got offers for it on my iPads this week.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/927047b0999e1fa6c164d581bdd5ec3b0e4d1f64

commit 927047b0999e1fa6c164d581bdd5ec3b0e4d1f64
Author: elawrence <elawrence@chromium.org>
Date: Thu Jun 15 19:59:29 2017

Remove workaround for strikethrough text in iOS omnibox

iOS 10.3 introduced a regression in rendering of strings with the
attribute NSStrikethroughStyleAttributeName applied to a subrange of
the string. For  crbug.com/699702 , we introduced a workaround that is
no longer needed as of iOS 10.3.2. We will remove that workaround now
that iOS 10.3.2 has released.

BUG= 711367 

TEST=https://expired.badssl.com. Examine https: text in the omnibox,
it should have a line through it.

Review-Url: https://codereview.chromium.org/2934473003
Cr-Commit-Position: refs/heads/master@{#479799}

[modify] https://crrev.com/927047b0999e1fa6c164d581bdd5ec3b0e4d1f64/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h
[modify] https://crrev.com/927047b0999e1fa6c164d581bdd5ec3b0e4d1f64/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm

Hi Sharon,
Can you please verify this fix on canary today?
Thanks,

Hi Eric,
Are there any other pending CL's for this or can it be marked as fixed now?

Looks good in 61.0.3134.0 on iOS 10.3.2.

Tested in 61.0.3134.0 canary, iPhone 6S Plus iOS 10.3.2 issue is still reproducible.
Issue is also reproducible on 10.3.3 beta beta 2.

https://drive.google.com/a/google.com/file/d/0B3EcbqLuR5TLZGZVdDlSX1N2ckk/view

Whoa, that's exceedingly strange.

shbarezer@ -- If you run e.g. Chrome 59 or 60, is the strikethrough present?

On iPhone 6S Plus iOS 10.3.2 - 
1. 59.0.3071.102 stable strikethrough is present
2. 60.0.3112.34 beta strikethrough is present

The NextAction date has arrived: 2017-06-20

Following up with Apple https://bugreport.apple.com/web/?problemID=32909369

Sigh. This appears to be broken in 61.0.3138.0 on iPad too, so either I was wrong in #8 (chrome://version is currently busted due to Issue 734079) or the behavior is inconsistent. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b83a4fa3ea202ca497cc9d82fcbb815b3e2ec512

commit b83a4fa3ea202ca497cc9d82fcbb815b3e2ec512
Author: elawrence <elawrence@chromium.org>
Date: Thu Jun 22 20:31:02 2017

Revert "Remove workaround for strikethrough text in iOS omnibox"

This reverts commit 927047b0999e1fa6c164d581bdd5ec3b0e4d1f64. The
workaround still appears to be necessary on iPhones running iOS
10.3.2. We'll keep the workaround until we hear back from Apple
on our Radar bug report.

BUG= 711367 

Review-Url: https://codereview.chromium.org/2952273002
Cr-Commit-Position: refs/heads/master@{#481651}

[modify] https://crrev.com/b83a4fa3ea202ca497cc9d82fcbb815b3e2ec512/ios/chrome/browser/ui/omnibox/omnibox_view_ios.h
[modify] https://crrev.com/b83a4fa3ea202ca497cc9d82fcbb815b3e2ec512/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm

Have we verified that this is in fact fixed in 10.3.2 and teh bug can be resolved?

No. As noted in #15, the bug turned out not to be reliably fixed in iOS 10.3.2 and thus the removal was reverted.

Yesterday, Apple (Radar #32909369) requested that we have a look to see if they still have this bug in iOS 11 Beta 4, but I don't think anyone has tried yet. 

Ok thanks. Apple has requested via channels that we let them know if it's not fixed in iOS11. Can someone take a few minutes to test?

Tested on 62.0.3167.0 canary, iPhone7 iOS11, iPad Pro iOS11
Also tested on iPhone6S iOS 10.3.3.

Steps:
1. Launch app
2. Go to expired.badssl.com

Strikethrough text style renders in Omnibox.
Looks good.

The workaround is still in place (as far as i can tell from looking at the code, it checks > 10.3.0) so we would need to remove the workaround, and then test it to know if they actually fixed it. Correct?

Re 21: Yes, testing requires a private build. Last time I tried this, it took about 8 hours; someone on the Chrome Mac team who already has the right beta installed would likely be able to check more quickly. 

We verified today that backing out the CL works on iOS11, the text is struck-through.

elawrence: can you land the revert?

+olivierrobin who tested the backed out workaround on iOS11 

We wouldn't want to land the revert until the majority of Chrome users are running an iOS version with the fix. 

 Issue 751801  suggests that a new regression may have been introduced in iOS 11's handling of strikethrough.

This seems to work fine in iOS 11, and the new strikethrough issues seem to be fixed in 11.2. 
I will limit this workaround to iOS < 11.2. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dfdc5da02c11664a184893d2e236480dbeacc9e0

commit dfdc5da02c11664a184893d2e236480dbeacc9e0
Author: stkhapugin@chromium.org <stkhapugin@chromium.org>
Date: Wed Dec 06 13:56:25 2017

Removes strikethrough workarounds on iOS 11.2 and up.

The two workarounds that were fixing strikethrough issues introduced in
iOS 10.3 and iOS 11 seem to no longer be necessary with iOS 11.2.

correctly struck through. Try typing in the omnibox and navigating
to and from such a website; only "https" should be struck through.

Bug:  711367 ,  760964 
TEST: Navigate to a website with bad SSL and observe that "https" is
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id4f73b49281df024e2fbb621a74243440759b138
Reviewed-on: https://chromium-review.googlesource.com/805276
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#522077}
[modify] https://crrev.com/dfdc5da02c11664a184893d2e236480dbeacc9e0/ios/chrome/browser/ui/omnibox/omnibox_view_ios.mm

https strikethrough is displayed correctly both in regular and incognito tabs
Verified on M65.0.3292.0 canary
iOS: 11.2, Device: iPhoneX

There's no TODO associated with this bug; the workaround is still there and will be removed when we drop the last version of iOS to need it as part of our workaround cleanup when dropping old versions.