Issue metadata
Sign in to add a comment
|
Multi-line string resources have extra spaces |
||||||||||||||||||||
Issue descriptionr453701 which moved some string resources around has added indentation to multi-line string which shows up in the strings shown to the user. Examples are IDS_ASH_STATUS_TRAY_CAPS_LOCK_CANCEL_BY_SEARCH and IDS_ASH_STATUS_TRAY_CAPS_LOCK_CANCEL_BY_ALT_SEARCH. (To try it, you can turn on Caps Lock and check the popup).
,
Apr 17 2017
https://codereview.chromium.org/2826483002/ fixes it TPMs, I'm tagging merge request now because this affects strings and I need it backported before string freeze.
,
Apr 17 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/faf4c1d6b393e0d8e0b15d970d23294f0b7aa8b5 commit faf4c1d6b393e0d8e0b15d970d23294f0b7aa8b5 Author: jamescook <jamescook@chromium.org> Date: Mon Apr 17 19:09:37 2017 chromeos: Fix indentation in multi-line ash strings https://codereview.chromium.org/2720293002/ accidentally introduced extra spaces into some multi-line strings in the ash notification tray bubbles, primarily those for caps lock. Remove the extra spaces. Also fix a couple other cases of bad wrapping in strings. BUG= 711361 TEST=manually turn on caps lock, see proper indentation Review-Url: https://codereview.chromium.org/2826483002 Cr-Commit-Position: refs/heads/master@{#464966} [modify] https://crrev.com/faf4c1d6b393e0d8e0b15d970d23294f0b7aa8b5/ash/ash_strings.grd
,
Apr 17 2017
,
Apr 18 2017
,
Apr 18 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d562c1288d0f63e5c946204f1530ebf594e7b625 commit d562c1288d0f63e5c946204f1530ebf594e7b625 Author: James Cook <jamescook@chromium.org> Date: Tue Apr 18 18:10:51 2017 chromeos: Fix indentation in multi-line ash strings https://codereview.chromium.org/2720293002/ accidentally introduced extra spaces into some multi-line strings in the ash notification tray bubbles, primarily those for caps lock. Remove the extra spaces. Also fix a couple other cases of bad wrapping in strings. BUG= 711361 TEST=manually turn on caps lock, see proper indentation Review-Url: https://codereview.chromium.org/2826483002 Cr-Commit-Position: refs/heads/master@{#464966} (cherry picked from commit faf4c1d6b393e0d8e0b15d970d23294f0b7aa8b5) Review-Url: https://codereview.chromium.org/2821373002 . Cr-Commit-Position: refs/branch-heads/3071@{#36} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} [modify] https://crrev.com/d562c1288d0f63e5c946204f1530ebf594e7b625/ash/ash_strings.grd
,
Apr 19 2017
This bug requires manual review: There is .grd file changes and we are only 47 days from stable. Please contact the milestone owner if you have questions. Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jun 6 2017
I think this is already merged to M59 Grace to confirmed
,
Jun 16 2017
,
Jun 16 2017
,
Jan 22 2018
|
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by jamescook@chromium.org
, Apr 17 2017