If some information is missing from a credit card or address profile in the list selectors, there should be a string indicating to the user which information is missing, or if multiple items, "More information required"
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c45bd0f5bfda65c49b54527b994c08e8cf7203b5 commit c45bd0f5bfda65c49b54527b994c08e8cf7203b5 Author: mathp <mathp@chromium.org> Date: Tue Apr 18 20:24:29 2017 [Payments] Show what's missing for incomplete payment methods. Refactored logic to determine the completeness of a payment instrument. BUG= 711358 TEST=components_unittests Review-Url: https://codereview.chromium.org/2813203004 Cr-Commit-Position: refs/heads/master@{#465348} [modify] https://crrev.com/c45bd0f5bfda65c49b54527b994c08e8cf7203b5/chrome/browser/ui/views/payments/credit_card_editor_view_controller.cc [modify] https://crrev.com/c45bd0f5bfda65c49b54527b994c08e8cf7203b5/chrome/browser/ui/views/payments/payment_method_view_controller.cc [modify] https://crrev.com/c45bd0f5bfda65c49b54527b994c08e8cf7203b5/components/autofill/core/browser/validation.cc [modify] https://crrev.com/c45bd0f5bfda65c49b54527b994c08e8cf7203b5/components/autofill/core/browser/validation.h [modify] https://crrev.com/c45bd0f5bfda65c49b54527b994c08e8cf7203b5/components/payments/core/BUILD.gn [modify] https://crrev.com/c45bd0f5bfda65c49b54527b994c08e8cf7203b5/components/payments/core/autofill_payment_instrument.cc [modify] https://crrev.com/c45bd0f5bfda65c49b54527b994c08e8cf7203b5/components/payments/core/autofill_payment_instrument.h [modify] https://crrev.com/c45bd0f5bfda65c49b54527b994c08e8cf7203b5/components/payments/core/autofill_payment_instrument_unittest.cc [modify] https://crrev.com/c45bd0f5bfda65c49b54527b994c08e8cf7203b5/components/payments/core/payment_instrument.h
I believe Tommy is building this!
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/01c3eb8fd187b96cf17164ebcf15c69da1fa660e commit 01c3eb8fd187b96cf17164ebcf15c69da1fa660e Author: tmartino <tmartino@chromium.org> Date: Sat Apr 29 15:18:39 2017 [WebPayments] Show labels on incomplete profiles Adds labels describing missing information (e.g., "Add Email Address") to shipping + contact info views. Adds validation for shipping addresses. Adds cacheing to PaymentsProfileComparator, and adds an instance to PaymentRequestState so that cached values can be used throughout the request. BUG= 711358 , 709454 , TBR=mahmadi@chromium.org Review-Url: https://codereview.chromium.org/2847503002 Cr-Commit-Position: refs/heads/master@{#468242} [modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/contact_info_editor_view_controller.cc [modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/order_summary_view_controller_browsertest.cc [modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/payment_request_browsertest_base.cc [modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/payment_request_browsertest_base.h [modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/payment_request_dialog_view_ids.h [modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/payment_request_views_util.cc [modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/payment_request_views_util.h [modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc [modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/profile_list_view_controller.cc [modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/profile_list_view_controller.h [modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/shipping_address_editor_view_controller.cc [modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/chrome/browser/ui/views/payments/shipping_option_view_controller_browsertest.cc [modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/components/autofill/core/browser/autofill_profile_comparator.h [modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/components/payments/content/payment_request_state.cc [modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/components/payments/content/payment_request_state.h [modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/components/payments/core/BUILD.gn [modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/components/payments/core/payment_request_data_util.cc [modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/components/payments/core/payment_request_data_util.h [add] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/components/payments/core/payments_profile_comparator.cc [add] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/components/payments/core/payments_profile_comparator.h [add] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/components/payments/core/payments_profile_comparator_unittest.cc [delete] https://crrev.com/b75aa7267969141e12f5ece554be20d81d39b044/components/payments/core/profile_util.cc [delete] https://crrev.com/b75aa7267969141e12f5ece554be20d81d39b044/components/payments/core/profile_util.h [delete] https://crrev.com/b75aa7267969141e12f5ece554be20d81d39b044/components/payments/core/profile_util_unittest.cc [modify] https://crrev.com/01c3eb8fd187b96cf17164ebcf15c69da1fa660e/ios/chrome/browser/payments/payment_request.mm
Comment 1 by bugdroid1@chromium.org
, Apr 18 2017