New issue
Advanced search Search tips

Issue 711357 link

Starred by 1 user

Issue metadata

Status: Archived
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Feedback: Remove dropdown in Email field if user not logged in

Project Member Reported by weifangsun@chromium.org, Apr 13 2017

Issue description

In the case where the user has not logged into Chrome, we will be unable identify an email address and the Email field in the Feedback UI will default to "Report Anonymously".

Currently, the dropdown menu is enabled, but we should disable this functionality if there is only the 1 option.
 
Cc: xiy...@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a299993ec8d4a6a5c58dfa30dacf58a5bc8aa0d

commit 8a299993ec8d4a6a5c58dfa30dacf58a5bc8aa0d
Author: afakhry <afakhry@chromium.org>
Date: Mon Apr 17 23:20:32 2017

Feedback: User email section should only be visible when useful

When user is not logged on, default is to report anonymously. No
user email is available for us. In this case, there's no need to
show the user email section. So we'll keep it hidden until a valid
email entry is added.

BUG= 711357 
TEST=login in guest mode, open feedback app (Alt+Shift+i), notice that
     there's no user-email section at all. For logged in users, at least
     there are two entries; a user-email, and "Report anonymously".
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2826563002
Cr-Commit-Position: refs/heads/master@{#465057}

[modify] https://crrev.com/8a299993ec8d4a6a5c58dfa30dacf58a5bc8aa0d/chrome/browser/resources/feedback/html/default.html
[modify] https://crrev.com/8a299993ec8d4a6a5c58dfa30dacf58a5bc8aa0d/chrome/browser/resources/feedback/js/feedback.js

Status: Fixed (was: Assigned)
Labels: Merge-Request-59
Project Member

Comment 5 by sheriffbot@chromium.org, Apr 21 2017

Labels: -Merge-Request-59 Hotlist-Merge-Approved Merge-Approved-59
Your change meets the bar and is auto-approved for M59. Please go ahead and merge the CL to branch 3071 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), cmasso@(iOS), gkihumba@(ChromeOS), Abdul Syed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-59 Merge-Merged
The merge to M59 was committed, but for some reason bugdroid failed to detect that:

commit 0cb2bd8ce7dd3a0602fa60aefd4bba28479d0dbd
Author: Ahmed Fakhry <afakhry@google.com>
Date:   Thu Apr 20 17:15:23 2017 -0700

    [Merge to M59] Feedback: User email section should only be visible when useful
    
    When user is not logged on, default is to report anonymously. No
    user email is available for us. In this case, there's no need to
    show the user email section. So we'll keep it hidden until a valid
    email entry is added.
    
    TBR=xiyuan@chromium.org
    BUG= 711357 
    TEST=login in guest mode, open feedback app (Alt+Shift+i), notice that
         there's no user-email section at all. For logged in users, at least
         there are two entries; a user-email, and "Report anonymously".
    CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
    
    Review-Url: https://codereview.chromium.org/2826563002
    Cr-Commit-Position: refs/heads/master@{#465057}
    (cherry picked from commit 8a299993ec8d4a6a5c58dfa30dacf58a5bc8aa0d)
    
    Review-Url: https://codereview.chromium.org/2837483002 .
    Cr-Commit-Position: refs/branch-heads/3071@{#107}
    Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641}

Labels: -Hotlist-Merge-Approved

Comment 8 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 9 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 10 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment