New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 711351 link

Starred by 1 user
Status: Fixed
Owner:
█ l...@chromium.org
Last visit > 30 days ago
Closed: Apr 2017
Cc:
█ bmcquade@chromium.org
█ zh...@chromium.org
skare@chromium.org
isherman@chromium.org
asvitk...@chromium.org
█ rkaplow@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Task

Blocking:
issue 709259



Sign in to add a comment

Structure PageLoadTiming

Project Member Reported by l...@chromium.org, Apr 13 2017 
Currently PageLoadTiming has StyleSheetTiming as its sub-structure, we want to do the same thing to have sub-structure like ParseTiming, PaintTing, etc.

This would give more structure to PageLoadTiming, and perhaps help mojo message sending in the future.
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 14 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e95b6b3993dedab3ee364fa591ad032ab243fa6a

commit e95b6b3993dedab3ee364fa591ad032ab243fa6a
Author: lpy <lpy@chromium.org>
Date: Fri Apr 14 06:47:34 2017

[Page Load Metrics] Structure PageLoadTiming.

Add another 3 categories to PageLoadTiming to group different types of timing,
which are DocumentTiming, ParseTiming and PaintTiming.

DocumentTiming includes:
* dom_content_loaded_event_start
* load_event_start
* first_layout

ParseTiming includes:
* parse_start
* parse_stop
* parse_blocked_on_script_load_duration
* parse_blocked_on_script_load_from_document_write_duration
* parse_blocked_on_script_execution_duration
* parse_blocked_on_script_execution_from_document_write_duration

PaintTiming includes:
* first_paint
* first_text_paint
* first_image_paint
* first_contentful_paint
* first_meaningful_paint

BUG= 711351 

Review-Url: https://codereview.chromium.org/2806863003
Cr-Commit-Position: refs/heads/master@{#464693}

[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/aborts_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/amp_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/android_page_load_metrics_observer.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/core_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/css_scanning_page_load_metrics_observer.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer_unittest.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/delay_navigation_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/document_write_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/from_gws_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/media_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/no_state_prefetch_page_load_metrics_observer.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/omnibox_suggestion_used_page_load_metrics_observer.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/page_load_metrics_observer_test_harness.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/previews_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/protocol_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/resource_prefetch_predictor_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/service_worker_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/subresource_filter_metrics_observer_unittest.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/tab_restore_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/observers/ukm_page_load_metrics_observer_unittest.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/page_load_metrics_browsertest.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/page_load_metrics/page_load_tracker.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/common/page_load_metrics/page_load_metrics_messages.h
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/common/page_load_metrics/page_load_timing.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/common/page_load_metrics/page_load_timing.h
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/renderer/page_load_metrics/metrics_render_frame_observer.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/renderer/page_load_metrics/metrics_render_frame_observer_unittest.cc
[modify] https://crrev.com/e95b6b3993dedab3ee364fa591ad032ab243fa6a/chrome/renderer/page_load_metrics/page_timing_metrics_sender_unittest.cc

Comment 2 by l...@chromium.org, Apr 19 2017

Status: Fixed (was: Started)
►

Sign in to add a comment