New issue
Advanced search Search tips

Issue 711349 link

Starred by 2 users

Issue metadata

Status: Archived
Owner:
Closed: May 2017
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

A new feature where the launcher appears in immersive fullscreen

Project Member Reported by newcomer@chromium.org, Apr 13 2017

Issue description

I am implementing a change to the launcher UI.

When launching, the launcher will appear in immersive fullscreen with a blurred background instead of on top of a white window.



 
Project Member

Comment 1 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36544f37e39f0852922a83164f2b0a13c3431086

commit 36544f37e39f0852922a83164f2b0a13c3431086
Author: vadimt <vadimt@chromium.org>
Date: Wed Apr 26 00:37:21 2017

Revert of Implementation of a full screen app list and re-alphabetized switches (patchset #11 id:440001 of https://codereview.chromium.org/2802903003/ )

Reason for revert:
Suspecting that this breaks ash_unittests

Original issue's description:
> Implementation of a full screen app list behind a switch (as opposed to a feature flag).
>
> Also re-alphabetized switches in ash_switches.cc
>
> BUG= 711349 
>
> Review-Url: https://codereview.chromium.org/2802903003
> Cr-Commit-Position: refs/heads/master@{#467088}
> Committed: https://chromium.googlesource.com/chromium/src/+/23bdfdaf36a0e72e57e6bcf909d87fd4f5d5c663

TBR=sky@chromium.org,newcomer@chromium.org,newcomer@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 711349 

Review-Url: https://codereview.chromium.org/2840993002
Cr-Commit-Position: refs/heads/master@{#467181}

[modify] https://crrev.com/36544f37e39f0852922a83164f2b0a13c3431086/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/36544f37e39f0852922a83164f2b0a13c3431086/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/36544f37e39f0852922a83164f2b0a13c3431086/chrome/browser/ui/ash/app_list/app_list_presenter_delegate_mus.cc
[modify] https://crrev.com/36544f37e39f0852922a83164f2b0a13c3431086/testing/buildbot/filters/ash_mus_unittests.filter
[modify] https://crrev.com/36544f37e39f0852922a83164f2b0a13c3431086/ui/app_list/app_list_switches.cc
[modify] https://crrev.com/36544f37e39f0852922a83164f2b0a13c3431086/ui/app_list/app_list_switches.h
[modify] https://crrev.com/36544f37e39f0852922a83164f2b0a13c3431086/ui/app_list/demo/app_list_demo_views.cc
[modify] https://crrev.com/36544f37e39f0852922a83164f2b0a13c3431086/ui/app_list/presenter/app_list_presenter_impl_unittest.cc
[modify] https://crrev.com/36544f37e39f0852922a83164f2b0a13c3431086/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/36544f37e39f0852922a83164f2b0a13c3431086/ui/app_list/views/app_list_view.h
[modify] https://crrev.com/36544f37e39f0852922a83164f2b0a13c3431086/ui/app_list/views/app_list_view_unittest.cc
[modify] https://crrev.com/36544f37e39f0852922a83164f2b0a13c3431086/ui/aura/window.h

Project Member

Comment 2 by bugdroid1@chromium.org, Apr 26 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/145b24f9355dc8a7c59bfb93f3634eef1d555784

commit 145b24f9355dc8a7c59bfb93f3634eef1d555784
Author: newcomer <newcomer@chromium.org>
Date: Wed Apr 26 22:58:02 2017

Implementation of a full screen app list behind a switch (as opposed to a feature flag).

Also re-alphabetized switches in ash_switches.cc

BUG= 711349 

Review-Url: https://codereview.chromium.org/2802903003
Cr-Original-Commit-Position: refs/heads/master@{#467088}
Committed: https://chromium.googlesource.com/chromium/src/+/23bdfdaf36a0e72e57e6bcf909d87fd4f5d5c663
Review-Url: https://codereview.chromium.org/2802903003
Cr-Commit-Position: refs/heads/master@{#467496}

[modify] https://crrev.com/145b24f9355dc8a7c59bfb93f3634eef1d555784/ash/app_list/app_list_presenter_delegate.cc
[modify] https://crrev.com/145b24f9355dc8a7c59bfb93f3634eef1d555784/ash/app_list/app_list_presenter_delegate_unittest.cc
[modify] https://crrev.com/145b24f9355dc8a7c59bfb93f3634eef1d555784/chrome/browser/ui/ash/app_list/app_list_presenter_delegate_mus.cc
[modify] https://crrev.com/145b24f9355dc8a7c59bfb93f3634eef1d555784/testing/buildbot/filters/ash_mus_unittests.filter
[modify] https://crrev.com/145b24f9355dc8a7c59bfb93f3634eef1d555784/ui/app_list/app_list_switches.cc
[modify] https://crrev.com/145b24f9355dc8a7c59bfb93f3634eef1d555784/ui/app_list/app_list_switches.h
[modify] https://crrev.com/145b24f9355dc8a7c59bfb93f3634eef1d555784/ui/app_list/demo/app_list_demo_views.cc
[modify] https://crrev.com/145b24f9355dc8a7c59bfb93f3634eef1d555784/ui/app_list/presenter/app_list_presenter_impl_unittest.cc
[modify] https://crrev.com/145b24f9355dc8a7c59bfb93f3634eef1d555784/ui/app_list/views/app_list_view.cc
[modify] https://crrev.com/145b24f9355dc8a7c59bfb93f3634eef1d555784/ui/app_list/views/app_list_view.h
[modify] https://crrev.com/145b24f9355dc8a7c59bfb93f3634eef1d555784/ui/app_list/views/app_list_view_unittest.cc
[modify] https://crrev.com/145b24f9355dc8a7c59bfb93f3634eef1d555784/ui/aura/window.h

Status: Fixed (was: Unconfirmed)

Comment 4 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 5 by dchan@chromium.org, Jan 22 2018

Status: Archived (was: Fixed)

Sign in to add a comment