New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711341 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug

Blocked on:
issue 711339

Blocking:
issue 701833



Sign in to add a comment

Remove ash dependency.

Project Member Reported by thanhph@chromium.org, Apr 13 2017

Issue description

Use EnvObserver to get list of WindowTreeHosts from aura::Window.
This is the second refactor step to make devtools usable in Windows, Linux and ChromeOS.
 
Blocking: 701835
Blockedon: 711339
Blocking: -701835
Description: Show this description
Project Member

Comment 4 by bugdroid1@chromium.org, May 29 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4de8e9492ec943cc142295d28f34308655ae8ec1

commit 4de8e9492ec943cc142295d28f34308655ae8ec1
Author: thanhph <thanhph@chromium.org>
Date: Mon May 29 18:31:04 2017

Remove ash dependency.

Root window lists can be retrieved by observing EnvObserver callbacks.
Thus, ash/shell.cc is no longer needed. This intermediate step will
enable moving devtools out of ash.

BUG= 711341 

Review-Url: https://codereview.chromium.org/2865713003
Cr-Commit-Position: refs/heads/master@{#475365}

[modify] https://crrev.com/4de8e9492ec943cc142295d28f34308655ae8ec1/ash/devtools/ash_devtools_dom_agent.cc
[modify] https://crrev.com/4de8e9492ec943cc142295d28f34308655ae8ec1/ash/devtools/ash_devtools_dom_agent.h
[modify] https://crrev.com/4de8e9492ec943cc142295d28f34308655ae8ec1/ash/devtools/ash_devtools_unittest.cc

Status: Fixed (was: Available)
Labels: Hotlist-UI-DevTools

Sign in to add a comment