New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 711338 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: ----
Type: ----



Sign in to add a comment

Run CTS failing on chromium.android/Android WebView N (dbg)

Project Member Reported by tedc...@chromium.org, Apr 13 2017

Issue description

Comment 1 by boliu@chromium.org, Apr 13 2017

Components: Mobile>WebView
Labels: OS-Android
Owner: sgu...@chromium.org

Comment 2 by sgu...@chromium.org, Apr 13 2017

Owner: boliu@chromium.org

Comment 3 by boliu@chromium.org, Apr 13 2017

  00000000009649f8  base::debug::BreakDebugger()+32                                         /b/c/b/Android_arm64_Builder__dbg_/src/base/debug/debugger_posix.cc:251
  0000000000983130  logging::LogMessage::~LogMessage()+864                                  /b/c/b/Android_arm64_Builder__dbg_/src/base/logging.cc:759
  00000000009e5cec  base::ThreadRestrictions::AssertWaitAllowed()+124                       /b/c/b/Android_arm64_Builder__dbg_/src/base/threading/thread_restrictions.cc:76
  00000000009c8404  base::WaitableEvent::TimedWaitUntil(base::TimeTicks const&)+56          /b/c/b/Android_arm64_Builder__dbg_/src/base/synchronization/waitable_event_posix.cc:168
  00000000009c8724  base::WaitableEvent::Wait()+40                                          /b/c/b/Android_arm64_Builder__dbg_/src/base/synchronization/waitable_event_posix.cc:157
  00000000008e47dc  android_webview::AwFormDatabaseService::HasFormData()+220               /b/c/b/Android_arm64_Builder__dbg_/src/android_webview/browser/aw_form_database_service.cc:91
  v------>  HasFormData                                                             /b/c/b/Android_arm64_Builder__dbg_/src/android_webview/native/aw_form_database.cc:32
  000000000092edec  Java_org_chromium_android_1webview_AwFormDatabase_nativeHasFormData+36  /b/c/b/Android_arm64_Builder__dbg_/src/out/Debug/gen/android_webview/native/native_jni/android_webview/jni/AwFormDatabase_jni.h:39

Comment 4 by sgu...@chromium.org, Apr 13 2017

seems to be used by a lot of apps, some of which have over 100 million installs. with marmot that is the maximum we can get.

We can look at actual uses with UMA in M59 or M60 and get rid of it if really not used.
Is there a short term resolution here or should we revert the change and reland with fix?

Comment 6 by boliu@chromium.org, Apr 13 2017

fix here: https://codereview.chromium.org/2817923003/

just leave it red..? it's not a cq bot or anything

Comment 7 by sgu...@chromium.org, Apr 13 2017

Cc: yolandyan@chromium.org
yes there is a short term solution. Yoland can disable the test. however the CL is already up so don't know.
Disable CL: https://codereview.chromium.org/2815393002
Enable CL after the fix land for convinience: https://codereview.chromium.org/2818663004
Project Member

Comment 9 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ec04c80da1cceaa1b8f2c645a86860354541da90

commit ec04c80da1cceaa1b8f2c645a86860354541da90
Author: yolandyan <yolandyan@chromium.org>
Date: Thu Apr 13 20:33:44 2017

Disable testClearFormData CTS test

BUG= 711338 
TBR=sgurun@chromium.org

Review-Url: https://codereview.chromium.org/2815393002
Cr-Commit-Position: refs/heads/master@{#464529}

[modify] https://crrev.com/ec04c80da1cceaa1b8f2c645a86860354541da90/android_webview/tools/cts_config/expected_failure_on_bot.json

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/40b2b2d5c7a313d91e72096c3f07762801fd616c

commit 40b2b2d5c7a313d91e72096c3f07762801fd616c
Author: boliu <boliu@chromium.org>
Date: Fri Apr 14 00:58:59 2017

aw: Add allow wait for form database

Follow up fix to refs/heads/master@{#463849}. FormDatabase is similar to
CookieManager. It's thread-safe singleton class that needs answers
synchronously from the database thread in the public webview API.

Missed this in the first round because there are no instrumentation
tests covering this, so add a smoke test.

BUG= 711338 

Review-Url: https://codereview.chromium.org/2817923003
Cr-Commit-Position: refs/heads/master@{#464637}

[modify] https://crrev.com/40b2b2d5c7a313d91e72096c3f07762801fd616c/android_webview/browser/aw_form_database_service.cc
[add] https://crrev.com/40b2b2d5c7a313d91e72096c3f07762801fd616c/android_webview/javatests/src/org/chromium/android_webview/test/AwFormDatabaseTest.java
[modify] https://crrev.com/40b2b2d5c7a313d91e72096c3f07762801fd616c/android_webview/test/BUILD.gn
[modify] https://crrev.com/40b2b2d5c7a313d91e72096c3f07762801fd616c/base/threading/thread_restrictions.h

Project Member

Comment 11 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f44bb232631572abb14bc01f2c565af5e96f7d36

commit f44bb232631572abb14bc01f2c565af5e96f7d36
Author: yolandyan <yolandyan@chromium.org>
Date: Fri Apr 14 01:22:41 2017

Enable testClearFormData CTS

BUG= 711338 

Review-Url: https://codereview.chromium.org/2818663004
Cr-Commit-Position: refs/heads/master@{#464645}

[modify] https://crrev.com/f44bb232631572abb14bc01f2c565af5e96f7d36/android_webview/tools/cts_config/expected_failure_on_bot.json

Comment 12 by boliu@chromium.org, Apr 14 2017

Status: Fixed (was: Assigned)

Sign in to add a comment