New issue
Advanced search Search tips

Issue 711332 link

Starred by 3 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug

Blocked on:
issue 710335



Sign in to add a comment

Rewrite all FOO enum entries in Chromium code to kFoo

Project Member Reported by thakis@chromium.org, Apr 13 2017

Issue description

Project Member

Comment 1 by bugdroid1@chromium.org, Apr 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1262351d14e829049153dfe0b8f14b21c4b3b909

commit 1262351d14e829049153dfe0b8f14b21c4b3b909
Author: thakis <thakis@chromium.org>
Date: Thu Apr 13 17:12:55 2017

Update preferred style of spelling enums.

As discussed here:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/Hpkfudv5bac

Chromium historically used FOO for enums.  The Google styleguide
eventually evolved into preferring kFoo instead (while allowing both).
Since Blink now uses kFoo, and a few kFoos have snuck into Chromium's
code base, remove this custom rule.

BUG=711332

Review-Url: https://codereview.chromium.org/2820553002
Cr-Commit-Position: refs/heads/master@{#464447}

[modify] https://crrev.com/1262351d14e829049153dfe0b8f14b21c4b3b909/styleguide/c++/c++.md

Comment 2 by dcheng@chromium.org, Apr 13 2017

Blockedon: 710335
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0bab0b5c64d810574385e6d9ab4b1210f56d0c2

commit e0bab0b5c64d810574385e6d9ab4b1210f56d0c2
Author: Matt Mueller <mattm@chromium.org>
Date: Wed Sep 06 01:51:12 2017

c++11 styleguide: update enum naming notes and style guide link

Bug: 711332
Change-Id: Ie73ba46358d390dc904b0914ee0ce7eda03064b6
Reviewed-on: https://chromium-review.googlesource.com/651135
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Matt Mueller <mattm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#499843}
[modify] https://crrev.com/e0bab0b5c64d810574385e6d9ab4b1210f56d0c2/styleguide/c++/c++11.html

Project Member

Comment 4 by sheriffbot@chromium.org, Sep 6

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment